[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-22 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123500548 --- Diff: spec-cordova/prepare.spec.js --- @@ -63,103 +63,103 @@ describe('cordova/prepare', function () { spyOn(cordova_config, 'read').

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123426288 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123381062 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123380130 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'),

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123368145 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123367811 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123366636 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123366148 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123365358 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123364883 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123363271 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123362807 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123362714 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123362534 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123361446 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123356892 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357803 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123359362 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123356985 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123358080 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357310 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357886 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357728 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123356764 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123353714 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123352862 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123353941 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123358028 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357124 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123353085 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123359059 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357065 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123353162 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123350987 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123352070 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123353273 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123354184 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123354297 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123359196 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123358221 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -P

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

2017-06-21 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/567 CB-12361: Added unit tests for prepare.js ### What does this PR do? Add unit tests for prepare.js in prepare.spec.js. ### What testing has been done on this chang