Github user stevengill closed the pull request at:
https://github.com/apache/cordova-lib/pull/407
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-21866
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-217091665
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-217087853
Made the changes. LMK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r62104877
--- Diff: cordova-fetch/spec/package.json ---
@@ -0,0 +1,11 @@
+{
--- End diff --
Hmm. Maybe just name it differently. My concer
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r62101897
--- Diff: cordova-fetch/spec/package.json ---
@@ -0,0 +1,11 @@
+{
--- End diff --
I just copy it into temporary tests folder so I can
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r62100822
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contribu
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r62100600
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contribu
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r62000656
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more co
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r62000572
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more co
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r61999817
--- Diff: cordova-fetch/spec/package.json ---
@@ -0,0 +1,11 @@
+{
--- End diff --
Do we need a separate `package.json` for specs
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r61998473
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more co
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r61998292
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more co
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-216691951
Hey Everyone,
I think the first implementation of this is ready to hit master behind the
--fetch flag. It includes platform and plugin fetching + removin
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-215918679
## [Current coverage][cc-pull] is **13.19%**
> Merging [#407][cc-pull] into [master][cc-base-branch] will increase
coverage by **-86.81%**
```diff
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60995427
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contribu
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60995226
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contribu
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60899092
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more co
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60898584
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more co
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-199661470
Plugman PR adding --fetch flag support
https://github.com/apache/cordova-plugman/pull/87
---
If your project is set up for it, you can reply to this email and h
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55578321
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contribu
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55575046
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributo
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55567900
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributo
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-194441672
To-do: add cordova-lib tests for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
cool
On Wed, Mar 9, 2016 at 12:53 PM, stevengill wrote:
> Github user stevengill commented on a diff in the pull request:
>
> https://github.com/apache/cordova-lib/pull/407#discussion_r55480177
>
> --- Diff: cordova-fetch/index.js ---
> @@ -0,0 +1,176 @@
> +/**
> + Licensed t
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55480177
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contribu
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55480086
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contribu
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55473246
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributo
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55472886
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributo
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-194065776
Needs https://github.com/apache/cordova-cli/pull/239.
Discussion at https://github.com/cordova/cordova-discuss/pull/33
---
If your project is set up for
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-194059148
I decided to write the tests in node-tap. I am now regretting that decision
a bit. Tests randomly timeout and fail. Doesn't happen in actual use.
---
If your p
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/407
CB-9858 Cordova Fetch Work
This is not ready to merge yet! Opening the PR so it is easy to manage
diffs and take feedback
You can merge this pull request into a Git repository by running:
32 matches
Mail list logo
