Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-137912540
CB-9560 is merged as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-137896650
Thanks! Please look at merging CB-9560 when you time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user marcuspridham closed the pull request at:
https://github.com/apache/cordova-lib/pull/292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-137896168
#merged !
Please, close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-137895107
#merged !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Confirmed here: https://people.apache.org/committer-index.html
Middle name and all ...
My team is hiring!
@purplecabbage
risingj.com
On Fri, Sep 4, 2015 at 4:36 PM, marcuspridham wrote:
> Github user marcuspridham commented on the pull request:
>
> https://github.com/apache/cordova-lib/pul
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-137878645
Yep. I signed the ICLA awhile ago. I have done some pull requests to
Cordova before.
---
If your project is set up for it, you can reply to this email and
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-137877915
@marcuspridham , did you sign the
[ICLA](http://www.apache.org/licenses/#clas) ?
---
If your project is set up for it, you can reply to this email and have your
re
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-136775078
LGTM !! will be merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-136774986
Awesome, Thanks for validating.
The case where we specify a searchpath on the CLI and another one in the
./cordova/config.json doesn't go through. I will open u
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-136482068
Thanks. I just tried these cases it appears to already work. The search
path provided with prepare passes through
https://github.com/apache/cordova-lib/blob/
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-136472329
Thanks for suggesting these changes.
However, I have a suggestion :
As it currently stands, it seems like adding adding a platform or restoring
from co
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-136471159
Thanks for suggesting these changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/292#discussion_r38341095
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -56,7 +56,7 @@ function prepare(options) {
var hooksRunner = new HooksRunner(projectRoot);
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/292#discussion_r38340821
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -56,7 +56,7 @@ function prepare(options) {
var hooksRunner = new HooksRunner(projectRoot);
GitHub user marcuspridham opened a pull request:
https://github.com/apache/cordova-lib/pull/292
CB-8993 Plugin restore ignores search path
When restoring a platform the search path needs to be provided otherwise
plugins will always be resolved to npm.
You can merge this pull req
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-lib/pull/224#issuecomment-110080565
Thanks. I filled out a Apache CLA back in January and got confirmation
from Apache Secretary Craig Russell. I have done a pull request in the past
for CB-83
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/224#issuecomment-110066248
@marcuspridham PR looks. Do you have Apache CLA signed? I can not seem to
find it if you have. Before I can merge this one, you need to sign Apacheâs
Contributor L
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/224#issuecomment-104401689
Good catch. This change looks good to me !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user marcuspridham opened a pull request:
https://github.com/apache/cordova-lib/pull/224
CB-8993 Plugin restore ignores search path
Passes provided searchpath to the plugin restore after adding a platform.
Without this I would get errors sometimes about "loadLocalPlugins cal
21 matches
Mail list logo
