Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-77650511
closing because this Pull Request has been merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user omefire closed the pull request at:
https://github.com/apache/cordova-lib/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-77011164
@agrieve , I addressed your comments. could you please take another look ?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25652223
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25629266
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25626571
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25626517
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25604353
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25230972
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25224883
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25224748
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25224693
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75670437
I think this PR is ready to be merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75623519
@gorkem, yes platforms.json is a new file in the platforms directory. think
of it as the equivalent of the .fetch.json file we have for plugins.
---
If your project
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25184230
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75350562
Is platforms.json an existing file? Is it used anywhere else? I suspect
that it is a new file and I am not sure if it is really needed
---
If your project is set up
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75336770
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75314035
@vladimir-kotikov Thanks for reviewing, All your reviews have been
addressed, please take another look.
---
If your project is set up for it, you can reply to this
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25100062
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
});
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25100140
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
});
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25098877
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25098622
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25098780
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25096560
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25096417
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095419
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095040
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095044
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095035
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -158,6 +160,11 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75298325
@agrieve , @vladimir-kotikov and @gorkem, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/170
CB-8499 `cordova platform save` should save all currently installed
platforms and their versions/git-url/folder-location into config.xml.
CB-8499 `cordova platform save` should save all current
31 matches
Mail list logo
