[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-08-20 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/7#issuecomment-52792885 bump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-03 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/pull/7#issuecomment-45026274 Please don't expect same day turnaround. It's trivial for me to give feedback, but I'm still trying to figure out if what you're doing makes sense. I'm on vaca

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-03 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-lib/pull/7#issuecomment-45021216 Hi @jsoref , here is the PR: https://github.com/apache/cordova-lib/pull/7 with a single commit: https://github.com/martincgg/cordova-lib/commit/f964956b9c90db36325fb

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-03 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-lib/pull/7#issuecomment-44997019 @jsoref Clean commit as requested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-03 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-lib/pull/7#issuecomment-44980697 Some changes: - Added targetUtils variable - Removed unrelated changes - Removed unrelated whitespaces -Added some comments -Changed Blackberr

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-03 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/7#discussion_r13337982 --- Diff: cordova-lib/src/cordova/info.js --- @@ -31,23 +31,50 @@ var cordova_util = require('./util'), // Execute using a child_process exec,

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-03 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/7#discussion_r13337873 --- Diff: cordova-lib/src/cordova/info.js --- @@ -31,23 +31,50 @@ var cordova_util = require('./util'), // Execute using a child_process exec, for

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-03 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/7#discussion_r13337337 --- Diff: cordova-lib/src/cordova/info.js --- @@ -31,23 +31,50 @@ var cordova_util = require('./util'), // Execute using a child_process exec,

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-03 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/7#discussion_r13336691 --- Diff: cordova-lib/src/cordova/info.js --- @@ -31,23 +31,50 @@ var cordova_util = require('./util'), // Execute using a child_process exec, for

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-03 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/7#discussion_r13335471 --- Diff: cordova-lib/src/cordova/info.js --- @@ -31,23 +31,50 @@ var cordova_util = require('./util'), // Execute using a child_process exec,

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-03 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/7#discussion_r13335220 --- Diff: cordova-lib/src/cordova/info.js --- @@ -62,15 +89,15 @@ module.exports = function info() { //Get Node version

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-02 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/7#discussion_r13311258 --- Diff: cordova-lib/src/cordova/info.js --- @@ -84,10 +111,10 @@ module.exports = function info() { function getPlatforms(projectRoot) { var

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-02 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/7#discussion_r13311217 --- Diff: cordova-lib/src/cordova/info.js --- @@ -62,15 +89,15 @@ module.exports = function info() { //Get Node version Q('

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-02 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/7#discussion_r13311181 --- Diff: cordova-lib/src/cordova/info.js --- @@ -31,23 +31,50 @@ var cordova_util = require('./util'), // Execute using a child_process exec, for

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-02 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-lib/pull/7#issuecomment-44895119 Hey @jsoref can you take a look at this, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y