[GitHub] cordova-lib issue #499: Cb 11960

2017-01-31 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/499 Thanks!! @shazron I'll delete those! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/499 There are 11 occurrences of a `.svn` file, delete those. I think I see a lot of duplicate files, I suppose that can't be helped (if not we could have used the `--template` functionality

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/499 ``` 1) (save flag) prepare Test 032 : spec.24 should restore only specified platform Message: expected C:\projects\cordova-lib\cordova-lib\spec-cordova\temp\testApp\platforms\w

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-26 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/499 Thank you @shazron @dpogue Going to take a look at this today. I'll keep you posted! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-26 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/499 That's using an old version of the cordova-android repo then, since that particular syntax issue was fixed [back in November](https://github.com/apache/cordova-android/commit/36646eb527826dad8124

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/499 ``` C:\Users\appveyor\.cordova\lib\npm_cache\cordova-android\6.0.0\package\bin\templates\cordova\lib\AndroidStudio.js:16 for(file of eclipseFiles) { ^^ ``` `f

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-25 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/499 ya On Wed, Jan 25, 2017 at 2:35 PM, Audrey wrote: > *@audreyso* commented on this pull request. > -- > > In cordova-lib/spec-cordova/f

[GitHub] cordova-lib issue #499: Cb 11960

2016-11-22 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/499 The travis failures are fine. Need to look into the appveyor failures though --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib issue #499: Cb 11960

2016-11-22 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/499 Test 005 may periodically fail due to https://issues.apache.org/jira/browse/CB-12170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib issue #499: Cb 11960

2016-10-17 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/499 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/499?src=pr) is 80.02% (diff: 44.64%) > Merging [#499](https://codecov.io/gh/apache/cordova-lib/pull/499?src=pr) into [