[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/468 It is! https://cordova.apache.org/news/2017/01/23/tools-release.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/468 @stevengill Can I assume support for this feature is out in the cordova@6.5.0 release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/468 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/468 Then looks good to me, I can't think any example right now where the same file should be needed for all platforms --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/468 For clarity, "top-level support" means allowing `resource-file` tags that aren't scoped to a particular platform. i.e., ```xml ``` This would copy `./foo.xm

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/468 I think top level might make sense here if it's a file that the IDE needs but not the app (configuration file like google-services.json/plist) Can the launch images and icons be out

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/468 SGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/468 Any other input here? Are we in agreement to remove the top-level file copying? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/468 I'm happy to leave out support for top-level `resource-file` tags, since I agree it doesn't really make sense --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/468 So this is the first step in adding `resource-file`. Future updates to platform API's will use `getFileResources` to do the copying of these files `src`attribute to the `target` attribute.

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/468 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/468?src=pr) is 80.62% (diff: 100%) > Merging [#468](https://codecov.io/gh/apache/cordova-lib/pull/468?src=pr) into [ma