[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-20 Thread riknoll
Github user riknoll commented on the issue: https://github.com/apache/cordova-lib/pull/449 Yep! The guide for writing xml references is [here](https://github.com/apache/cordova-docs/blob/master/doc/docs-STYLEGUIDE.md#xml-references). The file you need to edit is the one I linked in my

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-20 Thread ktop
Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/449 @riknoll yea sure. Are there instructions on how/where documentation goes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-20 Thread riknoll
Github user riknoll commented on the issue: https://github.com/apache/cordova-lib/pull/449 Done! Sorry for the delay. @ktop can you open a PR documenting this feature in the [plugin.xml reference](https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/plugin_ref/spec.md)

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-20 Thread ktop
Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/449 @riknoll I've rebased so this should be ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-16 Thread ktop
Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/449 Cool, let me rebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-16 Thread macdonst
Github user macdonst commented on the issue: https://github.com/apache/cordova-lib/pull/449 LGTM! Sorry for taking so long. My workspace is in a bad way and I think I need to kill it with fire and setup the whole thing from scratch. Once this gets into a release I have about 4

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-14 Thread riknoll
Github user riknoll commented on the issue: https://github.com/apache/cordova-lib/pull/449 This is working fine for me! When this feature gets documented, we need to make sure to document how to get your project back in order if you mess it up by adding a plugin with `--force`. I thin

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-13 Thread ktop
Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/449 My latest commit will find all conflicts when --force is used and remove them before adding the new plugin. @riknoll or @macdonst can you try it out and let me know if you have any issues?

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-09 Thread ktop
Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/449 ahh must be because I didn't set up my git config after my computer got re-imaged. I have it set now and hopefully it will appear after I rebase. --- If your project is set up for it, you can rep

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-09 Thread macdonst
Github user macdonst commented on the issue: https://github.com/apache/cordova-lib/pull/449 @ktop I also see "unknown" for your name in `git log`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-09 Thread riknoll
Github user riknoll commented on the issue: https://github.com/apache/cordova-lib/pull/449 @ktop Run `git log` and check out the author field. Your email shows up, but the name is unknown for some reason. As for the force add thing, that sounds fine to me. There are two possib

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-09 Thread ktop
Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/449 @riknoll Where does it say "unknown"? I don't see it. If we have plugin-1, plugin-2 --force, and then add plugin-3 with --force, plugin-1 and plugin-2 should not be applied correct?

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-09 Thread riknoll
Github user riknoll commented on the issue: https://github.com/apache/cordova-lib/pull/449 I've tested it out and I think there needs to be a slight tweak to the `--force` behavior. When a plugin is force added, any conflicting edit-config changes it has should not be applied. Otherwi

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-09 Thread riknoll
Github user riknoll commented on the issue: https://github.com/apache/cordova-lib/pull/449 @ktop the author name on the commit is "unknown" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-03 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/449 ## [Current coverage][cc-pull] is **80.56%** > Merging [#449][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@ master #449 diff @