RE: [GitHub] cordova-firefoxos pull request: CB-7567 Don't use adm-zip because

2015-02-20 Thread Jon Buckley
Hello Apache Cordova devs! I've submitted a patch ( https://github.com/apache/cordova-firefoxos/pull/22 ) to fix https://issues.apache.org/jira/browse/CB-7567 . I've emailed my ICLA in, so I'm wondering what the next step is? Could I get a review from someone? Thanks, Jon

[GitHub] cordova-firefoxos pull request: CB-7567 Don't use adm-zip because ...

2015-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-firefoxos pull request: CB-7567 Don't use adm-zip because ...

2015-02-18 Thread jbuck
GitHub user jbuck opened a pull request: https://github.com/apache/cordova-firefoxos/pull/22 CB-7567 Don't use adm-zip because it creates invalid zip files This patch is a fix for [CB-7567](https://issues.apache.org/jira/browse/CB-7567) where the current build step using [adm-zip c