Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60677936
--- Diff: www/static/js/algolia.js ---
@@ -0,0 +1,21 @@
+---
+---
+
+{% if page.version %}
+{% assign version = page.version %}
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60674594
--- Diff: www/static/css-src/main.scss ---
@@ -194,6 +194,23 @@ code {
color: #00;
}
+/* algolia search formatting */
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60334146
--- Diff: www/static/css-src/main.scss ---
@@ -194,6 +194,23 @@ code {
color: #00;
}
+/* algolia search formatting */
+.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/581#issuecomment-212179026
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329788
--- Diff: conf/_config.yml ---
@@ -81,3 +81,5 @@ kramdown:
# exclude these directories from the build
exclude:
- static/css-src
+
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/581#issuecomment-212170562
@dblotsky Let me know when you are done... I will merge the commits to one
commit.
---
If your project is set up for it, you can reply to this email and have
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329745
--- Diff: conf/_config.yml ---
@@ -81,3 +81,5 @@ kramdown:
# exclude these directories from the build
exclude:
- static/css-src
+
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329718
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,20 @@
---
-
+{% if page.language %}
+{% assign language = page.langu
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329685
--- Diff: www/_includes/algolia.html ---
@@ -0,0 +1,14 @@
+{% if page.version %}
+{% assign version = page.version %}
+{% else %}
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329698
--- Diff: www/_includes/header.html ---
@@ -29,18 +29,24 @@
Get
Started
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329672
--- Diff: conf/_config.yml ---
@@ -81,3 +81,5 @@ kramdown:
# exclude these directories from the build
exclude:
- static/css-src
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329201
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,20 @@
---
-
+{% if page.language %}
+{% assign language = page.languag
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329126
--- Diff: www/_includes/header.html ---
@@ -29,18 +29,24 @@
Get
Started
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328845
--- Diff: www/_includes/algolia.html ---
@@ -0,0 +1,14 @@
+{% if page.version %}
+{% assign version = page.version %}
+{% else %}
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328800
--- Diff: conf/_config.yml ---
@@ -81,3 +81,5 @@ kramdown:
# exclude these directories from the build
exclude:
- static/css-src
+
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328734
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.langu
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328488
--- Diff: www/static/css-src/main.scss ---
@@ -194,6 +194,23 @@ code {
color: #00;
}
+/* algolia search formatting */
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328530
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.langu
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328452
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.langu
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328435
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.langu
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60328400
--- Diff: www/_includes/head.html ---
@@ -18,6 +18,9 @@
{% endif %}
+
+https://cdn.jsdelivr.net/docsearch
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60314159
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.languag
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60313932
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.languag
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60313371
--- Diff: www/static/css-src/main.scss ---
@@ -194,6 +194,23 @@ code {
color: #00;
}
+/* algolia search formatting */
+.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60313002
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.languag
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60312938
--- Diff: www/_layouts/base.html ---
@@ -3,12 +3,27 @@
---
-
+{% if page.language %}
+{% assign language = page.languag
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60312014
--- Diff: www/_includes/head.html ---
@@ -18,6 +18,9 @@
{% endif %}
+
+https://cdn.jsdelivr.net/docsearch.j
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/581#issuecomment-211647212
Let's merge this only after indexing is complete
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/581#issuecomment-211563103
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/581
CB-11104: Integrate Algolia Search to cordova docs
@nikhilkh @dblotsky @riknoll @rakatyal Could you please review this PR?
Note: Please do NOT merge this PR now.
You can merge thi
31 matches
Mail list logo
