Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-213585837
LGTM! Just a few nitpicks on the descriptions themselves. Code looks good
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/575#discussion_r60801641
--- Diff: www/docs/en/dev/guide/support/index.md ---
@@ -19,6 +19,7 @@ license: >
title: Corodva support by platform
toc_title: Platform
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/575#discussion_r60801563
--- Diff: www/docs/en/dev/guide/appdev/whitelist/index.md ---
@@ -19,6 +19,7 @@ license: >
title: Whitelist Guide
toc_title: Whitelisting
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/575#discussion_r60801496
--- Diff: www/docs/en/dev/guide/hybrid/webviews/index.md ---
@@ -19,6 +19,7 @@ license: >
title: Embedding WebViews
toc_title: Embed Cord
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-212685445
@riknoll please give this another look. It's now using the changes from
[CB-11126][1].
[1]: https://issues.apache.org/jira/browse/CB-11126
---
If your p
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-209013648
@dblotsky why change the headers from what's in the TOC? It might be a
little weird to have two links on the page with different text going to the
same place. Same
Github user devgeeks commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-208684628
Looks nice
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-208684175
Screenshot:
---
If your project is set up fo
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/575
CB-10996 Updating docs index page to match new content.
@riknoll @nikhilkh @rakatyal @devgeeks please take a look when you have a
moment.
You can merge this pull request into a Git repositor
10 matches
Mail list logo
