Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-android/pull/171#issuecomment-88243999
great, thanks for that, makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/171#issuecomment-88189256
Awesome! Merged and made one minor change: Removed onCordovaInit from
CordovaInterface (but left it in CordovaInterfaceImpl). If it were to be called
from Cordov
Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/171#discussion_r27500998
--- Diff: framework/src/org/apache/cordova/CordovaWebViewImpl.java ---
@@ -500,6 +500,7 @@ public void onPageFinishedLoading(String url) {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/171#discussion_r27482230
--- Diff: framework/src/org/apache/cordova/CordovaWebViewImpl.java ---
@@ -500,6 +500,7 @@ public void onPageFinishedLoading(String url) {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/171#discussion_r27482005
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -119,4 +130,29 @@ public void onSaveInstanceState(Bundle outState) {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/171#discussion_r27481986
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -119,4 +130,29 @@ public void onSaveInstanceState(Bundle outState) {
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-android/pull/171
solves CB-8768 issue where onActivityResult gets called before onResume
after MainActivity gets killed
situation: one of the plugins launches startActivityForResult and the
Android OS dec
Github user thehuijb closed the pull request at:
https://github.com/apache/cordova-android/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/170#discussion_r27392930
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -314,10 +318,52 @@ public void startActivityForResult(Intent intent, int
requ
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/170#discussion_r27391907
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -314,10 +318,52 @@ public void startActivityForResult(Intent intent, int
reque
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-android/pull/170
solves CB-8768 issue where onActivityResult gets called before onResume
after MainActivity gets killed
if one of the plugins launches startActivityForResult and the Android OS
decides to
12 matches
Mail list logo
