[GitHub] cordova-android pull request: Fix potential null pointer error iss...

2014-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android pull request: Fix potential null pointer error iss...

2014-12-10 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/126#issuecomment-66558156 Have a read of the last line of the javadoc. The function should either return a new object, or throw a FileNotFound exception (never returns null) --- If your

[GitHub] cordova-android pull request: Fix potential null pointer error iss...

2014-10-09 Thread agamemnus
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-android/pull/126#issuecomment-58514514 Doesn't a FileNotFoundException end the program? (sorry, not sure...) The idea is to prevent that and let everything run normally. --- If your project is set

[GitHub] cordova-android pull request: Fix potential null pointer error iss...

2014-10-09 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/126#issuecomment-58511873 From the [JavaDoc](http://developer.android.com/reference/android/content/ContentResolver.html#openAssetFileDescriptor(android.net.Uri, java.lang.String, android

[GitHub] cordova-android pull request: Fix potential null pointer error iss...

2014-10-08 Thread agamemnus
GitHub user agamemnus opened a pull request: https://github.com/apache/cordova-android/pull/126 Fix potential null pointer error issue. I am writing a Google Play APK expansion library. All the libraries I have seen so far store version data inside the content provider's ta