Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/139#discussion_r2297
--- Diff: spec/create.spec.js ---
@@ -1,82 +0,0 @@
-/**
--- End diff --
moving files from `spec/` to `test/spec` should be in a distin
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/139#discussion_r2269
--- Diff: package.json ---
@@ -23,7 +22,6 @@
"shelljs": "^0.2.6"
},
"devDependencies": {
-"jasmine-node": "~
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/139#discussion_r2253
--- Diff: package.json ---
@@ -13,8 +13,7 @@
"apache"
],
"scripts": {
-"test": "jasmine-node --color spec",
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/139#discussion_r2227
--- Diff: bin/templates/cordova/lib/run.js ---
@@ -129,4 +167,4 @@ module.exports.help = function(args) {
console.log('--emulator : Will d
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/139#discussion_r22111059
--- Diff: bin/templates/cordova/lib/run.js ---
@@ -49,12 +54,45 @@ var path = require('path'),
install_target = '--emulator';
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/139#discussion_r22111025
--- Diff: bin/templates/cordova/lib/run.js ---
@@ -49,12 +54,45 @@ var path = require('path'),
install_target = '--emulator';
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/139#discussion_r22110985
--- Diff: bin/templates/cordova/lib/run.js ---
@@ -19,6 +19,10 @@
under the License.
*/
+/* jshint node:true, bitwise:true,
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/139#discussion_r22110967
--- Diff: bin/lib/check_reqs.js ---
@@ -59,9 +59,13 @@ module.exports.get_target = function() {
return extractFromFile(path.join(ROOT, 'fr
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/139#discussion_r22110916
--- Diff: .travis.yml ---
@@ -1,5 +1,4 @@
language: android
install: npm install
script:
-- npm test
-- npm run test-bui
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-android/pull/139
--list support for android
For more details please check the dev mailing list and the [JIRA
issue](https://issues.apache.org/jira/browse/CB-8168)
You can merge this pull request into a Git
11 matches
Mail list logo
