[GitHub] cordova-plugin-camera pull request: [CB-10093][CB-9960][android] f...

2015-12-03 Thread sencenan
Github user sencenan commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/143#issuecomment-161787751 @riknoll that's my finding too with regard to ExifInterface class. I do think copying the image could be a viable solution like @purplecabbage

[GitHub] cordova-plugin-camera pull request: [CB-10093][CB-9960][android] f...

2015-12-02 Thread sencenan
GitHub user sencenan opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/143 [CB-10093][CB-9960][android] fix error resolving content uri to file url fixing: https://issues.apache.org/jira/browse/CB-10093 Different app returns different uri. This is

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

2015-12-02 Thread sencenan
Github user sencenan commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161523938 Making a new one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

2015-12-02 Thread sencenan
Github user sencenan closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

2015-12-02 Thread sencenan
Github user sencenan commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161390659 How would I associate my full name with my github id? I also fixed the problem with Google Photos which touches the same area of code. Should I remove

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

2015-12-01 Thread sencenan
Github user sencenan commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161089732 ICLA signed and mailed to. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

2015-12-01 Thread sencenan
Github user sencenan commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/141#discussion_r46334032 --- Diff: src/android/FileHelper.java --- @@ -79,30 +79,59 @@ public static String getRealPath(String uriString, CordovaInterface cordova

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

2015-12-01 Thread sencenan
Github user sencenan commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/141#discussion_r46334003 --- Diff: src/android/FileHelper.java --- @@ -79,30 +79,59 @@ public static String getRealPath(String uriString, CordovaInterface cordova

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

2015-12-01 Thread sencenan
Github user sencenan commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161008858 Hi, I will get the CLA signed later today when i have some time. For step to reproduce try this: - device: android 5.1 - use

[GitHub] cordova-plugin-camera pull request: m: fix the crash when the uri ...

2015-11-30 Thread sencenan
GitHub user sencenan opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/141 m: fix the crash when the uri passed into outputModifiedBitmap() is not a document URI files picked from the Gallery app is in the format of ``` content://media

[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...

2015-11-02 Thread sencenan
Github user sencenan commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-153207385 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: Use cp instead of mv, as it would fail i...

2015-06-12 Thread sencenan
Github user sencenan commented on the pull request: https://github.com/apache/cordova-lib/pull/245#issuecomment-111574603 @omefire my workspace and /tmp are mounted on different harddrives. Please also see this comment: https://github.com/apache/cordova-lib/blob

[GitHub] cordova-lib pull request: Use cp instead of mv, as it would fail i...

2015-06-10 Thread sencenan
GitHub user sencenan opened a pull request: https://github.com/apache/cordova-lib/pull/245 Use cp instead of mv, as it would fail if tmp_dir is mounted on a dif… Use cp instead of mv, as it would fail if tmp_dir is mounted on a different device from the plugin_dir. The tmp_dir is