[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2017-09-22 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/492 @andreszs Something like this should work: ```xml ``` --- - To unsubscribe, e-mail: dev

[GitHub] cordova-docs pull request #727: CB-13247 - Blog post for Cordova iOS 4.5.0 R...

2017-09-09 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/727#discussion_r137936833 --- Diff: www/_posts/2017-09-08-ios-release.md --- @@ -0,0 +1,72 @@ +--- +layout: post +author: +name: Shazron Abdullah +url

[GitHub] cordova-docs pull request #727: CB-13247 - Blog post for Cordova iOS 4.5.0 R...

2017-09-09 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/727#discussion_r137933316 --- Diff: www/_posts/2017-09-08-ios-release.md --- @@ -0,0 +1,72 @@ +--- +layout: post +author: +name: Shazron Abdullah +url

[GitHub] cordova-android issue #310: [CB-10916] Support display name for Android

2017-07-14 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/310 Sorry, been on vacation the past few weeks, but it looks like we've already bundled in the required version of cordova-common, so this is good to go! --- If your project is set up f

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

2017-06-21 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/566#discussion_r123302742 --- Diff: src/cordova/plugin/search.js --- @@ -0,0 +1,41 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-docs pull request #710: Added instruction to install Ruby Gems local...

2017-06-12 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/710#discussion_r121519778 --- Diff: README.md --- @@ -101,9 +101,9 @@ Verify the installation by running: Once Ruby and JavaScript are installed, install Ruby dependencies

[GitHub] cordova-docs pull request #709: CB-10916 - Add documentation about display n...

2017-06-10 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-docs/pull/709 CB-10916 - Add documentation about display name ### Platforms affected ### What does this PR do? Add documentation for `` to the config.xml reference page

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

2017-06-07 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 @shazron All good now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS

2017-06-07 Thread dpogue
Github user dpogue closed the pull request at: https://github.com/apache/cordova-ios/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS

2017-06-07 Thread dpogue
GitHub user dpogue reopened a pull request: https://github.com/apache/cordova-ios/pull/228 [CB-10916] Support display name for iOS This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453. You can merge this pull request into a Git repository by

[GitHub] cordova-android pull request #382: CB-12859: document how to run the native ...

2017-05-25 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/382#discussion_r118572485 --- Diff: test/README.md --- @@ -0,0 +1,58 @@ + + +# Cordova Android Test Project + +The project in this directory is an Android

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-05-03 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r114663941 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,140 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-05-03 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r114663690 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,140 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-05-01 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r114229983 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,48 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-05-01 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r114229964 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,48 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-05-01 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r114229936 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,48 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-05-01 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r114229886 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,48 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-05-01 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r114229916 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,48 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-05-01 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r114229972 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,48 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-ios issue #254: Expose CDVCommandStatus enum to Swift

2017-04-26 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/254 Yes, the breaking change is only on the Swift side --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS

2017-04-26 Thread dpogue
GitHub user dpogue reopened a pull request: https://github.com/apache/cordova-ios/pull/228 [CB-10916] Support display name for iOS This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453. You can merge this pull request into a Git repository by

[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS

2017-04-26 Thread dpogue
Github user dpogue closed the pull request at: https://github.com/apache/cordova-ios/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

2017-04-26 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 @fredgalvao Personally, I think your idea is the right way to go in terms of project structure, and should definitely be brought up for discussion on the dev list (because it probably has

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

2017-04-25 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 @shazron This can go in to 4.4.1 now that cordova-common changes are merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-04-21 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/321 With regards to point 1 above, I've found the root cause: In a project-level config.xml, `resource-file` is only supported under a `platform` tag. These files get copied into the n

[GitHub] cordova-android pull request #377: CB-8980: Ensure copied resource-files are...

2017-04-21 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-android/pull/377 CB-8980: Ensure copied resource-files are cleaned Requires https://github.com/apache/cordova-lib/pull/547 for the intended functionality, but is safe to merge even without it

[GitHub] cordova-ios pull request #309: CB-8980: Ensure copied resource-files are cle...

2017-04-21 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-ios/pull/309 CB-8980: Ensure copied resource-files are cleaned Requires https://github.com/apache/cordova-lib/pull/547 for the intended functionality, but is safe to merge even without it

[GitHub] cordova-lib pull request #547: CB-8978: Add option to get resource-file from...

2017-04-20 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/547 CB-8978: Add option to get resource-file from root Step 1 of resolving the first issue mentioned in https://github.com/apache/cordova-android/pull/321#issuecomment-294985346 Step 2 will be

[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-04-13 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/321 It is in cordova-android@6.2.1. No docs yet (wanted to get it supported in more platforms first), but it works exactly the same way that it does in plugin.xml. --- If your project is

[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView

2017-03-23 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/337 The Android System WebView (in Android 5.0+ anyhow) also fires `visibilitychange` when the app is focused/backgrounded, which might be an alternative (and is, arguably, the spec-compliant

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

2017-03-20 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/369 The `android_sdk_version` issue doesn't seem to cause any problems with building, and this PR does work for building with both the older and latest SDKs, so that's a :+1: from m

[GitHub] cordova-docs pull request #686: CB-12559: documentation updates for new Andr...

2017-03-16 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/686#discussion_r106557529 --- Diff: www/docs/en/dev/guide/platforms/android/index.md --- @@ -62,19 +63,20 @@ they dip below 5% on Google's ### Java Developmen

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

2017-03-15 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/369 ### Linux with Android SDK 25.2.2 ✅ npm test ✅ ./bin/check_reqs ✅ ./bin/android_sdk_version ✅ ./bin/create ✅ ./cordova/check_reqs ✅ ./cordova

[GitHub] cordova-android pull request #367: CB-12524: Working around Android SDK upda...

2017-03-09 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/367#discussion_r105253370 --- Diff: bin/lib/check_reqs.js --- @@ -78,21 +79,46 @@ module.exports.check_ant = function

[GitHub] cordova-docs pull request #685: CB-12519: added plugins release blog post

2017-03-06 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/685#discussion_r104516854 --- Diff: www/_posts/2017-03-06-plugins-release.md --- @@ -0,0 +1,199 @@ +--- +layout: post +author: +name: Steve Gill +url

[GitHub] cordova-docs pull request #685: CB-12519: added plugins release blog post

2017-03-06 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/685#discussion_r104514627 --- Diff: www/_posts/2017-03-06-plugins-release.md --- @@ -0,0 +1,199 @@ +--- +layout: post +author: +name: Steve Gill +url

[GitHub] cordova-docs pull request #685: CB-12519: added plugins release blog post

2017-03-06 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/685#discussion_r104515128 --- Diff: www/_posts/2017-03-06-plugins-release.md --- @@ -0,0 +1,199 @@ +--- +layout: post +author: +name: Steve Gill +url

[GitHub] cordova-docs pull request #685: CB-12519: added plugins release blog post

2017-03-06 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/685#discussion_r104514529 --- Diff: www/_posts/2017-03-06-plugins-release.md --- @@ -0,0 +1,199 @@ +--- +layout: post +author: +name: Steve Gill +url

[GitHub] cordova-docs pull request #685: CB-12519: added plugins release blog post

2017-03-06 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/685#discussion_r104515785 --- Diff: www/_posts/2017-03-06-plugins-release.md --- @@ -0,0 +1,199 @@ +--- +layout: post +author: +name: Steve Gill +url

[GitHub] cordova-docs pull request #685: CB-12519: added plugins release blog post

2017-03-06 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/685#discussion_r104514469 --- Diff: www/_posts/2017-03-06-plugins-release.md --- @@ -0,0 +1,199 @@ +--- +layout: post +author: +name: Steve Gill +url

[GitHub] cordova-docs pull request #685: CB-12519: added plugins release blog post

2017-03-06 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/685#discussion_r104515812 --- Diff: www/_posts/2017-03-06-plugins-release.md --- @@ -0,0 +1,199 @@ +--- +layout: post +author: +name: Steve Gill +url

[GitHub] cordova-docs pull request #685: CB-12519: added plugins release blog post

2017-03-06 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/685#discussion_r104514569 --- Diff: www/_posts/2017-03-06-plugins-release.md --- @@ -0,0 +1,199 @@ +--- +layout: post +author: +name: Steve Gill +url

[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-03-02 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/321 cordova-common@2.0.0 is released now, which was the prerequisite for this. Should we bump the cordova-common dependency in package.json and merge this in for the next Android release

[GitHub] cordova-android issue #310: [CB-10916] Support display name for Android

2017-03-01 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/310 Will do :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-ios issue #287: CB-12473 - Delete the correct build output folder

2017-02-19 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/287 Added JIRA ticket reference --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-26 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/499 That's using an old version of the cordova-android repo then, since that particular syntax issue was fixed [back in November](https://github.com/apache/cordova-android/c

[GitHub] cordova-docs issue #677: CB-12358: added tools release blog post

2017-01-23 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-docs/pull/677 For consistency, maybe remove the 3 instances where we have `:` appearing after ticket numbers? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2017-01-17 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/453 Windows has a `WindowsStoreDisplayName` preference, but I'm not clear if it's the same concept or not. In any case, the proper place for the platform changes should happen i

[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-01-17 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/321 Yeah, I'm going to try to get it set up locally with cordova-common master and ensure it's all working as intended --- If your project is set up for it, you can reply to this emai

[GitHub] cordova-ios pull request #287: Delete the correct build output folder

2017-01-11 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-ios/pull/287 Delete the correct build output folder JIRA is down, so no JIRA ticket 🙊 ### Platforms affected iOS (Simulator, mostly) ### What does this PR do? Ensures that when

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-11-29 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/468 For clarity, "top-level support" means allowing `resource-file` tags that aren't scoped to a particular platform. i.e., ```xml ```

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-11-28 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/468 Any other input here? Are we in agreement to remove the top-level file copying? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-android issue #344: CB-5968 (Android) - Missing the drawable-xxhdpi ...

2016-11-24 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/344 That is unrelated, and probably an issue with the phonegap-plugin-push. Cordova-Android doesn't do anything related to notifications, or notification-specific icons. --- If your pr

[GitHub] cordova-docs pull request #660: Announcement for Cordova Android 6.0 and Cor...

2016-11-07 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/660#discussion_r86852830 --- Diff: www/_posts/2016-11-07-android-release.md --- @@ -0,0 +1,35 @@ +--- +layout: post +author: +name: Joe Bowser +url

[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap

2016-11-07 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/340 That is a known issue with cordova-android@6.0.0, unrelated to this change. It has been fixed in master, and will be included in cordova-android@6.1.0 which is due to be released

[GitHub] cordova-android issue #344: Cb 5968

2016-10-28 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/344 I believe the xxhdpi icon should be 144×144, rather than 192×192. The xxhdpi splash screen is 960×1600. The xxxhdpi one is 1280×1920. --- If your project is set up for it, you

[GitHub] cordova-android pull request #343: CB-12077: Fix paths for Android icons/spl...

2016-10-28 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-android/pull/343 CB-12077: Fix paths for Android icons/splashscreens ### Platforms affected Android ### What does this PR do? Fix icons and splashscreens defined in config.xml copying into

[GitHub] cordova-docs issue #655: CB-12054 - Cordova iOS 4.3.0 release announcement

2016-10-24 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-docs/pull/655 Should we add a note that this requires Xcode >=7 now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request #653: CB-12038: Cordova Android 6.0.0 release anno...

2016-10-24 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/653#discussion_r84776114 --- Diff: www/_posts/2016-10-24-android-release.md --- @@ -0,0 +1,53 @@ +--- +layout: post +author: +name: Joe Bowser +url

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-18 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/269 hmm, I think in our case we were trying to use canOpenURL to see if a partner app was able to launch and redirect to the store otherwise. This also came up in the Slack channel recently, and

[GitHub] cordova-ios pull request #269: CB-12002 - Support LSApplicationQueriesScheme...

2016-10-12 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-ios/pull/269 CB-12002 - Support LSApplicationQueriesSchemes ⚠️ Depends on https://github.com/apache/cordova-lib/pull/502 ### Platforms affected iOS ### What does this PR do

[GitHub] cordova-lib pull request #502: CB-12002 - Add getAllowIntents() to ConfigPar...

2016-10-12 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/502 CB-12002 - Add getAllowIntents() to ConfigParser ### Platforms affected None, but I'm adding this as preparation for an iOS feature. ### What does this PR do? Adds a conven

[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap

2016-10-06 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/340 If they were specifying icons via config.xml, this should just work. If they had the platform already installed and had modified files, this shouldn't affect those existing

[GitHub] cordova-android pull request #340: CB-8722 - Move app icons from drawable to...

2016-10-06 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-android/pull/340 CB-8722 - Move app icons from drawable to mipmap https://issues.apache.org/jira/browse/CB-8722 Reasoning behind the change: https://androidbycode.wordpress.com/2015/02/14/goodbye

[GitHub] cordova-ios pull request #262: CB-11957 - Update docs for remote/local notif...

2016-10-05 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/262#discussion_r82043239 --- Diff: CordovaLib/Classes/Public/CDVPlugin.h --- @@ -44,6 +41,17 @@ extern NSString* const CDVViewWillLayoutSubviewsNotification; extern NSString

[GitHub] cordova-ios pull request #261: Print a warning if system ruby is not in use

2016-10-05 Thread dpogue
Github user dpogue closed the pull request at: https://github.com/apache/cordova-ios/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request #261: Print a warning if system ruby is not in use

2016-10-05 Thread dpogue
GitHub user dpogue reopened a pull request: https://github.com/apache/cordova-ios/pull/261 Print a warning if system ruby is not in use This should give people some indication as to why xcodebuild export sometimes fails with errors that make no sense. /cc @shazron You

[GitHub] cordova-ios pull request #261: Print a warning if system ruby is not in use

2016-10-05 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-ios/pull/261 Print a warning if system ruby is not in use This should give people some indication as to why xcodebuild export sometimes fails with errors that make no sense. /cc @shazron You can

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-10-04 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 @shazron Fixed an issue with the `rm` that was causing ENOENT on initial builds. Tests should pass now. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2016-10-03 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/453 I think we should support this in the simplest way possible with a consistent API, as opposed to requiring people to add several unintuitive blocks of `edit-config` to modify various platform

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Updated, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-ios pull request #257: CB-11860 - Update packaging strategy for Xcod...

2016-09-30 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/257#discussion_r81437882 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -88,25 +89,61 @@ module.exports.run = function (buildOpts) { events.emit(

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 The www files aren't anywhere in the .ipa? I've been making .ipa builds with an enterprise cert for a few weeks now and uploading them for our QA team, and nobody has reported an

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Thanks @shazron! I've pushed that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Yeah, I was hoping to find a convenient way to override Ruby gem paths with environment variables or something, but for now it's probably worth just printing a warning for now.

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 The only reasons to go through the archive step is to ensure that the build is signed with the right certificates. Building and deploying the .app directly would be signed with a development

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-28 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Running on a device, or running on the simulator? In theory, running is supposed to be a separate step from packaging, but I'll try this out today and see what I find. --- If your proje

[GitHub] cordova-docs issue #642: CB-10929 added OXS filter button to plugin search a...

2016-09-26 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-docs/pull/642 With 10.12, Apple rebranded their desktop OS to `macOS`. Maybe we want to say `OSX / macOS`? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-ios issue #259: CB-11792 - Fixed configuration file could not be par...

2016-09-20 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/259 Tested this and I'm not getting any errors from the xcconfig :+1: Thanks Shaz! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-ios issue #256: CB-11854 - Create Entitlements.plist file (one each ...

2016-09-16 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/256 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-ios issue #248: CB-11792 - Add Cocoapods .xcconfig includes to build...

2016-09-15 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/248 This is causing Xcodebuild to ignore the Cordova build.xcconfig files: ``` Ignoring configuration file '/Users/ayogo/Jenkins/workspace/cordova-app/platforms/ios/cordova/

[GitHub] cordova-ios pull request #257: CB-11860 - Update packaging strategy for Xcod...

2016-09-15 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-ios/pull/257 CB-11860 - Update packaging strategy for Xcode 8 Background info on the mailing list: https://lists.apache.org/thread.html/85a715681471c774821d76a90ec288943eca1a4bb0a267ba299d2eb3

[GitHub] cordova-ios pull request #254: Expose CDVCommandStatus enum to Swift

2016-09-10 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-ios/pull/254 Expose CDVCommandStatus enum to Swift This allows Swift plugins to write code like ```swift CDVPluginResult(status: .ERROR) ``` rather than ```swift CDVPluginResult

[GitHub] cordova-android issue #330: Bridge Fixes for Android Jellybean

2016-09-09 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/330 Is there a good way to check if we're using the system webview when making this change? I suspect Crosswalk could use the evaluateJavascript bridge even on Jellybean? --- If your pr

[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2016-09-01 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/321 Thanks! I've corrected that function name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios issue #245: CB-11731 Re-read ios.json on every prepare

2016-08-30 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/245 :+1: This is definitely the root cause of CB-11589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request #487: CB-11777: Restore plugins before preparing

2016-08-26 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/487 CB-11777: Restore plugins before preparing When running `cordova prepare` to restore platforms and plugins, the platform has prepare called before the plugins are restored. This leads to the

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

2016-08-23 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 Rebased, but still blocked on the cordova-lib PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request #630: Added android ios release blog post

2016-08-22 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/630#discussion_r75787707 --- Diff: www/_posts/2016-08-22-android-ios-release.md --- @@ -0,0 +1,48 @@ +--- +layout: post +author: +name: Steve Gill

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-08-22 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/468 I'm happy to leave out support for top-level `resource-file` tags, since I agree it doesn't really make sense --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-docs pull request #627: Add docs for defaultlocale to config.xml

2016-08-17 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-docs/pull/627 Add docs for defaultlocale to config.xml This allows customizing the default language of the application on iOS. Ref CB-9789 See also https://github.com/apache/cordova-ios/pull/237

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-08-17 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/237 @shazron Thanks, I've rebased on master and updated the tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib issue #479: CB-11698 Fix plugin installation when restoring plat...

2016-08-12 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/479 Honestly, this is just further convincing me that `restore` and `prepare` should be two separate commands. It seems weird to me to run prepare for a platform that isn't installed and expe

[GitHub] cordova-android pull request #321: CB-8978 Prepare copy resource-files from ...

2016-07-28 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-android/pull/321 CB-8978 Prepare copy resource-files from config.xml See also cordova/cordova-discuss#6 Depends on https://github.com/apache/cordova-lib/pull/468 This copies files specified by

[GitHub] cordova-lib pull request #469: CB-8320: We look for a build.gradle to make s...

2016-07-28 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/469#discussion_r72685014 --- Diff: cordova-lib/src/cordova/metadata/android_parser.js --- @@ -31,14 +31,20 @@ var fs= require('fs'),

[GitHub] cordova-lib pull request #468: CB-8978 Add resource-file parsing to config.x...

2016-07-27 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/468 CB-8978 Add resource-file parsing to config.xml Original JIRA issue https://issues.apache.org/jira/browse/CB-8978 Related to/replaces https://github.com/apache/cordova-lib/pull/214 See

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-07-25 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/237 The `getAttribute` method is implemented in https://github.com/apache/cordova-lib/pull/466 (which isn't merged yet) --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-ios pull request #237: CB-9789: Support setting the default app loca...

2016-07-21 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-ios/pull/237 CB-9789: Support setting the default app locale This allows adding a `defaultlocale="XX"` attribute to the `widget` tag in config.xml to set the CFBundleDevelopmentRegion to a

[GitHub] cordova-lib pull request #466: Add general purpose ConfigParser.getAttribute...

2016-07-21 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/466 Add general purpose ConfigParser.getAttribute API This allows platform to have their specific override attributes without needing to update this file and worry about syncing platform versions

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-07-18 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/236 Probably not while there are [so many known issues](https://issues.apache.org/jira/browse/CB-11469?jql=project%20%3D%20CB%20AND%20labels%20%3D%20wkwebview-known-issues) with WKWebView --- If

  1   2   >