Github user csantanapr commented on the issue:
https://github.com/apache/cordova-android/pull/365
I'm confuse what jar you are referring?
I don't see the jar on the change set files
Adding a gradlew it's perfectly fine, this is useful as it takes care of
t
Github user csantanapr commented on the issue:
https://github.com/apache/cordova-lib/pull/465
LGTM
Maybe print some message about next steps "you need to manually moved any
platform configuration from backup version a.b.c to x.y.z as you see it fit for
your project"
-
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-218834713
Sounds good to me to proceed then, it was a random idea
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-218715695
I have one question, maybe I missed it in discussion why is this
implemented in CLI and not LIB
I think it make more sense to implement in the top level
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-217944908
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-203621399
@rakatyal Thanks for prompt review and working with @dubeejw :+1:
---
If your project is set up for it, you can reply to this email and have your
reply
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-202988290
ping @rakatyal can you review this PR and merge if its good
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-lib/pull/417
CB-10965 xml helper allows multiple instances to be merge in config.xml
@vladimir-kotikov I this is the real fix on duplicate names ending up in
final config.xml triggering the unwanted
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201937380
@vladimir-kotikov yes lets fix this in cordova-lib to get a fix in CLI
6.1.1, but I agree with you that problem should also be fix in iOS
The root of
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201893339
@riknoll @vladimir-kotikov I found a way to skip prepare hooks on first
prepare call. made the change I rebase, please review again
---
If your project is set
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201881251
@riknoll I don't think is big deal if prepare hooks twice, I will look to
see if there is a way to call first prepare without hooks
---
If your project i
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-lib/pull/416
CB-10961 Error when adding ios platform and plugin declare in config.xml
@vladimir-kotikov can you review
This other commit
https://github.com/apache/cordova-lib/commit
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-199892126
@dubeejw can you review your changes again , CI is failing appveyor and
travois-ci
---
If your project is set up for it, you can reply to this email and
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/412#issuecomment-197559090
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/411#issuecomment-197558977
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-197128552
@stevengill the npm install portion is reverted now, I will take a look at
your PR for npm fetch on how is handling the template fetching and npm install
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-197123180
@stevengill oops good catch, that npm install portion was not suppose to be
there, I was just experimenting, only the top portion for the sub dir.
I
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/550#issuecomment-196870853
@nikhilkh yep, this can be close now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user csantanapr closed the pull request at:
https://github.com/apache/cordova-docs/pull/550
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-196831845
@vladimir-kotikov thanks for the review I will check on those
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/551#issuecomment-196618485
@dblotsky I vote for using links #555
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/551#issuecomment-196488029
@dblotsky LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-196399690
@stevengill @vladimir-kotikov could you review this when you have chance.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-lib/pull/410
CB-10808 **CLI** Should handle templates with files located in sub directory
Refer to [CB-1080](https://issues.apache.org/jira/browse/CB-10808) for more
info
You can merge this pull
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/551#issuecomment-195847261
They don't have to be on the row on mobile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/551#issuecomment-195847241
@dblotsky no way we can make it work on mobile float, flex, css, etc.. ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/551#issuecomment-195385864
@dblotsky Love the option to help with translations to get them to the
right spot in Crowding.
Still I think the label for the button should be changed
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/550#discussion_r55691390
--- Diff: www/_posts/2016-03-12-plugin-release.md ---
@@ -0,0 +1,74 @@
+---
+layout: post
+author:
+name: Carlos Santana
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/550#issuecomment-194888965
@dpogue weird I didn't catch this I was using VSCode preview and they
looked fine, it could a difference in markdown with Github, I fixed, thanks for
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/550#discussion_r55690550
--- Diff: www/_posts/2016-03-12-plugin-release.md ---
@@ -0,0 +1,74 @@
+---
+layout: post
+author:
+name: Carlos Santana
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-docs/pull/550
Plugin release 03 12
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/csantanapr/cordova-docs plugin_release_03_12
Alternatively you
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194599948
@riknoll what's the final conclusion for the plugin release?
---
If your project is set up for it, you can reply to this email and have your
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194567940
@riknoll I'm not too familiar with android permission would be up to
@infil00p @jcesarmobile or maybe @macdonst
---
If your project is set u
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/539#issuecomment-194374056
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/47#issuecomment-192465550
@dubeejw I meant not the file itself but the path, I think you know what I
meant :laughing:
---
If your project is set up for it, you can
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/47#issuecomment-192465283
Hi @dubeejw it would be good to go over all the cordova plugins plugin.xml
and check which one have this bug of not using lower case for source
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-android/pull/270#issuecomment-192333002
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/529#issuecomment-191343818
Let's use "CLI" in "Cordova CLI 6.0.0"
With so many Cordova components is good to be explicit
---
If your project is set up
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-186021548
Thanks @jcesarmobile for commenting we wanted someone to review it before
we took it out.
@eymorale looks like it's OK to go ahea
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/193#issuecomment-186017788
Thanks @mhartington for testing you were able to recreate very easy in your
setup.
---
If your project is set up for it, you can reply to this email and have
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-185330171
I agree we should remove the file all together is not required for
functionality that the plugin offers.
@infil00p Are you OK with the
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/9#issuecomment-184509346
Can you open a JIRA for this change, and the reasoning behind?
What is content:// for?
Why do you think this have to be added by
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/493#issuecomment-184499148
Sorry I'm late to this one, It looks like @stevengill already review.
Just some dumb questions
1. What impact this has to translation process?
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-android/pull/257#issuecomment-180557444
@riknoll sure no problem, I was just curious if there was more you wanted
me to look at.
---
If your project is set up for it, you can reply to this email
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-android/pull/257#issuecomment-180554647
@riknoll you are going to merge this or there is more work to be done?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-android/pull/257#issuecomment-180171364
@riknoll I tested the pull request and it's working for me.
lastResume keeps the data, any new listener that get's attached get's the
d
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/486#issuecomment-179833612
Change the date on the file and to 2016-02-04
Other than that looks good
---
If your project is set up for it, you can reply to this email and have your
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-lib/pull/373
CB-10499 - --template should pull the latest template from NPM when
version isn't specified
- Pull the latest template if no version is specified
- Rename NPM t
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-windows/pull/147#issuecomment-178054738
For what version is this for? cordova-windows@5.0.0 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-android/pull/255
CB-10472 NullPointerException: org.apache.cordova.PluginManager.onSavâ¦
â¦eInstanceState
check if pluginManager is null before using it
You can merge this pull request into a
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/183#issuecomment-163343873
closing this one since #182 fixed it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/182#issuecomment-163343647
@eymorale LGTM go ahead and merge it, I will close mine #183
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user csantanapr closed the pull request at:
https://github.com/apache/cordova-ios/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-ios/pull/183
CB-9311 CB-10162 fixes app icon 87x87 and copy errors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/csantanapr/cordova-ios CB-9311
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/182#discussion_r47048171
--- Diff: bin/templates/scripts/cordova/lib/prepare.js ---
@@ -257,10 +257,11 @@ function handleBuildSettings(platformConfig,
locations
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/182#discussion_r47048069
--- Diff: bin/templates/scripts/cordova/lib/prepare.js ---
@@ -47,8 +47,8 @@ module.exports.prepare = function (cordovaProject) {
return
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/436#issuecomment-162974919
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/436#issuecomment-162934923
ok, I went over the wholes changes, that's it I didn't find anything else
---
If your project is set up for it, you can reply to this email and have
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/436#issuecomment-162934402
What about AppDelegate changes/moving?
What about minimum Deployment Target to iOS 8.0? What does this means for
humans :-), no ios 7?
---
If your
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/436#issuecomment-162933618
@shazron ah ok, maybe I was thinking
oh what about whitelist stuff?
Any other high level feature?
---
If your project is set up for it, you
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/436#issuecomment-162930851
What about mentioning other some high level features:
1. Support Asset Catalog
2. ios-sim (will use internal version, no need to npm i -g ios-sim
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-cli/pull/228#issuecomment-161818866
@unimonkiez Open a JIRA issue if node 5 having issues in your use cases,
latest cli works with node 4 and 5
---
If your project is set up for it, you can reply
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/418#discussion_r44826426
--- Diff: www/contribute/contribute_guidelines.md ---
@@ -0,0 +1,77 @@
+---
+layout: contribute-help
+title: Apache Cordova Contribute
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/38#issuecomment-154596695
LGTM, rebase the two commits into a single one.
Basically you added an observer that anytime that you get notify about
status bar change, you do
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/178#issuecomment-154265526
@shazron is this a lesson learned that certain experimental things should
be kept in experimental branches and not in master :+1:
---
If your project is set
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/178#issuecomment-153887028
With this removal, is there a minimum ios version that this will work only
using the IFRAME_NAV bridge?
---
If your project is set up for it, you can reply to
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/334#issuecomment-152646051
I think is a nice feature to open the browser to a good spot on the wen to
search for plugins applicable for cli use cases where people are running by
hand
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-coho/pull/97#issuecomment-152054152
+1 LGTM
Yes Agree, I think folks see a name associated with a bug, and they think
that person already looked at it when it reality it's what @purpleca
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-151138324
I'm not android SME, maybe @macdonst can take a look.
My general comment on this PR, is that if you don't know what are not sure
Github user csantanapr closed the pull request at:
https://github.com/apache/cordova-docs/pull/379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-docs/pull/379
Add ReactEurope App to Showcase
ok this time link points to correct location where both apps ios and
android are located
You can merge this pull request into a Git repository by running
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/375#issuecomment-146873280
This pull request is a mess, I close and try to do a new one
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user csantanapr closed the pull request at:
https://github.com/apache/cordova-docs/pull/375
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/375#issuecomment-146871381
@dblotsky found the correct website that list both platforms ios and android
---
If your project is set up for it, you can reply to this email and have your
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-docs/pull/375#issuecomment-146684495
Sorry about that @fredgalvao I changed the link to point to app in itunes
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-docs/pull/375
Add ReactEurope App to Showcase
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/csantanapr/cordova-docs cordova-website
Alternatively
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41204416
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/170#issuecomment-145299566
I did some investigation today, I found the reason why putting
CLANG_ENABLE_MODULES = NO
in build.xcconfig doesn't get reflected, is be
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41082335
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41020487
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-141170683
:+1: @vladimir-kotikov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-140061087
@vladimir-kotikov yes change to node-code looks good send the PR to see
what they want to do, we don't have to wait for a new node-xcode since we
swi
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-140060717
We need to merge and release fast cli and lib with this bug, nodejs@4 is
out and this is a major bug
---
If your project is set up for it, you can reply to
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-140060516
@vladimir-kotikov yes, This PR is good to merge to cordova-lib, that's what
I meant with "I agree with the change then..." :-)
:+1:
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139655827
Thanks for explanation @vladimir-kotikov and thanks for your input @pmuellr
I agree with the change then after explanation.
I still think it should
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139555231
If it's something wrong with npm package xcode, we should open an issue and
maybe help with a PR
---
If your project is set up for it, you can reply to
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139548204
Hi @vladimir-kotikov can you give explanation why the fix is to run Sync?
In general I'm not fan on Sync in nodejs, but would like to understand
w
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/41#discussion_r39164957
--- Diff: README.md ---
@@ -38,6 +38,8 @@ Although in the global scope, it is not available until
after the `deviceready
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128835312
@jengee you don't have to get tired of update the template every time, you
can implement a user land cordova hook after_prepare [1] [2]
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128833712
-1
hum this looks very ugly in the template. I don't like to have this in the
default template. people might think that is a security
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/150#issuecomment-128156902
I just finish testing this and it also works for me
cordova platform add ios
cordova build
cordova platform update ../cordova-ios-CB9453
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/137#issuecomment-93073139
:beer:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-ios/pull/137
CB-8855 Fix display ios devices with --list
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/csantanapr/cordova-ios CB-8855
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/55#issuecomment-57020278
@sgrebnov I tested the pull request and it looks good :+1: . Go ahead and
merge it into master. this is great extensibility feature :beers: :tophat:
---
If your
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/55#issuecomment-56910355
I will review the pull request and if it looks you want me to merge it or
you want to do it @sgrebnov ?
---
If your project is set up for it, you can reply to
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-wp8/pull/56
fixes for node_modules missing files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/csantanapr/cordova-wp8 master
Alternatively you
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-wp8/pull/55
3.6.x fixing problems with node_modules and bins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/csantanapr/cordova-wp8 3.6.x
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/83#issuecomment-54324098
Please associate this pull request with a JIRA item.
Process can be found here:
http://wiki.apache.org/cordova/ContributorWorkflow
I think before this code
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/55#issuecomment-52305148
@purplecabbage That was one of my points, that context.cmdLine is not
useful as a String.
Why slide() and not just context.cmdLine = process.argv ? just to get
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/55#issuecomment-52238594
@sgrebnov here some feedback about context.cmdLine
Any strong reason why this has to be a string instead of an Array like
process.argv ?
https
1 - 100 of 108 matches
Mail list logo
