Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Nightly build #408 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g
cordova@nightly'
For details check build console at
https://builds.apache.org/job/cordova-nightly/408/consoleFull
-
Jenkins for Apache Cordova
-
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/322
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=h1)
Report
> Merging
[#322](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=desc) into
[master](https:
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/322
CB-12948 - Add a warning to updateProject for iOS
### Platforms affected
self
### What does this PR do?
Remove the `cordova platform update` functionality of this plat
In the interim, I filed: https://issues.apache.org/jira/browse/CB-12948 and
will send a PR for comment
On Fri, Dec 2, 2016 at 4:56 PM, Shazron wrote:
> This has not been resolved yet. We'll discuss more next week.
>
> Archive link to this thread just in case you don't have it:
> https://lists.ap
Github user kylemellander commented on the issue:
https://github.com/apache/cordova-plugin-network-information/pull/54
Just as a note and I don't seem to have permissions to post to jira, it
seems that this error is happening on android as well
---
If your project is set up for it, y
Github user jab commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/128
Thanks for merging and for Cordova!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123851340
--- Diff: bin/lib/create.js ---
@@ -259,41 +273,53 @@ exports.create = function(project_path, config,
options, events) {
setShell
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123850564
--- Diff: bin/templates/cordova/Api.js ---
@@ -343,6 +349,8 @@ Api.prototype.removePlugin = function (plugin,
uninstallOptions) {
*/
Api.
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123850098
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -148,6 +152,7 @@ module.exports.runClean = function(options) {
*/
module.exports.run =
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123849628
--- Diff: bin/templates/cordova/lib/builders/GenericBuilder.js ---
@@ -53,43 +48,13 @@ GenericBuilder.prototype.findOutputApks =
function(build_type
Github user imhotep commented on the issue:
https://github.com/apache/cordova-lib/pull/568
I support this change. I believe it will make writing tests for new
features easier if each source file has a matching spec file and all
source/spec folders are mirrored.
---
If your project i
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123844605
--- Diff: bin/lib/create.js ---
@@ -125,16 +131,24 @@ function writeProjectProperties(projectPath,
target_api) {
fs.writeFileSync(dstPath,
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123835148
--- Diff: bin/templates/cordova/Api.js ---
@@ -81,10 +83,13 @@ function Api(platform, platformRootDir, events) {
// XXX Override some locatio
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-browser/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/34
CB-11710 Add missing 'clean.bat' file
### Platforms affected
browser ( when run on windows )
### What does this PR do?
adds missing clean.bat file
### Wha
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123834608
--- Diff: bin/lib/create.js ---
@@ -314,7 +340,18 @@ exports.update = function(projectPath, options,
events) {
return Q()
.then(fun
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123834356
--- Diff: bin/lib/create.js ---
@@ -125,16 +131,24 @@ function writeProjectProperties(projectPath,
target_api) {
fs.writeFileSync(dstPath, d
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/128
Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/386
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/386
I believe in you, you can do it!
---
If your project is set up for
Github user audreyso commented on the issue:
https://github.com/apache/cordova-android/pull/386
I think I have permission, but haven't ever done it before! @filmaj
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/386
Do you not have permissions to merge, or do you have your hands full with
other work? Happy to merge this in for you but if it's a permission issue
please let me know so that I can fix that :
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/561
Your experience going through the integration tests in here is valuable
with respect to understanding what code these tests exercise, so armed with
that knowledge, I think you have the right cont
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/561
@filmaj I rebased this for now. If we change the tests to unit tests,
should it be in this PR or in a separate one?
---
If your project is set up for it, you can reply to this email and have y
Github user audreyso commented on the issue:
https://github.com/apache/cordova-android/pull/386
I rebased this morning! @filmaj @infil00p If anyone has time to merge it
in, that would be great :)
---
If your project is set up for it, you can reply to this email and have your
reply a
GitHub user jab opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/128
Fix CB-12947 (incorrect documentation of iPhone 5 and 5s resolution)
iPhone 5, 5s, and SE have resolution 640x1136, not 640x960 as currently
documented.
### Checklist
-
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/385
Does anything need to change in the plugin authoring documentation for
Android as a result of this?
https://cordova.apache.org/docs/en/latest/guide/platforms/android/plugin.html
Nice! It's also awesome to have the CI code end up in the yml files
inside the repositories, rather than jenkins job configs on cloudapps.
On Fri, Jun 23, 2017 at 1:38 AM, wrote:
> So I've finally managed to get it working, here's an example of PR for
> battery-status plugin:
> https://github.c
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/54
CB-12935: (ios, android) Enable paramedic builds on Travis CI
### Platforms affected
iOS, Android
### What does this PR do?
https://issues.apache.org/jira/brow
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/64
CB-12935: (ios, android) Enable paramedic builds on Travis CI
### Platforms affected
iOS, Android
### What does this PR do?
https://issues.apache.org/jira/browse/CB-1
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/153
CB-12935: (ios, android) Enable paramedic builds on Travis CI
### Platforms affected
Android, iOS
### What does this PR do?
https://issues.apache.org/jira/browse/C
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-console/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-console/pull/23
CB-12935: (ios, android) Run paramedic builds on Travis
### Platforms affected
Android, iOS
### What does this PR do?
https://issues.apache.org/jira/browse/CB-12935
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-battery-status/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/56
CB-12935: (CI) Travis should use Node 4.2 instead of 0.10
### Platforms affected
Android
### What does this PR do?
Makes Travis install Node 4.2 instead of de
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/272
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/55
Oh, and we need to encode sauce access key for each repository separately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/55
Mostly, yes, with some modifications (for example, Camera tests require
Android support repository and have other tests to run, which are needed to be
brought out to a separat
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/55
Awesome!
Is the next step to just copy this to the other plugin repos?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
43 matches
Mail list logo
