Nightly build #305 for cordova has failed

2017-04-06 Thread Apache Jenkins Server
Nightly build #305 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/305/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/305/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib issue #539: CB-12643 : removed references to wp8

2017-04-06 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/539 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=h1) Report > Merging [#539](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=desc) into [master](https:

[GitHub] cordova-lib pull request #539: CB-12643 : removed references to wp8

2017-04-06 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/539 CB-12643 : removed references to wp8 ### Platforms affected ### What does this PR do? Removed references to wp8. ### What testing has been done on this

[GitHub] cordova-android issue #373: Support for SDK Tools v26, simplified target par...

2017-04-06 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/373 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr&el=h1) Report > Merging [#373](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr&el=desc) into [

[GitHub] cordova-ios issue #301: CB-12617 : added engine strict for users with older ...

2017-04-06 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-ios/pull/301 Thank you @shazron . Updated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-ios issue #301: CB-12617 : added engine strict for users with older ...

2017-04-06 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/301 `enginestrict` is useless without the corresponding `engines` key. We should add this to the PR as well: ``` "engines" : { "node" : ">=4" } ``` --- If your project

[GitHub] cordova-android issue #373: Support for SDK Tools v26, simplified target par...

2017-04-06 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-android/pull/373 I did local testing on the sdk tools 26.0.1 and 25.2.3 (pre-tool-removal-mess), both built fine using CLI project creation+ build, and standalone project creation+build. --- If your proje

[GitHub] cordova-android pull request #373: Support for SDK Tools v26, simplified tar...

2017-04-06 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-android/pull/373 Support for SDK Tools v26, simplified target parsing and preference for using newer `sdkmanager` and `avdmanager` commands Please review and test @infil00p, @dpogue, @shazron. ### P

[GitHub] cordova-plugin-inappbrowser issue #195: Cb 6229 - (Android) Hide Location bu...

2017-04-06 Thread barryvdh
Github user barryvdh commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/195 Woud this make the default behavior the same as iOS, to show the close button with just 'location=no'? (default ='location=yes') -> show location + close button 'loc

[GitHub] cordova-plugin-file-transfer issue #164: Removed warning

2017-04-06 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/164 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-plugin-file-transfer issue #165: CB-12107: (android) Trigger media s...

2017-04-06 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/165 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-plugin-file-transfer pull request #175: CB-10696 iOS: Encode target ...

2017-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer issue #175: CB-10696 iOS: Encode target path wi...

2017-04-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/175 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/175/commits/e9d93c0a542e1b952fb742a94

[GitHub] cordova-plugin-file-transfer issue #175: CB-10696 iOS: Encode target path wi...

2017-04-06 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/175 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-plugin-file-transfer issue #175: CB-10696 iOS: Encode target path wi...

2017-04-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/175 Cordova CI Build has one or more failures. Please note that a lot of tests are currently disabled on CI. To make sure everything works, please run tests locally via

[GitHub] cordova-plugin-file-transfer pull request #175: CB-10696 iOS: Encode target ...

2017-04-06 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/175#discussion_r110163497 --- Diff: src/ios/CDVFileTransfer.m --- @@ -440,13 +440,23 @@ - (void)download:(CDVInvokedUrlCommand*)command targ

[GitHub] cordova-plugin-geolocation issue #85: Android: handle location service is of...

2017-04-06 Thread RickeyWard
Github user RickeyWard commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/85 This branch needs merged, it fixes inconsistencies between android and ios and after hours of trying to get android to work with no avail I installed this fork and it worked imm