[GitHub] cordova-windows issue #223: Remove duplicate logic after upgrading cordova-c...

2017-01-26 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/223 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cordova-plugin-media issue #124: CB-12319: (Android&iOS) Fix bug that record...

2017-01-26 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/124 This would be a nice one to get merged in for improving cross platform compatibility, need this for one of my apps to work smoothly when syncing audio recordings between multiple devic

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2017-01-26 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron I just checked Jira and CB-11817 is the correct Jira issue for this issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2017-01-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 Which JIRA issue is this really under? it's not the right one in the title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-media pull request #116: CB-11817: (iOS) Fix unused recording...

2017-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

Re: CI Report

2017-01-26 Thread Shazron
One more failure: - cordova-plugin-filetransfer - iOS 10 - filetransfer.spec.27 On Thu, Jan 26, 2017 at 11:28 AM, Shazron wrote: > status.cordova.io > > 3 failures: > - cordova-plugin-device - Android 4.4 (undefined object) > - cordova-plugin-dialogs - Android 5.1 (undefined object) > - cordova-

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/499 ``` 1) (save flag) prepare Test 032 : spec.24 should restore only specified platform Message: expected C:\projects\cordova-lib\cordova-lib\spec-cordova\temp\testApp\platforms\w

[GitHub] cordova-plugin-camera issue #251: CB-12368: Fix permission check on Android

2017-01-26 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/251 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/251/commits/b23dac5afdbc3a40d387ce077af546ad33e0b84

[GitHub] cordova-plugin-camera issue #251: CB-12368: Fix permission check on Android

2017-01-26 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/251 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/251/commits/bfa48b9f13009d1b944e1f239a3468a386b263a2

[GitHub] cordova-plugin-camera pull request #251: CB-12368: Fix wrong permission requ...

2017-01-26 Thread sryze
GitHub user sryze opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/251 CB-12368: Fix wrong permission request on Android ### Platforms affected Android ### What does this PR do? The plugin was requesting permission for camera instead of ext

CI Report

2017-01-26 Thread Shazron
status.cordova.io 3 failures: - cordova-plugin-device - Android 4.4 (undefined object) - cordova-plugin-dialogs - Android 5.1 (undefined object) - cordova-paramedic - TravisCI - (undefined object) 1 known failure: - cordova-paramedic - AppVeyor - (needs to run on non-admin privileged account) No

[GitHub] cordova-docs pull request #679: CB-12163 Add doc for reference attr for reso...

2017-01-26 Thread ktop
GitHub user ktop opened a pull request: https://github.com/apache/cordova-docs/pull/679 CB-12163 Add doc for reference attr for resource-file in Windows ### Platforms affected - Windows - plugin.xml doc ### What does this PR do? Adds documentation for t

Re: CB-11602: (android) Adds onRestart event support

2017-01-26 Thread Kerri Shotts
Indeed; it felt distinctly strange documenting launch storyboards in the plugin when 99% of the logic went into the platform instead. IIRC, the code changes in the plugin only amounted to a few lines. ~ Kerri > On Jan 25, 2017, at 16:47, julio cesar sanchez wrote: > > +1, iOS needs the launch

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-26 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/499 Thank you @shazron @dpogue Going to take a look at this today. I'll keep you posted! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cordova-plugin-inappbrowser issue #207: CB-12364 [Windows] Inappbrowser inje...

2017-01-26 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/207 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/207/commits/d842693889057f5d3fe209f6f7a

[GitHub] cordova-plugin-inappbrowser pull request #207: CB-12364 [Windows] Inappbrows...

2017-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/207 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...

2017-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-26 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/499 That's using an old version of the cordova-android repo then, since that particular syntax issue was fixed [back in November](https://github.com/apache/cordova-android/commit/36646eb527826dad8124

[GitHub] cordova-lib issue #499: Cb 11960

2017-01-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/499 ``` C:\Users\appveyor\.cordova\lib\npm_cache\cordova-android\6.0.0\package\bin\templates\cordova\lib\AndroidStudio.js:16 for(file of eclipseFiles) { ^^ ``` `f

[GitHub] cordova-windows issue #223: Remove duplicate logic after upgrading cordova-c...

2017-01-26 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/223 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/223?src=pr) is 76.85% (diff: 100%) > Merging [#223](https://codecov.io/gh/apache/cordova-windows/pull/223?src=

[GitHub] cordova-windows pull request #223: Remove duplicate logic after upgrading co...

2017-01-26 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-windows/pull/223 Remove duplicate logic after upgrading cordova-common You can merge this pull request into a Git repository by running: $ git pull https://github.com/matrosov-nikita/cordova-w