Github user shazron closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/22
Fixed in #28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25
I've fixed the CI problem and would like this PR to be green before I pull
it in. Can you rebase? It should re-test the PR automatically after.
---
If your project is set up
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/27
I've fixed the CI problem and would like this PR to be green before I pull
it in. Can you rebase? It should re-test the PR automatically after.
---
If your project is set up
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/174
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/174/commits/ab268e0605c55c47b3931029b
GitHub user Lemon-King opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/174
CB-12399: (Android) Fix bug with WebView & CookieManager cookies
### Platforms affected
Android
### What does this PR do?
Resolves the issue where only WebVi
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/10
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/10/commits/71075a1f32651befd0
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/10
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/10/commits/083578eaa87c696f55
+1, iOS needs the launch images even if you don't install the plugin and
the launch storyboard has some of the logic in cordova-ios
2017-01-25 22:31 GMT+01:00 Filip Maj :
> +1 !
>
> On Wed, Jan 25, 2017 at 11:35 AM, Kerri Shotts
> wrote:
> > +1 to moving splash screen into platforms.
> >
> >
> >
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/499
ya
On Wed, Jan 25, 2017 at 2:35 PM, Audrey wrote:
> *@audreyso* commented on this pull request.
> --
>
> In cordova-lib/spec-cordova/f
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97895425
--- Diff: cordova-lib/spec-cordova/fixtures/basePkgJson4/package.json ---
@@ -5,7 +5,7 @@
"main": "index.js",
"dependencies": {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894467
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -680,10 +681,10 @@ describe('update config.xml to include platforms in
pkg.json', fu
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894300
--- Diff: cordova-lib/spec-cordova/fixtures/basePkgJson4/package.json ---
@@ -5,7 +5,7 @@
"main": "index.js",
"dependencies": {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894545
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -697,18 +698,18 @@ describe('update config.xml to include platforms in
pkg.json', fu
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894565
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -697,18 +698,18 @@ describe('update config.xml to include platforms in
pkg.json', fu
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894506
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -697,18 +698,18 @@ describe('update config.xml to include platforms in
pkg.json', fu
+1 !
On Wed, Jan 25, 2017 at 11:35 AM, Kerri Shotts wrote:
> +1 to moving splash screen into platforms.
>
>
> ~ Kerri
>
>> On Jan 25, 2017, at 01:09, Simon MacDonald wrote:
>>
>> I would be happy to see Splash Screen go back to the platforms as well.
>>
>> Simon Mac Donald
>> http://simonmacdona
Github user ryanagler commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/122
My app also crashes from this issue. Applying the changes from
frankkoenigstein fixes it. Please merge to main!
---
If your project is set up for it, you can reply to this email an
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/10
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/10/commits/68693cf017440e5931
+1 to moving splash screen into platforms.
~ Kerri
> On Jan 25, 2017, at 01:09, Simon MacDonald wrote:
>
> I would be happy to see Splash Screen go back to the platforms as well.
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Tue, Jan 24, 2017 at 10:56 PM, Joe Bowser wrote:
>
>> O
GitHub user maverickmishra opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/10
Update screen orientation plugin to w3 spec
### Platforms affected
iOS, Android,Windows
### What does this PR do?
This PR makes the plugin
Github user stevengill commented on the issue:
https://github.com/apache/cordova-cli/pull/266
Here is the discussion for the proposal:
https://github.com/cordova/cordova-discuss/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user brodybits commented on the issue:
https://github.com/apache/cordova-cli/pull/266
I hope to see this integrated soon. I have seen way too many new users
keeping old plugins in git instead of just adding them to config.xml.
---
If your project is set up for it, you can repl
Github user brodybits commented on the issue:
https://github.com/apache/cordova-cli/pull/255
Status?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/213
@ktop, done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/222
## [Current
coverage](https://codecov.io/gh/apache/cordova-windows/pull/222?src=pr) is
76.93% (diff: 100%)
> Merging
[#222](https://codecov.io/gh/apache/cordova-windows/pull/222?src=
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/222
Upgrade cordova-common to 2.0.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-windows master
Alter
Github user ktop commented on the issue:
https://github.com/apache/cordova-windows/pull/213
@daserge
Now that there has been a cordova-common release, can we refresh
cordova-common in cordova-windows and get this merged?
---
If your project is set up for it, you can reply to thi
GitHub user victorsosa opened a pull request:
https://github.com/apache/cordova-docs/pull/678
Added nougat support version
6.0.0 Added nougat support version
### Platforms affected
### What does this PR do?
### What testing has been done
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/515
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97743108
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project,
platformApi, pluginInfo
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97741534
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project,
platformApi, pluginInfoProvider
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97738068
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project,
platformApi, pluginInfo
36 matches
Mail list logo
