[GitHub] cordova-plugin-inappbrowser issue #206: CB-12320: (iOS) WIP Add support for ...

2017-01-17 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/206 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/206/commits/af70ef3175ca8b60a7ea51d5ae8

[GitHub] cordova-plugin-file issue #199: CB-12355: (iOS) fix FileEntry.file.type

2017-01-17 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/199 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/199/commits/667ddfa40a4056c40624ba8d5bdac7c8a28ec98c)

[GitHub] cordova-plugin-file issue #199: CB-12355: (iOS) fix FileEntry.file.type

2017-01-17 Thread LightZam
Github user LightZam commented on the issue: https://github.com/apache/cordova-plugin-file/pull/199 @stevengill could you help me find a code reviewer, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

Re: iOS: Cordova framework target

2017-01-17 Thread Kevin Hawkins
I guess CB-12050 would be related, as far as that goes. On Tue, Jan 17, 2017 at 3:13 PM, Kevin Hawkins < kevin.hawkins.cord...@gmail.com> wrote: > I've been long out of the day-to-day happenings of the Cordova project, so > I apologize if this grou

iOS: Cordova framework target

2017-01-17 Thread Kevin Hawkins
I've been long out of the day-to-day happenings of the Cordova project, so I apologize if this ground has been covered before; I searched back through my archive and didn't immediately see anything related. I'll see if I can keep this description as concise as possible. For our iOS SDK, we ship a

[GitHub] cordova-windows pull request #221: CB-12018 : updated tests to work with jas...

2017-01-17 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-windows/pull/221 CB-12018 : updated tests to work with jasmine instead of jasmine-node *Not ready for review yet.. thanks! ### Platforms affected ### What does this PR do?

[GitHub] cordova-plugin-inappbrowser issue #206: CB-12320: (iOS) WIP Add support for ...

2017-01-17 Thread spongessuck
Github user spongessuck commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/206 @reidab Thanks, fixed in af70ef3. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cordova-plugin-inappbrowser issue #206: CB-12320: (iOS) WIP Add support for ...

2017-01-17 Thread reidab
Github user reidab commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/206 Pulled down this PR and in my local testing with `navigationbar=yes` and `navigationbuttons=yes` the back/forward buttons appear to be reversed. ![screen shot 2017-01-17 a

Re: [DISCUSS] Include TypeScript definitions in plugins

2017-01-17 Thread Котиков Владимир
Hey guys! I’m excited to see such positive feedback ☺ This sounds like a consensus, so we’re going to publish the PRs to the core plugins in a couple of days. Also, a bit of technical details: - as Mike mentioned, typescript definitions are not necessarily need to be placed at the root of pa

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2017-01-17 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/453 Windows has a `WindowsStoreDisplayName` preference, but I'm not clear if it's the same concept or not. In any case, the proper place for the platform changes should happen in each of the

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2017-01-17 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/453 Hmm. `edit-config` still hasn't been implemented for `config.xml` and might not for a while. I can see both sides of the argument. One of the main goals for `edit-config` was to have

[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-01-17 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/321 Yeah, I'm going to try to get it set up locally with cordova-common master and ensure it's all working as intended --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-01-17 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-android/pull/321 Needs review with master cordova-common. Aka cordova-common@2 (releasing soon) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cordova-lib issue #214: CB-8978 Added new image element tag for config.xml

2017-01-17 Thread ktop
Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/214 Yep, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request #214: CB-8978 Added new image element tag for confi...

2017-01-17 Thread ktop
Github user ktop closed the pull request at: https://github.com/apache/cordova-lib/pull/214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cordova-lib issue #214: CB-8978 Added new image element tag for config.xml

2017-01-17 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/214 I've merged https://github.com/apache/cordova-lib/pull/468 in. @ktop can you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cordova-lib pull request #468: CB-8978 Add resource-file parsing to config.x...

2017-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android pull request #355: CB-12018 : updated tests to work with jas...

2017-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-ios pull request #284: CB-12018 : updated tests to work with jasmine...

2017-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android issue #355: CB-12018 : updated tests to work with jasmine (p...

2017-01-17 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/355 Looks fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-inappbrowser issue #115: Support for passing request headers ...

2017-01-17 Thread julienmartin
Github user julienmartin commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/115 Any news on this ? I can't build on Xcode (missing .h declaration for navigateToNew method). --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-docs pull request #675: CB-6275 Added iOS support icon for Backgroun...

2017-01-17 Thread mdoelker
GitHub user mdoelker opened a pull request: https://github.com/apache/cordova-docs/pull/675 CB-6275 Added iOS support icon for BackgroundColor preference iOS support was added in CB-6274 / https://github.com/apache/cordova-ios/pull/283 You can merge this pull request into a Git rep

Buildbot: buildslave cordova-osx-slave was lost

2017-01-17 Thread buildbot
The Buildbot working for '' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Tue Jan 17 11:12:06 2017 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Richard Knoll '. Sincerely, The Buildbot https://ci.apache.or

Buildbot: buildslave cordova-windows-slave was lost

2017-01-17 Thread buildbot
The Buildbot working for '' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Tue Jan 17 11:12:06 2017 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Richard Knoll '. Sincerely, The Buildbot https://ci.apache

[GitHub] cordova-plugin-file pull request #199: CB-12355: (iOS) fix FileEntry.file.ty...

2017-01-17 Thread LightZam
GitHub user LightZam opened a pull request: https://github.com/apache/cordova-plugin-file/pull/199 CB-12355: (iOS) fix FileEntry.file.type ### Platforms affected iOS ### What does this PR do? fix iOS FileEntry.file callback return a null type ### What testin