Github user darron1217 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94530284
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = new
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/510
## [Current
coverage](https://codecov.io/gh/apache/cordova-lib/pull/510?src=pr) is 52.15%
(diff: 100%)
> No coverage report found for **master** at 84fa8e3.
> Powered b
Please review and vote on this 6.1.1 Android Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-12314
The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-12314
The package
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/273
@sterlingann seems to be merge conflicts, you might need to rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
This is a list for discussing development of Cordova itself, and not how to
use Cordova.
That being said, all sample code should be in http://docs.cordova.io
We've only really tested it in Android Studio or the Android SDK - for
Netbeans you are on your own.
On Fri, Dec 23, 2016 at 4:06 AM, Subas
I can only speak for iOS, but in the generated project code there is this
method you can override:
https://github.com/apache/cordova-ios/blob/69e06b0a854e5a566b38dd021bcdca0e2f65947c/bin/templates/project/__PROJECT_NAME__/Classes/MainViewController.m#L146
Parse what type of command there, and hand
Thanks Javier!
On Wed, Dec 28, 2016 at 3:43 AM, Javier Puerto wrote:
> Hi devs,
>
> I've created a small tutorial to integrate Angular 2 application with
> Apache Cordova. I wonder if it could be useful for the community and in
> that case here is the link so you can refer to it in case that you
Related: https://issues.apache.org/jira/browse/CB-6582
(almost 3 years old...)
TLDR; we should update the engine tags, with as much granularity as
possible.
I think we didn't do this because we don't actually know if it *doesn't*
work on an older version (since of course we don't test the current
Github user sterlingann commented on the issue:
https://github.com/apache/cordova-ios/pull/273
@shazron Lines are removed, sorry for the delay
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25
Please add "CB-12317" as a prefix to your PR title.
I've also added https://issues.apache.org/jira/browse/CB-12317 which was
required in the PR template.
---
If your proj
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/26
Although I replied to you jokingly on Twitter, let me explain why this is
not a good idea, and I'm 100% sure will not be approved by the committers on
Apache Cordova based on
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-android/pull/355
CB-12018 : updated tests to work with jasmine (promise matcher tests â¦
â¦commented out for now)
### Platforms affected
### What does this PR do?
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/284
@audreyso This PR needs a rebase probably.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/283
Thanks for the PR! Unit tests still need to be added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94508708
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = new W
Github user infil00p commented on the issue:
https://github.com/apache/cordova-lib/pull/469
This PR is hilariously out of date, and this functionality was added
elsewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-lib/pull/469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94507888
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = n
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
Merging and lightly testing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
I have noticed that most of the plugins don't use the engine tags or have
them set to cordova 3.0.0 or 3.1.0 which are very old.
As we drop support for old iOS/Android versions when updating cordova-ios
and cordova-android, what is our policy for iOS/Android versions support in
plugins?
Right now
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94468334
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = new W
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94467650
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = n
Sounds good.
On Tue, Jan 3, 2017 at 10:23 AM, Steven Gill wrote:
> Going to start this patch release today. It will make our CI pass again for
> cordova cli + lib.
>
> https://issues.apache.org/jira/browse/CB-12314
>
Going to start this patch release today. It will make our CI pass again for
cordova cli + lib.
https://issues.apache.org/jira/browse/CB-12314
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94452235
--- Diff: src/android/InAppBrowser.java ---
@@ -832,6 +889,42 @@ private void sendUpdate(JSONObject obj, boolean
keepCallback, PluginRe
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94451785
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = new W
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94451894
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = new W
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94452072
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = new W
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/244
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/244/commits/05594c46468576da846b31b03e624d72f7c9c47
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
Rebased and squashed commit and updated message to have the same format as
you pointed out @alsorokin. Thanks for the review! I'll merge upon tests
passing.
---
If your project is set
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
Filed [CB-12312](https://issues.apache.org/jira/browse/CB-12312) for this
one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-ios/pull/284
CB-12018 : updated tests to work with jasmine and testing labels
### Platforms affected
### What does this PR do?
Updates tests from jasmine-node to jasmine. La
34 matches
Mail list logo
