[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

2016-12-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/143 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/143/commits/88b243c4b0283a8c472580c78af6d8130a7

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

2016-12-09 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/143 Ahyep, that was it :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

2016-12-09 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/143 Hmm, I noticed that, on Sauce Labs, the [test is reporting as errored due to "100 seconds without a command"](https://saucelabs.com/beta/tests/68c9883683ae472eabc9d5304a500096/watch).

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

2016-12-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/143 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/143/commits/0153e093689db952846621fc14fa2bd7f17

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

2016-12-09 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/143 @alsorokin can you review when you get a chance? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

2016-12-09 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/143 Jasmine use of `afterAll` and label tweaks ### Platforms affected iOS and Android ### What does this PR do? Instead of encapsulating teardown functionality

[GitHub] cordova-medic pull request #106: Appium updates

2016-12-09 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-medic/pull/106 Appium updates Please review @alsorokin ! ### Platforms affected iOS and Android ### What does this PR do? Fixes and cleans up certain interactions with appi

[GitHub] cordova-windows issue #215: CB-12193 cordova.js crashes windows app if there...

2016-12-09 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/215 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/215?src=pr) is 76.13% (diff: 100%) > Merging [#215](https://codecov.io/gh/apache/cordova-windows/pull/215?src=

[GitHub] cordova-windows pull request #215: CB-12193 cordova.js crashes windows app i...

2016-12-09 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/215 CB-12193 cordova.js crashes windows app if there is no CoreWindow ### Platforms affected Windows ### What does this PR do? Don't subscribe to WinRT lifecycle event

[GitHub] cordova-lib pull request #:

2016-12-09 Thread luissilvaos
Github user luissilvaos commented on the pull request: https://github.com/apache/cordova-lib/commit/328980c2a91dada8049f1e4f27103df67ba07532#commitcomment-20134722 Hi, This is preventing me from install a plugin with a git-ref without subdirectories. Example: https://github.co

[GitHub] cordova-plugin-media issue #99: Suppress warnings: Pass in the settings obje...

2016-12-09 Thread charliewilliams
Github user charliewilliams commented on the issue: https://github.com/apache/cordova-plugin-media/pull/99 Ping! Anyone looked at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

RE: [VOTE] Plugins Release

2016-12-09 Thread alsorokin
I vote +1. * Verified signatures and hashes * Verified tags * Verified that plugins can be added correctly to blank app * Verified that blank app can be successfully built and ran (windows, ios and android) * Verified that browserified app can be successfully built and ran (windows, ios and andr