Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/462
Anyone wanna look? @vladimir-kotikov @stevengill ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/316
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
This info is in config.xml isn't it?
http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";>
MyAppHasAName
...
Plugins are already expected to read their own preferences, unfortuately
the CordovaPreferences.java file does not appear to be the right place, as
this is no
Github user gruppjo commented on the issue:
https://github.com/apache/cordova-lib/pull/459
Great! Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Nightly build #90 for cordova has failed.
Please check failure details on build details page at
https://builds.apache.org/job/cordova-nightly/90/
You can also take a look at build console:
https://builds.apache.org/job/cordova-nightly/90/consoleFull
-
Jenkins for Apache Cordova
---
+1 what Vladimir said
On Mon, Aug 1, 2016 at 11:29 PM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:
> I think I like option 2 more than others, assuming that we also accept
> values between 0 and 1 as a medium quality. Then it won't break existing
> behavior on Android and would al
Hello,
I'm looking at improving our vscode extension for Cordova development.
Currently we bundle a set of typings for Cordova and some plugins with the
extension, and we use these typings to provide intellisense even for plain
javascript projects. I would like to improve this by using the corr
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/131
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-contacts/pull/131/commits/0dc9d7b51a5baeac77a9dc30b2edb7cd8c6
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/129
Hi.
I have sent a new PR
(https://github.com/apache/cordova-plugin-contacts/pull/131) where the usage
description can be added as a variable on plugin install or use an empt
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/131
CB-11455: (ios) Add mandatory iOS 10 privacy description
### Platforms affected
iOS
### What does this PR do?
Adds the mandatory `NSContactsUsageDescr
Github user carynbear commented on the issue:
https://github.com/apache/cordova-lib/pull/474
I would like to use it in Phonegap, but also it seems like a useful method
in general for dealing with Cordova projects. In the spirit of modularizing
Cordova, it seems that Plugman would be a
Github user Hirbod commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/37
Just came here to see if there is any solution to fade the status bar - and
there we go. I don't understand why this isnt merged. Could you guys please add
this into the plugin?
---
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/219
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/219/commits/fee72c7c0439037d1d7ee44603271c528eda769c
Github user daserge commented on the issue:
https://github.com/apache/cordova-lib/pull/475
You should also check test failures if they occur after squashing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user daserge commented on the issue:
https://github.com/apache/cordova-lib/pull/475
Yes, LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/475
Thanks, @daserge, updated. Is this good to go now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/475
## [Current
coverage](https://codecov.io/gh/apache/cordova-lib/pull/475?src=pr) is 80.68%
(diff: 100%)
> Merging [#475](https://codecov.io/gh/apache/cordova-lib/pull/475?src=pr)
into [ma
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/219
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/219/commits/5807458a1d5d58bb84f0b060bc069b4b50d2215b
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/475#discussion_r73153070
--- Diff: cordova-lib/src/cordova/emulate.js ---
@@ -42,20 +46,17 @@ module.exports = function emulate(options) {
}).then(function() {
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/190#discussion_r73152541
--- Diff: template/cordova/lib/run.js ---
@@ -39,7 +39,7 @@ module.exports.run = function (options) {
// parse arg
var args =
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/475
@daserge. @sgrebnov, PTAL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/475
CB-11652 Update run and emulate to skip build
This PR moves handling of `--nobuild` option to CLI. CLI previously has
delegated this logic to platform's
`run` method but since intr
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/190#discussion_r73150144
--- Diff: template/cordova/lib/run.js ---
@@ -39,7 +39,7 @@ module.exports.run = function (options) {
// parse arg
va
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/190#discussion_r73147848
--- Diff: template/cordova/lib/run.js ---
@@ -39,7 +39,7 @@ module.exports.run = function (options) {
// parse arg
va
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/190#discussion_r73132090
--- Diff: template/cordova/lib/run.js ---
@@ -39,7 +39,7 @@ module.exports.run = function (options) {
// parse arg
var args =
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/190
## [Current
coverage](https://codecov.io/gh/apache/cordova-windows/pull/190?src=pr) is
74.21% (diff: 100%)
> Merging
[#190](https://codecov.io/gh/apache/cordova-windows/pull/190?src=
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/190
CB-11478 Parse --archs option consistently
This PR aligns arguments parsing logic with `build` command where passing
`--archs` either as CLI argument (`cordova build --archs`) or p
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/190
@daserge, @sgrebnov, please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user medoix commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/55
@goshakkk bump.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/185
LGTM, :ship: it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugins/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/185#discussion_r73113256
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -105,7 +105,7 @@ var handlers = {
var type = obj.type;
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/459
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/459
Hey. I'm sorry that it took us so long to accept your PR. Merging it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
36 matches
Mail list logo
