Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/80
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-dialogs/pull/80/commits/d0e5eec8ced9546751fbe8165292b40788e4cfc
Nightly build #86 for cordova has failed.
Please check failure details on build details page at
https://builds.apache.org/job/cordova-nightly/86/
You can also take a look at build console:
https://builds.apache.org/job/cordova-nightly/86/consoleFull
-
Jenkins for Apache Cordova
---
Github user riknoll closed the pull request at:
https://github.com/apache/cordova-lib/pull/472
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/473
The only other consideration I can think of off the top of my head is that
the edit-config stuff also made changes to the android.json (and other
equivalent platform files) for edit-config suppo
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/472
Closing in favor of #473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
This vote has failed. Will redo it once cordova-common@1.4.1 comes out
On Thu, Jul 28, 2016 at 6:25 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:
> I vote +1:
>
> * Reviewed release notes
> * Verified signatures and hashes
> * Verified that blank app could be created with the pl
This vote has failed
On Fri, Jul 29, 2016 at 10:01 AM, Joe Bowser wrote:
> I vote -1
>
> The latest cordova-common in this release doesn't work properly and keeps
> giving me a JS error saying that pluginInfo.getEditConfigs is not a
> function. This appears to be something added in the past mon
android@5.2.2 and ios release are going to be postponed. Need to do a
cordova-common release with the fix first.
On Fri, Jul 29, 2016 at 5:24 PM, Steven Gill wrote:
> Sent a PR. Should get reviewed by ppl who worked closer on edit-config to
> see if my changes will cause a problem.
> https://git
Sent a PR. Should get reviewed by ppl who worked closer on edit-config to
see if my changes will cause a problem.
https://github.com/apache/cordova-lib/pull/473
On Fri, Jul 29, 2016 at 3:31 PM, Steven Gill wrote:
> Issue: https://issues.apache.org/jira/browse/CB-11645
>
> On Fri, Jul 29, 2016 at
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/473
## [Current
coverage](https://codecov.io/gh/apache/cordova-lib/pull/473?src=pr) is 80.66%
(diff: 100%)
> Merging [#473](https://codecov.io/gh/apache/cordova-lib/pull/473?src=pr)
into [ma
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/473
CB-11645 added check to see if getEditConfig exists before trying to â¦
â¦use it
Please review @macdonst @vladimir-kotikov @ktop. I am not familiar enough
with these new changes.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/472
## [Current
coverage](https://codecov.io/gh/apache/cordova-lib/pull/472?src=pr) is 80.66%
(diff: 100%)
> Merging [#472](https://codecov.io/gh/apache/cordova-lib/pull/472?src=pr)
into [ma
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/472
@ktop @stevengill @vladimir-kotikov @TimBarham please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-lib/pull/472
CB-11645: Check for getEditConfigs before invoking it on pluginInfo
Adding a guard to prevent a type error when platforms and CLI have
mismatching cordova-common versions. The issue here is tha
GitHub user juliascript opened a pull request:
https://github.com/apache/cordova-coho/pull/130
CB-11646 version arg optional, will grab from repo if not provided
See https://issues.apache.org/jira/browse/CB-11646
You can merge this pull request into a Git repository by running:
Issue: https://issues.apache.org/jira/browse/CB-11645
On Fri, Jul 29, 2016 at 12:03 PM, Steven Gill
wrote:
> So a pretty big problem of this patch release is that it requires cordova
> >= 6.3.0. I don't think we can release it as is. We can't break
> compatibility for everyone using older versio
Hey
So, after working on the Camera fix for Android N, I found that we need the
Java plugins to be able to get the Application ID, and that we shouldn't
expect the application ID to be the same as the namespace of the
application, so I propose we add a getBuildConfigValue to Cordova.
The only pro
Github user cjpearson closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugins/pull/27
CB-11644: (ios) Set cdvtoken cookie path to root
### Platforms affected
iOS
### What does this PR do?
Set the cdvToken cookie's path to root, so it applies to all requests
Github user stevengill commented on the issue:
https://github.com/apache/cordova-ios/pull/234
@blakgeek that is pretty cool!
Looks like @juliascript PR handles most of it. (doesn't handle
configuration yet)
For android, you would add your plugin deps to your gradle fi
So a pretty big problem of this patch release is that it requires cordova
>= 6.3.0. I don't think we can release it as is. We can't break
compatibility for everyone using older versions of cordova over a patch
release and minor release (cordova-common)
On Mon, Jul 25, 2016 at 1:05 PM, Simon MacDon
GitHub user juliascript reopened a pull request:
https://github.com/apache/cordova-coho/pull/129
CB-11642 Update CDVAvailability.h
See https://issues.apache.org/jira/browse/CB-11642
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user juliascript closed the pull request at:
https://github.com/apache/cordova-coho/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
I vote -1
The latest cordova-common in this release doesn't work properly and keeps
giving me a JS error saying that pluginInfo.getEditConfigs is not a
function. This appears to be something added in the past month.
On Thu, Jul 28, 2016 at 6:13 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsof
GitHub user chrisgriffith opened a pull request:
https://github.com/apache/cordova-docs/pull/624
Correcting android-versionCode
The android-versionCode must be an integer used as an internal version
number.
You can merge this pull request into a Git repository by running:
$
Github user blakgeek commented on the issue:
https://github.com/apache/cordova-ios/pull/234
@juliascript @shazron Have you considered adding support for specifying
pods at the project level as well. This makes it easy to resolve conflicts in
pod specifications across plugins and is u
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/471
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugins/pull/26
CB-11643: return after sending error
### Platforms affected
iOS
### What does this PR do?
After an error is returned, we should return and not process the request
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user matrosovN opened a pull request:
https://github.com/apache/cordova-lib/pull/471
CB-11205 fix bug restore plugin with variables via 'plugin add' command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosovN/cordova
30 matches
Mail list logo
