Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/295#issuecomment-216759612
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/303#issuecomment-216705549
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61976209
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -203,6 +203,11 @@ GradleBuilder.prototype.build = function(opts) {
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61975714
--- Diff: bin/lib/check_reqs.js ---
@@ -238,13 +236,13 @@ module.exports.getAbsoluteAndroidCmd = function () {
return cmd.replace(/(\s)/g, '
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61975678
--- Diff: bin/lib/check_reqs.js ---
@@ -254,18 +252,22 @@ module.exports.check_android_target =
function(valid_target) {
}
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-216691951
Hey Everyone,
I think the first implementation of this is ready to hit master behind the
--fetch flag. It includes platform and plugin fetching + removin
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-android/pull/303
CB-11198 Skip android target sdk check
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android faster
Alternativel
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-windows/pull/174
CB-7: Optimize prepare for windows platform, clean prepared files
This uses the `FileUpdater` module added in apache/cordova-lib#429 to skip
copying files that didn't change. Some refa
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-ios/pull/220
CB-7: Optimize prepare for ios platform, clean prepared files
This uses the `FileUpdater` module added in apache/cordova-lib#429 to skip
copying files that didn't change. Some refactoring
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-216668274
@jasongin maybe I can see about getting [this
logo](http://www.apple.com/osx/) for OS X.
Title text is added by docs.js
[here](https://github.com/apache/c
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-216667182
Diffing an svg file also sucks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-21788
Do the icons have title text? If so I can't find it in the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-216665227
> The Apple logo is now used to indicate the OS X platform.
This is confusing to me, given that I never think about using Cordova to
develop apps for OS X, and
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-216662778
Also note that this changes the iOS logo (see leftmost logo in attached
image). The Apple logo is now used to indicate the OS X platform. The new iOS
logo is sort
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-216661665
@rakatyal @nikhilkh please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-216661525
Here is what it looks like. The logos appear under the attribute name.
, I see the same behavior that you both were
seeing. I was able to fix it by doing a `cordova-coho/coho npm-link`
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216628696
Okay, thanks for clarifying. I rescind my objection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216624907
If you're talking about a source file, then that would change the
last-modified timestamp of the source file, causing it to be newer than the
target file so it wil
GitHub user Mikejo5000 opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/145
added link to sample
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Mikejo5000/cordova-plugin-file-transfer master
Al
Github user afourney commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216620202
@rakatyal Thanks for investigating. Your findings agree with my own
experiences. This is possibly some quirk of WinJS.
---
If your project is set up for it,
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216619728
Is it possible that a change to a file without affecting file size could go
undetected?
---
If your project is set up for it, you can reply to this email and
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216618382
I did some digging into this with other activation kinds and I confirmed
that few event details are lost once the event handler is executed possibly to
hide/di
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216618237
BTW, I didn't mention above the reason I had to abandon the approach of
checking for exactly-equal modified times. The problem is the OS X filesystem
doesn't suppo
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216617718
@purplecabbage If a hook fails because it expected a file would be
refreshed but it wasn't, then I'd expect the hook to print an error (or stack
trace), so that sh
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216611405
All right, I think this is the best we can do. The latest logic copies the
file if the source's last-modified time is >= the target's last-modified time,
or if the
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216614096
I would not consider that contrived.
This would be an extremely tough issue to find if it happened.
---
If your project is set up for it, you can reply
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61922956
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -17,13 +17,30 @@
var fs = require('fs');
var path = require('path');
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61917593
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports = {
-e
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61917144
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,7 +22,7 @@ var fs = require('fs');
var path = require('path');
var _ = require('underscor
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61915826
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,7 +22,7 @@ var fs = require('fs');
var path = require('path');
var _ = require('underscor
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61915398
--- Diff: cordova-lib/src/platforms/PlatformApiPoly.js ---
@@ -474,7 +473,12 @@ function getCreateArgs(destinationDir, projectConfig,
options) {
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61914375
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -17,13 +17,30 @@
var fs = require('fs');
var path = require('path');
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61913509
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,7 +22,7 @@ var fs = require('fs');
var path = require('path');
var _ = require('underscor
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61913318
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -17,13 +17,30 @@
var fs = require('fs');
var path = require('path');
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61913141
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports = {
-e
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61912923
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports = {
-e
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61912394
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports = {
-e
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61912274
--- Diff: cordova-common/cordova-common.js ---
@@ -3,7 +3,7 @@
or more contributor license agreements. See the NOTICE file
distributed
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216585668
Well, after further testing I found creation dates don't work reliably due
to some strange behavior on Windows:
http://serverfault.com/questions/92757/incorrect-fi
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-lib/pull/434
CB-11194 Improve cordova load time
I instrumented module load and this change improves our load time by ~50%
(300+ ms) for `cordova build android` on a hello world project. Biggest gains
are
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-216543951
@purplecabbage
My workspace is working off of the master branches with the tools npm
linked.
I modified the plugin.xml of cordova-plugin-device and added
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216458424
@rakatyal, actually, I believe you need to clone it anyway to have it
available in the trigger.
My problem is more about how to serialize/marshaling suc
48 matches
Mail list logo