Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/159#issuecomment-202743738
Reviewed and verified on sample config/images :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57676830
--- Diff: cordova-common/spec/events.spec.js ---
@@ -0,0 +1,30 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
I think I have created a discussion, but it is not showing up... yet
another frustrations!
Rob
Regards
*Rob Posener*
0419 012 627
On 29 March 2016 at 16:48, Parashuram N wrote:
> I am not sure if everyone got the attachment. Rob, can I request you to
> create an issue on https://github.com/co
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/134
CB-10978 Fix file-transfer.tests JSHint issues
[Jira issue](https://issues.apache.org/jira/browse/CB-10978)
You can merge this pull request into a Git repository by running:
I am not sure if everyone got the attachment. Rob, can I request you to create
an issue on https://github.com/cordova/cordova-discuss so that we could start
following up on specific issues there ?
From: Robert Posener
Reply-To: "dev@cordova.apache.org"
Date: Monday, March 28, 2016 at 10:08 PM
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57673750
--- Diff: cordova-common/spec/events.spec.js ---
@@ -0,0 +1,30 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57673594
--- Diff: cordova-common/src/events.js ---
@@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter)
{
if (!(eventEmitter inst
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-202714763
How often does the test pass now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Gerday all,
Because of the serious nature of this thread, I have produced a 6-page
contribution of issues together with recommendations for fixing them in the
attachment to this email.
Regards
Rob Posener
Regards
*Rob Posener*
0419 012 627
On 19 March 2016 at 08:31, Joe Bowser wrote:
> I don'
Also...
These examples could be developed in such a way as to become part of the
Cordova automated testing that is performed before a new version release,
thereby adding more complex tests to the test suite.
You'll need to be careful of this anyway (ie, It would look pretty bad if
these examples we
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/39#issuecomment-202658419
@winstef it's more likely to get merged if someone updates it to remove the
merge conflicts.
---
If your project is set up for it, you can reply to this
GitHub user Mikejo5000 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/175
readme updates with samples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Mikejo5000/cordova-plugin-file master
Alternatively
Including a demo folder in each plugin is good. If it is checked in, we ensure
that the example and the plugin use the same version of the API.
However, there may be some examples (typically in the file plugin area) where a
good scenario would mean using 2 plugins. What do we do for that ?
---
Awesome.
I typically include a demo folder with inside my plugin repos, but this
does mean that this demo code gets copied all over the place if a user
installs a plugin via git-repo or clone.
I npm-ignore the demo folder so at least it does not go to npm ...
Here's an example:
https://github.com/
Awesome.
I typically include a demo folder with inside my plugin repos, but this
does mean that this demo code gets copied all over the place if a user
installs a plugin via git-repo or clone.
I npm-ignore the demo folder so at least it does not go to npm ...
Here's an example:
https://github.com/
+500
Regards
*Rob Posener*
0419 012 627
On 29 March 2016 at 08:47, Parashuram N wrote:
> Hey folks,
>
> At the moment, the sample code in our plugins is limited to only show
> basic usage of the API. While this is great for someone who has already
> written Cordova projects, I believe that we m
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-202599984
Merged
[here](https://github.com/apache/cordova-plugin-file-transfer/commit/584754869befd2d899f8e20270ba086ffe525625).
---
If your project is se
Github user rakatyal closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/59#issuecomment-202599822
@infil00p please review this one when you have a moment. Pretty large
refactor
---
If your project is set up for it, you can reply to this email a
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-202597643
The update to check for an empty toString() result (as discussed) looks
good.
---
If your project is set up for it, you can reply to this email
Hey folks,
At the moment, the sample code in our plugins is limited to only show basic
usage of the API. While this is great for someone who has already written
Cordova projects, I believe that we may need more examples for folks who are
just getting started with Cordova.
To improve our documen
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/174#issuecomment-202582415
@infil00p @jasongin @rakatyal please review when you have a moment. Also,
should I add manual tests for this? It requires interacting with permission
dialo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57634233
--- Diff: cordova-common/spec/events.spec.js ---
@@ -0,0 +1,30 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57634064
--- Diff: cordova-common/src/events.js ---
@@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter)
{
if (!(eventEmi
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/174
CB-10977 android: Removing global state used for permission requests
The associated JIRA is
[CB-10977](https://issues.apache.org/jira/browse/CB-10977). Check out the
description on the
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57632693
--- Diff: cordova-common/src/events.js ---
@@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter)
{
if (!(eventEmi
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-202575695
I tested it on Android and apparently we do accept non string values and I
don't see any reason why we should not. So your suggestion sounds fair
I would like to see a patch release for the tools
Interested if someone can review and merge these PRs and get include it in
the release:
https://github.com/apache/cordova-lib/pull/418
https://github.com/apache/cordova-lib/pull/417
https://github.com/apache/cordova-lib/pull/416
https://github.com
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/110
CB-10881: Remove global state between tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-plugin-contacts CB-
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-202545461
Yes it would but the options parameter is supposed to have only string
key-value pairs as mentioned in the README.
---
If your project is set up
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/164#discussion_r57618689
--- Diff: template/cordova/lib/prepare.js ---
@@ -420,6 +420,11 @@ module.exports.prepare = function (cordovaProject) {
this._config = update
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#discussion_r57616771
--- Diff: tests/tests.js ---
@@ -373,7 +373,7 @@ exports.defineAutoTests = function () {
setTimeout(function () {
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/164#issuecomment-202533644
Thanks, @omefire
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user omefire commented on the pull request:
https://github.com/apache/cordova-windows/pull/164#issuecomment-202533382
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#discussion_r57616106
--- Diff: tests/tests.js ---
@@ -373,7 +373,7 @@ exports.defineAutoTests = function () {
setTimeout(function () {
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/89
CB-10783: Media Plugin - Modify expected position to be in a proper range
Fix for the flaky tests in Media Plugin.
[Link](https://cloud.githubusercontent.com/assets/602456/14087006/d
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/164#discussion_r57615496
--- Diff: template/cordova/lib/prepare.js ---
@@ -420,6 +420,11 @@ module.exports.prepare = function (cordovaProject) {
this._config
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/417#discussion_r57614805
--- Diff: cordova-common/spec/util/xml-helpers.spec.js ---
@@ -207,6 +207,16 @@ describe('xml-helpers', function(){
expect(test
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/417#issuecomment-202528558
LGTM. Didn't have a time to test it but making `name` a singleton
definitely makes sense.
---
If your project is set up for it, you can reply to this emai
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/164#discussion_r57611536
--- Diff: template/cordova/lib/prepare.js ---
@@ -420,6 +420,11 @@ module.exports.prepare = function (cordovaProject) {
this._config = update
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-lib/pull/418
CB-10940 Can't add Android platform from path
Added a corresponding test for events.forwardEventsTo
[Jira issue](https://issues.apache.org/jira/browse/CB-10940)
You can merge this pull
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/285#issuecomment-202506848
Perhaps we can mock the Activity's request permissions method? I don't have
a lot of experience writing JUnit tests for Android.
---
If your project is set up
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r57571624
--- Diff: appium-tests/common/common.spec.js ---
@@ -0,0 +1,321 @@
+/*jshint node: true, jasmine: true, browser: true */
+/*global
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/278
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/284
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-test-framework/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
53 matches
Mail list logo
