Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/147#issuecomment-179031723
Reviewed changes, :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Hi Sean, such discussion should happen in [Discuss] thread, before vote is
started. CB-7786 introduces new functionality so this should be in minor or
major release anyway. I've reviewed your PR and it looks good, I'll merge it
later today.
Thx!
-Sergey
-Original Message-
From: Steven
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/132#issuecomment-179030795
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/480#issuecomment-179025411
I'm assuming your grep'd for any incoming links to the files that you are
deleting.
---
If your project is set up for it, you can reply to this email and have yo
yes I tried it your index.html, red boxes some time disappear but they also
disappear on simulator so didn't know what you were looking for.
ping me tomorrow on slack, maybe I can screen share and do a live session.
On Tue, Feb 2, 2016 at 9:18 AM julio cesar sanchez
wrote:
> Thanks for testing.
Hey Sean,
We only -1 if it is a regression or major bug found. I would say CB-7786
doesn't qualify as either of those.
According to ASF policies, only PMC members can vote.
I know you have been trying to get someone to review your PR. I'll bug some
people tomorrow to see if we can get it reviewe
I'd vote no. I'd really like to see CB-7786 get in before the next release.
SeanK
On Tue, Feb 2, 2016 at 4:17 AM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> Please review and vote on the InAppBrowser plugin release
> by replying to this email (and keep discussion on the DISCUSS
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/463#issuecomment-178958029
Additional review comments handled and committed.
Thanks !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/74#issuecomment-178945513
@dblotsky is this good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51665030
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -45,207 +45,356 @@ passively copied into various `platforms/`
subdirectories, for example:
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51664771
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -45,207 +45,356 @@ passively copied into various `platforms/`
subdirectories, for example:
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51664527
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178919636
Alright I'm going to leave it as is and I'll change it if it becomes an
issue.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/481#issuecomment-178885986
Hmm, that's a good point. I guess if we ever do implement levels in the
page ToC then we can always just put them back. LGTM then.
---
If your project is set up
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-lib/pull/369#issuecomment-178885626
Yep, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/481#issuecomment-178884046
No, I don't think it is. What special meaning does H3+ have in the TOC? All
of our TOC entries for a page are presented without hierarchy in the sidebar;
H3+ lose
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/481#issuecomment-178882554
I'm still a bit unconvinced that all H3 - H6 headings should be excluded
from ToC across the board. This is specific to the reference pages, isn't it?
---
If you
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/481#issuecomment-178880580
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/481
CB-10516: Remove h3-h6 from showing up in docs ToC
Removing h3-h6 from showing up in docs ToC
@dblotsky @riknoll @nikhilkh Can you please review and merge this PR?
You can merge th
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51652071
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,386 @@ title: Events
# Events
-> Cordova lifecycle events.
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51651676
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc(
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51651551
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc(
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51651548
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc({
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/480#issuecomment-178875194
@riknoll @rakatyal @dblotsky Removed the full examples for all except
required.
---
If your project is set up for it, you can reply to this email and have your
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51650887
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc({
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-osx/pull/28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51650131
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc({
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/480#issuecomment-178872563
+1 to Richard's previous comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/480#issuecomment-178872718
+1 to Richard's point. They hardly add anything relevant and the format
repeats for each event. I think that we can rename it to example, give the full
example fo
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51649541
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc({
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/479#issuecomment-178872081
+1 to @dblotsky's comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/480#issuecomment-178871869
I mentioned this offline, but do we want to include the full example for
each event? Adds a lot of length to the document and all of the examples are
the same with
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/479#issuecomment-178871753
We have another variable, `latest_docs_version`, whose name sounds like
this one. Please rename this variable to something more explicit (like
`default_linked_doc
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51649012
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,560 @@ title: Events
# Events
-> Cordova lifecycle events.
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/480#issuecomment-178870956
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51648894
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-medic/pull/74#issuecomment-178870049
@dblotsky I think both of them use slightly different libs (request and
http). So, for now, I am leaving it as is. But, I am marking this for further
changes as
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51648833
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/74#issuecomment-178869407
Oh, I think I'm mistaking this for `testwait`. `testcheck` does *not* poll
and yes, this is necessary. My mistake! Do you think this can be factored out
to be in
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51648033
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,561 @@ title: Events
# Events
-> Cordova lifecycle events.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178865169
Yep, that sounds fine. I would even say not to worry about it if you want
to leave it as it is: on the CI environment we have only one simulator/device
anyway. Al
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51646921
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,561 @@ title: Events
# Events
-> Cordova lifecycle events.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-178861517
Is this a part of our external API? If not, then why should there be a way
to get them without the debugger if it's an internal feature?
---
If your project is se
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51646371
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,561 @@ title: Events
# Events
-> Cordova lifecycle events.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51646137
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,561 @@ title: Events
# Events
-> Cordova lifecycle events.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/480#issuecomment-178857041
@riknoll Added link to Android Life Cycle Guide
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51643532
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-medic/pull/74#issuecomment-178850170
@dblotsky Yes. We have seen the timeouts 4 times last week. I was able to
connect to the VM (and get the same results) right at the same time it was
failing in
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51643217
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/74#discussion_r51643160
--- Diff: lib/testcheck.js ---
@@ -21,22 +21,40 @@
"use strict";
-module.exports = function (sha, dbHost) {
+module.exports =
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51643080
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51642981
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -45,207 +45,356 @@ passively copied into various `platforms/`
subdirectories, for example:
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51642666
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51642563
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51642289
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51642241
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/480#issuecomment-178844879
Resume event should add an Android quirk that points to this page:
http://cordova.apache.org/docs/en/dev/guide/platforms/android/lifecycle.html
---
If your projec
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/480
CB-10351: Make Events page a reference
Made the Events page a reference
@nikhilkh @dblotsky @rakatyal @riknoll @omefire Can you please review and
merge this PR?
You can merge thi
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51638568
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51638474
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51638042
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51637888
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51637838
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file
existed at `app/www/config.xml`,
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/463#issuecomment-178829332
@omefire I noticed you merged this without squashing - please do that in
the future it helps with maintaining a meaningful history on git.
https://github.com/apac
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/147#issuecomment-178816734
+1
Windows 8.0 has been deprecated since Apr 13, 2015, let's cleanup so we can
provide better focus.
---
If your project is set up for it, you can re
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51631675
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -45,207 +45,356 @@ passively copied into various `platforms/`
subdirectories, for example:
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51631119
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -45,207 +45,356 @@ passively copied into various `platforms/`
subdirectories, for example:
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51630971
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -22,8 +22,8 @@ title: The config.xml File
# The config.xml File
--- End diff --
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/463#discussion_r51630990
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -45,207 +45,356 @@ passively copied into various `platforms/`
subdirectories, for example:
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178801188
@dblotsky I don't think there is an easy way to get the running simulator,
so instead I am going to move the simulator choosing logic from `cordova run`
to medic a
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/463#issuecomment-178799405
I'm fine with using "Required" instead of "Required: true", as long as
other docs get updated to use this convention.
---
If your project is set up for it, you c
Github user yjukaku commented on the pull request:
https://github.com/apache/cordova-ios/pull/104#issuecomment-178796116
@edewit Can you please clarify what you mean? To be able to use CocoaPods,
we still need a workspace to be generated instead of a project with a
sub-project.
---
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/479#issuecomment-178764725
@riknoll Fixed the spacing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/479#discussion_r51617878
--- Diff: _config.yml ---
@@ -9,6 +9,7 @@ title: Apache Cordova
title_suffix: "Apache Cordova"
url:"https://cordova.apac
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/479
CB-10503: Documentation link points to 'latest' version even in latest buils
Fixed the link to point to dev version of the docs in development
@dblotsky @riknoll @rakatyal @nikhilkh
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-lib/pull/368#issuecomment-178759702
@vladimir-kotikov Can you please review and merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-lib/pull/368#issuecomment-178758457
@riknoll Can you merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-docs/pull/478
CB-10481 Update the docs according to windows8 deprecation
[Jira issue](https://issues.apache.org/jira/browse/CB-10481)
You can merge this pull request into a Git repository by running:
$
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/371
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/371#issuecomment-178623860
Tested this, and it seems to work fine. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Thanks for testing.
Did you try with my index.html? do the red boxes always appeared on the app
corners?
CB-10288 is about webview not resizing correctly in multitasking screens
(Split View - Slide Over)
2016-02-02 3:15 GMT+01:00 Carlos Santana :
> Julio I tested on my iPad Air 2 used ios@4.0.1 t
+1 - I would start from identifying weak places - important
functionality/methods which are not covered or coverage is low.
This is not just one magic coverage number - this is about what functionality
is covered and what is not.
-Sergey
-Original Message-
From: Carlos Santana [mailto:c
+1 This is cool tech to add to our project
It shows more transparency which for me I'm all in
!!
It should make it easier when troubleshooting or fixing bugs, it goes one
step forward from adding a test when a bug is found
Also seeing how a PR affects coverage interesting info to see sometimes.
L
Github user davetayls commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-178571365
Thanks Tim, looks good. Are you able to close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/369#issuecomment-178564407
@dblotsky, is this good to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-178561020
Because we've been logging these events all the time before cordova
refactoring. Many of these events doesn't have much value though, and could be
safely
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/464
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-178555686
@vladimir-kotikov I guess my point is: why is it necessary for internal
`cordova-common` events to reach platform code?
---
If your project is set up for it, you
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/464#issuecomment-178554331
@nikhilkh Fixed. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-178554295
@dblotsky, @purplecabbage, thanks for feedback. Agree, this probably smells
fishy. However, the only one option i see apart from this one is to setup a
pro
This is not only about visualization.
Codecov also stores previous result and performs an analysis, how coverage has
changed. Take a look at the comment, made by codecov bot at the PR:
https://github.com/vladimir-kotikov/cordova-lib/pull/2
-
Best regards, Vladimir
-Original Message-
Fro
I vote +1.
* Verified archives via `coho verify-archive`
* Verified tag manually
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully built and ran
* Verified that platform can be updated from previous version
* Verified compatibility with core pl
Please review and vote on the InAppBrowser plugin release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10505
The plugin has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10505/
The pa
Is this basically just adding a UI then?
Kindly,
Dmitry
> On Feb 1, 2016, at 11:48 PM, Vladimir Kotikov (Akvelon)
> wrote:
>
>> What is the impact to our workflow? are we just adding a node dependency, or
>> are there other config/integration parts that we need to do?
> The only thing, requir
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-lib/pull/369#issuecomment-178526013
Ah, it seems like I'm the one that's confused. I didn't know that
`progress` was a standard promise function. Returning `child` is what I meant,
but that would bas
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/477#issuecomment-178520738
@zhangkaizhao before we merge, please also add this to the Makefile.
---
If your project is set up for it, you can reply to this email and have your
reply appear
1 - 100 of 107 matches
Mail list logo
