[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-175442601 Hi @biasmv - I'll take a look and respond today or tomorrow, thank you for clarification --- If your project is set up for it, you can reply to this email and

Doing some late night work, and I found this

http://developer.android.com/reference/android/webkit/WebMessage.html I'm curious as to how this works in comparison to our current method of passing something back from native to the browser and whether this would be faster/cleaner. This would be Android WebView specific, and only would work on

[GitHub] cordova-windows pull request: CB-10440 Add CSS color names support...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/142#discussion_r50944308 --- Diff: template/cordova/lib/AppxManifest.js --- @@ -374,6 +374,11 @@ AppxManifest.prototype.getCapabilities = function () { }; fun

Re: [DISCUSS] Cordova Style Guide

Ryan, Thanks for your kind words of encouragement. I have just uploaded my documentation style guide with comments to JIRA CB-10448 . Please let me know what you think. Regards Rob Regards *Rob Posener* 0419 012 627 On 27 January 2016 at 14:06, Ry

RE: [DISCUSS] Cordova Style Guide

Rob, Your proposal makes total sense and I'd, personally, be happy for you to start with a revitalized style guide. To encourage frequent updates to the docs, our process to-date has been intentionally light-weight. I think one concern among the community will be: if there's overhead for docu

Re: [GitHub] cordova-windows pull request: CB-10440 Add CSS color names support...

Or is it platform dependent (ie, is the list of colours dependent upon the WebView implementation)? So, when the WebView is revised, it will take care of allowing new colours, instead of developers pointing the finger at Cordova for not keeping up-to-date with revised colour names? Rob Regards *

[GitHub] cordova-docs pull request: CB-10445: Documentation includes broken...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user RobPosener commented on the pull request: https://github.com/apache/cordova-docs/pull/465#issuecomment-175359061 1. First-person is preferred. 2. What is the purpose of the Overview page? a) Introduce new developers to Cordova? b) Quick reference/TOC for

[GitHub] cordova-windows pull request: CB-10440 Add CSS color names support...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/142#discussion_r50934617 --- Diff: template/cordova/lib/AppxManifest.js --- @@ -374,6 +374,11 @@ AppxManifest.prototype.getCapabilities = function () { }; fun

[GitHub] cordova-windows pull request: CB-10440 Add CSS color names support...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/142#discussion_r50934535 --- Diff: template/cordova/lib/AppxManifest.js --- @@ -374,6 +374,11 @@ AppxManifest.prototype.getCapabilities = function () { }; fun

Re: [DISCUSS] Cordova Style Guide

Gerday again, Thanks for the quick replies. I was already aware of the 3 links above (as I said, "I've been watching for a while"). I must not have been clear in in my email... So I'll be a little more precise, BEFORE any effort is expended on revamping the documentation, we need to agree what the

RE: [DISCUSS] Cordova Style Guide

Rob, I appreciate your enthusiasm. Cordova docs need a lot of improvement. We did a survey in October and 70% of negative comments focused on problems with our docs. Committers at Microsoft are pushing hard to improve the Cordova docs - but we need a lot of help from the community. We are usin

[GitHub] cordova-docs pull request: CB-10445: Documentation includes broken...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/468#issuecomment-175342026 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

RE: [DISCUSS] Cordova Style Guide

Rob, Any contributions you can provide would be most welcome... especially if you can help us apply that style guide to existing docs. We're making a big push to improve the documentation this year, but it's hard work and often gets prioritized below things like bug fixes to the actual framewor

Re: [DISCUSS] Cordova Style Guide

Gerday, Dmitry, I'm a bit of a documentation pedant. I have been "monitoring" Cordova development for a few months now, with the initial intent of wanting to contribute to improving the documentation (and then, perhaps to contributing to the code base). The thing that has struck me in this time is

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/465#issuecomment-175325394 1. In general, should we be using first-person or third-person voice in the docs? I realised halfway through the review that some pages use both, and it would be

[GitHub] cordova-android pull request: Clearing appPlugin when loading page...

GitHub user Dannysw opened a pull request: https://github.com/apache/cordova-android/pull/253 Clearing appPlugin when loading pages. When changing a page the appPlugin becomes stale, causing the "backbutton" and other events to no longer be passable from the CordovaWebView. By setti

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50928694 --- Diff: www/static/css-src/main.scss --- @@ -149,7 +149,6 @@ h1 { } h2 { color: $gray-50; -font-size: 18px; --- End dif

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50928163 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,55 @@ Use Apache Cordova if you are: device-level APIs, or if you want to dev

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50928062 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -27,9 +27,7 @@ to use standard web technologies such as HTML5, CSS3, and JavaScript for c

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50927949 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -27,9 +27,7 @@ to use standard web technologies such as HTML5, CSS3, and JavaScript for c

[GitHub] cordova-docs pull request: CB-10445: Documentation includes broken...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/468#issuecomment-175320142 @riknoll I've created [a JIRA][jira] for the styling. [jira]: https://issues.apache.org/jira/browse/CB-10448 --- If your project is set up for it, you ca

[GitHub] cordova-docs pull request: CB-10445: Documentation includes broken...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/468#issuecomment-175319613 @dblotsky Changed the links to reference style links --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[DISCUSS] Cordova Style Guide

Hey folks, I know we used to have a style guide on the wiki, but that seems long dead. I created a JIRA for a new Cordova-wide style guide, covering most of the languages we use (feel free to add others). The JIRA is here: https://issues.apache.org/jira/browse/CB-10448. Kindly, Dmitry

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/465#issuecomment-175315549 LGTM. Though I'm not well versed with the CSS structure to comment on the h2 change. --- If your project is set up for it, you can reply to this email and have y

[GitHub] cordova-docs pull request: CB-10445: Documentation includes broken...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/468#issuecomment-175315488 @dblotsky that would be nice, but we don't really do that in the rest of the docs. Might be worth a separate JIRA task. --- If your project is set up for it, you

[GitHub] cordova-docs pull request: CB-10445: Documentation includes broken...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/468#issuecomment-175315443 @nikhilkh we have a [JIRA for it][jira], but it's lower priority. [jira]: https://issues.apache.org/jira/browse/CB-10058 --- If your project is set up fo

[GitHub] cordova-docs pull request: CB-10445: Documentation includes broken...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/468#issuecomment-175315178 Suggestion: use [reference-style links][ref]. [ref]: http://daringfireball.net/projects/markdown/syntax#link --- If your project is set up for it, you ca

[GitHub] cordova-docs pull request: CB-10445: Documentation includes broken...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/468#issuecomment-175315035 LGTM. @rakatyal I remember we integrated a gulp command in docs build to find broken links - it might be a good idea to run it and fix all broken links. Also, we

[GitHub] cordova-docs pull request: CB-10445: Documentation includes broken...

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/468 CB-10445: Documentation includes broken github links Fixing broken links. @dblotsky @riknoll @nikhilkh @rakatyal Can you please review and merge this PR? You can merge this pull r

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/363#discussion_r50916949 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -122,25 +123,6 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/363#discussion_r50916728 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -440,6 +451,13 @@ function list(projectRoot, hooksRunner, opts) { }); } +functi

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/363#discussion_r50916413 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -507,3 +525,117 @@ function versionString(version) { return null; } + +/**

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/363#discussion_r50916227 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -440,6 +451,13 @@ function list(projectRoot, hooksRunner, opts) { }); } +funct

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/363#discussion_r50916134 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -122,25 +123,6 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-docs pull request: CB 10445 - Documentation includes broke...

Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-docs/pull/467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-docs pull request: CB 10445 - Documentation includes broke...

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/467 CB 10445 - Documentation includes broken github links @dblotsky @nikhilkh @riknoll Can you please review and merge this PR? You can merge this pull request into a Git repository by running:

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-cli/pull/232#issuecomment-175248507 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50899450 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to d

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50899388 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to d

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50899406 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to d

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50899424 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to d

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50899381 --- Diff: doc/compile.txt --- @@ -18,3 +20,8 @@ Builds the app for specified platforms, or all platforms --target ... De

[GitHub] cordova-mobile-spec pull request: CB-10439: Option for windows8 op...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50898933 --- Diff: doc/build.txt --- @@ -22,12 +22,11 @@ all/the specified platforms. --buildConfig... Use the specified build config

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50897041 --- Diff: doc/cordova.txt --- @@ -1,14 +1,11 @@ Synopsis - --- End diff -- Good point - added! --- If your project is set up for

[GitHub] cordova-android pull request: Parse options correctly

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/248#issuecomment-175224220 This looks like a great fix to merge. @Mitko-Kerezov Did you get a chance to file the ICLA? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50897700 --- Diff: doc/plugin.txt --- @@ -4,41 +4,49 @@ Synopsis Manage project plugins -add || [...] . add specified plugins -

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50896722 --- Diff: doc/build.txt --- @@ -22,12 +22,11 @@ all/the specified platforms. --buildConfig... Use the specified build confi

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50897654 --- Diff: doc/plugin.txt --- @@ -4,41 +4,49 @@ Synopsis Manage project plugins -add || [...] . add specified plugins -

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50897541 --- Diff: doc/platform.txt --- @@ -4,48 +4,45 @@ Synopsis Manage project platforms -add [...].. add specified platf

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50897419 --- Diff: doc/platform.txt --- @@ -4,48 +4,45 @@ Synopsis Manage project platforms -add [...].. add specified platf

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50897339 --- Diff: doc/emulate.txt --- @@ -2,6 +2,6 @@ Synopsis cordova-cli emulate [PLATFORM...] [-- [platformopts]] -Alias for `cordova

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50897060 --- Diff: doc/cordova.txt --- @@ -24,16 +21,21 @@ Project Commands (including prepare && compile)

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50896685 --- Diff: doc/clean.txt --- @@ -6,3 +6,6 @@ Cleans the build artifacts for the specified platform, or all platforms by running platform-provided cl

[GitHub] cordova-mobile-spec pull request: CB-10439: Option for windows8 op...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/135#issuecomment-175216069 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50896043 --- Diff: doc/plugin.txt --- @@ -4,41 +4,49 @@ Synopsis Manage project plugins -add || [...] . add specified plugins -

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50895834 --- Diff: doc/plugin.txt --- @@ -4,41 +4,49 @@ Synopsis Manage project plugins -add || [...] . add specified plugins -

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50895798 --- Diff: doc/platform.txt --- @@ -4,48 +4,45 @@ Synopsis Manage project platforms -add [...].. add specified platfo

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50895529 --- Diff: doc/plugin.txt --- @@ -4,41 +4,49 @@ Synopsis Manage project plugins -add || [...] . add specified plugins -

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50895262 --- Diff: doc/cordova.txt --- @@ -1,14 +1,11 @@ Synopsis - --- End diff -- Maybe somewhere here, we should mention that the user can

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50895227 --- Diff: doc/platform.txt --- @@ -4,48 +4,45 @@ Synopsis Manage project platforms -add [...].. add specified platf

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50894956 --- Diff: doc/compile.txt --- @@ -18,3 +20,8 @@ Builds the app for specified platforms, or all platforms --target ... Dep

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/232#issuecomment-175210221 why 'cordova-cli' instead of 'cordova' ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50894618 --- Diff: doc/clean.txt --- @@ -6,3 +6,6 @@ Cleans the build artifacts for the specified platform, or all platforms by running platform-provided cle

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50894379 --- Diff: doc/build.txt --- @@ -22,12 +22,11 @@ all/the specified platforms. --buildConfig... Use the specified build config

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50894344 --- Diff: doc/emulate.txt --- @@ -2,6 +2,6 @@ Synopsis cordova-cli emulate [PLATFORM...] [-- [platformopts]] -Alias for `cordova-

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/232#discussion_r50894159 --- Diff: doc/cordova.txt --- @@ -24,16 +21,21 @@ Project Commands (including prepare && compile)

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/232#issuecomment-175208219 @Rakatyal could you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-cli pull request: Update help docs - add examples and make...

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-cli/pull/232 Update help docs - add examples and make them consistent You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-cli docsReword

[GitHub] cordova-docs pull request: Multi-level ToC Implementation

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/464#issuecomment-175184927 Looks like there are really two changes - use of relative links & multi-level TOC. It's hard to follow but I'm assuming only newer versions of the docs do get mul

[GitHub] cordova-docs pull request: Multi-level ToC Implementation

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/464#issuecomment-175183412 If an article does not have a URL do we make sure it does not show up in the displayed page? --- If your project is set up for it, you can reply to this email an

[GitHub] cordova-plugin-splashscreen pull request: CB-10422 Splashscreen di...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/77#issuecomment-175175486 I didn't try it out, but LGTM based on the code. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-windows pull request: CB-10394 Do not cache manifest file ...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/143#issuecomment-175167399 The fix seems correct and fixes the current symptom - I'm concerned that there are other ways/it's easy to make similar mistakes in the future. --- If your pr

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/461 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-windows pull request: CB-10394 Do not cache manifest file ...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/143#issuecomment-175166044 This design seems to be problematic - From what I understand, there are multiple places where we could be reading and writing a manifest. One of them caches th

[GitHub] cordova-lib pull request: CB-10432 Adds e2e test to protect agains...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/366#issuecomment-175143160 Thanks, Vlad! LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-docs pull request: CB-10440 Add CSS color names support fo...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/466#discussion_r50872339 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -167,6 +167,17 @@ all of them: + Applies to Windows. + +-

[GitHub] cordova-windows pull request: CB-10440 Add CSS color names support...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/142#issuecomment-175139980 Could you add a unit test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

Re: [DISCUSS] inAppBrowser plugin release

Nobody is blaming you, this things happen, you didn't see that code and nobody saw it was missing on the review (or nobody reviewed). We should add tests for this. loadstart is really important, it's used for auth or payment gateways (and probably other uses), where you usually have to provide a

Re: [DISCUSS] inAppBrowser plugin release

First of all, we should agree on what InAppBrowser does. It seems that people added way too much crap in it and we're stuck supporting an API that many maintainers are completely unaware about. When I "broke" the API, I sent a pull request and asked people to review it before I merged it in. I k

From Miss Esther Desmond,

>From Miss Esther Desmond,  Hello Dear,  Hope this mail meets you well, please permit me to introduce myself to you, I am Miss Esther Desmond. The Daughter of the late Mr. and Mrs. Michael Desmond from Ivory Coast Who was a famous cocoa merchant based here in Abidjan the Economic capital of Iv

[GitHub] cordova-plugin-inappbrowser pull request: Support for passing requ...

Github user Takkuz commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/115#issuecomment-175048797 This would be really useful, mostly on WP8, (if it will be possible) where file-transfer fails. --- If your project is set up for it, you can reply

RE: [Vote] Tools Release!

I vote +1. * Verified tags * Ability to install/uninstall Cordova * Ability to update Cordova * Ability to create blank app for Windows, WP8, Android * Ability to build/run apps * Reviewed release notes * Verified versions * Verified line breaks * Verified 'cordova serve' * Verified that browserif

[GitHub] cordova-android pull request: CB-10421 Fixes exception when callin...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/252 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android pull request: CB-10421 Fixes exception when callin...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-android/pull/252#issuecomment-175033258 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android pull request: CB-10421 Fixes exception when callin...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/252#issuecomment-175032613 @sgrebnov, could you please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-windows pull request: CB-10394 Do not cache manifest file ...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/143 CB-10394 Do not cache manifest file while getting package name This fixes [CB-10394](https://issues.apache.org/jira/browse/CB-10394) You can merge this pull request into a Git repo

[GitHub] cordova-lib pull request: CB-10432 Adds e2e test to protect agains...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/366 CB-10432 Adds e2e test to protect against future regressions This PR adds test to cover the regression, reported in [CB-10432](https://issues.apache.org/jira/browse/CB-10432) You can

[GitHub] cordova-plugin-inappbrowser pull request: CB-10428 Fix syntax erro...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-file pull request: CB-10419 cordova-plugin-file 4.0...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

RE: [DISCUSS] inAppBrowser plugin release

Looks like we don't have auto tests for InAppBrowser plugin at all. We should write sanity test to ensure plugin is successfully initialized at least (there is cordova.InAppBrowser.open method available). I also think that it is doable to write auto tests for main events (load start/stop, etc) a

[GitHub] cordova-plugin-inappbrowser pull request: CB-10428 Fix syntax erro...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/141#issuecomment-175004173 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-file pull request: CB-10419 cordova-plugin-file 4.0...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/157#issuecomment-175004106 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-android pull request: CB-10421 Fixes exception when callin...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/252 CB-10421 Fixes exception when calling run script with --help option See [CB-10421](https://issues.apache.org/jira/browse/CB-10421) You can merge this pull request into a Git reposi

[GitHub] cordova-plugin-splashscreen pull request: CB-10412 AutoHideSplashS...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/78 CB-10412 AutoHideSplashScreen "false" isn't taken in account on iOS [Jira issue](https://issues.apache.org/jira/browse/CB-10412) You can merge this pull request into a Git reposi

[GitHub] cordova-plugin-splashscreen pull request: CB-9516 Android SplashSc...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-splashscreen pull request: CB-9516 Android SplashSc...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/75#issuecomment-174954242 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-file pull request: CB-10419 cordova-plugin-file 4.0...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/157#issuecomment-174944041 You can review PR w/o space changes using `?w=1` param: https://github.com/apache/cordova-plugin-file/pull/157?w=1 --- If your project is set up for i

  1   2   >