[GitHub] cordova-lib pull request: The concat() method returns a new array.

2016-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/216 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: How does orientation work, and what is shouldRotateToOrientation?

2016-01-06 Thread julio cesar sanchez
Can you share the whole bug report? On iOS the rotation doesn't work unless you configure it on the config.xml The shouldRotateToOrientation javascript function is deprecated on cordova ios 4.x.x https://issues.apache.org/jira/browse/CB-5690 https://issues.apache.org/jira/bro

How does orientation work, and what is shouldRotateToOrientation?

2016-01-06 Thread Dmitry Blotsky
Hey folks, I’ve had a bug forwarded my way where a Cordova app wouldn’t switch orientation on iOS unless the following code was present: function onDeviceReady() { ... window.shouldRotateToOrientation = function (degrees) { return true; } ... }; Could someone please expl

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-01-06 Thread sahilrulzs
Github user sahilrulzs commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-169554517 Here you go: https://issues.apache.org/jira/browse/CB-10308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-js pull request: Fix CB-3785 - enable EventListener interf...

2016-01-06 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-js/pull/130#issuecomment-169514704 Interesting. I'm reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

Re: [DISCUSS] Core Plugins and Android API 23

2016-01-06 Thread Joe Bowser
I'm very against this idea because we've been burned by using reflection in the past. I also feel that this allows developers be terrible and to stick with older, more insecure versions of Cordova, which is the main reason I'm against it. I don't think that requiring API level 23 is a problem. Th

[GitHub] cordova-plugin-network-information pull request: Adding cell type ...

2016-01-06 Thread edparsons
Github user edparsons commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/36#issuecomment-169509389 Great, ok Jesse what are the next steps to getting this merged in? --- If your project is set up for it, you can reply to this email and ha

[DISCUSS] Core Plugins and Android API 23

2016-01-06 Thread Richard Knoll
Hey all, As has been very thoroughly discussed at this point, the cordova-android 5.0.0 update included breaking changes for plugins in response to the new permission model that Android Marshmallow introduced. Unfortunately, this means that our plugins that took advantage of the new permission

Re: [DISCUSS] Deprecate cordova-wp8

2016-01-06 Thread Steven Gill
Sent a PR adding a deprecation notice. When users try to cordova platform add, they will see a warning telling them wp8 has been deprecated and to use windows instead. The platform will still add for now. We can wait 6 months before removing support for it. https://github.com/apache/cordova-lib/pu

[GitHub] cordova-lib pull request: CB-10121 added deprecation notice for am...

2016-01-06 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/362 CB-10121 added deprecation notice for amazon-fireos and wp8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-lib CB-10

[GitHub] cordova-android pull request: Parse options correctly

2016-01-06 Thread Mitko-Kerezov
GitHub user Mitko-Kerezov opened a pull request: https://github.com/apache/cordova-android/pull/248 Parse options correctly Fix 1 Options have already passed through `nopt` module in the build file. Nopt successfully parses all options which results in `argv.remain` being an emp

[GitHub] cordova-android pull request: Parse options correctly

2016-01-06 Thread Mitko-Kerezov
Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-android/pull/248#issuecomment-169372671 Ping @vladimir-kotikov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-windows pull request: CB-10193 Add BOM to www files at bui...

2016-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-10303 Fixes build arguments parsi...

2016-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-10303 Fixes build arguments parsi...

2016-01-06 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/135#issuecomment-169325776 lgtm :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-docs pull request: Update index.md

2016-01-06 Thread gallasch
GitHub user gallasch opened a pull request: https://github.com/apache/cordova-docs/pull/451 Update index.md Mispelled cordova command You can merge this pull request into a Git repository by running: $ git pull https://github.com/gallasch/cordova-docs patch-1 Alternatively you

[GitHub] cordova-windows pull request: CB-10303 Fixes build arguments parsi...

2016-01-06 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/135#issuecomment-169303730 @sgrebnov, could you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-windows pull request: CB-10303 Fixes build arguments parsi...

2016-01-06 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/135 CB-10303 Fixes build arguments parsing This PR fixes the issuesfrom [CB-10303](https://issues.apache.org/jira/browse/CB-10303) You can merge this pull request into a Git repositor

Re: Introduction

2016-01-06 Thread Sean Kelly
Thanks. I submitted a pull request for CB-7786, was there anything I missed? SeanK > On Jan 4, 2016, at 11:48 AM, Shazron wrote: > > Welcome! Looking forward to contributions. Let us know if you need anything. > >> On Mon, Dec 28, 2015 at 3:43 PM, Sean Kelly wrote: >> Hi, >> >> My name is Se