[GitHub] cordova-plugin-file-transfer pull request: CB-9969 Filetransfer up...

2015-11-27 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/115#issuecomment-160229026 Hey @daserge, the comment about line 453 is still unresolved. According to the docs, we should be using `localFilePath`. --- If your project is

[GitHub] cordova-plugin-file-transfer pull request: CB-9969 Filetransfer up...

2015-11-27 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/115#discussion_r46073628 --- Diff: tests/tests.js --- @@ -450,7 +450,7 @@ exports.defineAutoTests = function () { expect(transfer.o

[Android] Oops...we screwed up in Cordova-Android 5.0.x

2015-11-27 Thread Joe Bowser
Hey So, I just came back from Android Dev Summit, and it turns out that we didn't figure out how to use the method shouldShowRequestPermissionRationale(). Here's the use case that we didn't figure out: If a user refuses a permission twice, they have the option of not showing the permission promp

[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...

2015-11-27 Thread nglrt
Github user nglrt commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-160208917 We'd be happy if this change gets merged... :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

Buildbot: buildslave cordova-windows-slave was lost

2015-11-27 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Fri Nov 27 15:33:01 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot htt

[GitHub] cordova-plugin-contacts pull request: CB-10094 Android: Fixed empt...

2015-11-27 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/91 CB-10094 Android: Fixed empty string comparison https://issues.apache.org/jira/browse/CB-10094 You can merge this pull request into a Git repository by running: $ git pull htt

[GitHub] cordova-plugin-contacts pull request: CB-3950 Do not replace custo...

2015-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: CB-6979 Don't create duplica...

2015-11-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/89#discussion_r46032879 --- Diff: src/ios/CDVContact.m --- @@ -1324,6 +1324,7 @@ - (NSObject*)extractPhotos NSMutableArray* photos = nil;