Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

2015-11-16 Thread Carlos Santana
+1 - Carlos @csantanapr > On Nov 16, 2015, at 9:24 PM, Steven Gill wrote: > > Need to do a patch release for Lib & CLI. > > Fixing these 3 issues: > https://issues.apache.org/jira/browse/CB-9976 > https://issues.apache.org/jira/browse/CB-9987 > https://issues.apache.org/jira/browse/CB-9975 >

[DISCUSS] Cordova CLI & LIB 5.4.1 Release

2015-11-16 Thread Steven Gill
Need to do a patch release for Lib & CLI. Fixing these 3 issues: https://issues.apache.org/jira/browse/CB-9976 https://issues.apache.org/jira/browse/CB-9987 https://issues.apache.org/jira/browse/CB-9975 Thoughts?

[VOTE] 3.8.2 WP8 Release

2015-11-16 Thread Steven Gill
Please review and vote on this 3.8.2 WP8 Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10012 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10012 The package was

[GitHub] cordova-plugin-file pull request: CB-8497 Fix handling of file pat...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser, iOS: Setti...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-docs pull request: CB-10015: Fixed the browse online link ...

2015-11-16 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/421#issuecomment-157235572 @dblotsky please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-docs pull request: CB-10013: Removed line wrapping of code...

2015-11-16 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/420#issuecomment-157235596 @dblotsky please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-docs pull request: CB-10017: Restored broken image in amaz...

2015-11-16 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/422#issuecomment-157235540 @dblotsky please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-docs pull request: Refactored the title prefix into a glob...

2015-11-16 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/423#issuecomment-157235514 @dblotsky please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-docs pull request: CB-10020: Indicated the latest version ...

2015-11-16 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/424#issuecomment-157235484 @dblotsky please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-docs pull request: CB-10020: Indicated the latest version ...

2015-11-16 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/424 CB-10020: Indicated the latest version in the docs version dropdown Adds "(Latest)" next to the latest version in the version dropdown You can merge this pull request into a Git repository by

[GitHub] cordova-plugin-inappbrowser pull request: Fix crash on browser win...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-inappbrowser pull request: add JIRA issue tracker l...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-docs pull request: Refactored the title prefix into a glob...

2015-11-16 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/423 Refactored the title prefix into a global prefix in _config.yml No JIRA since this is just a refactor. Moves all the title prefixes into the global _config.yml for consistency's sake and fixes

[GitHub] cordova-plugin-device-orientation pull request: add JIRA issue tra...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-docs pull request: CB-10017: Restored broken image in amaz...

2015-11-16 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/422#issuecomment-157205312 Maybe we could include a test script to find broken images as part of the deployment/release process? --- If your project is set up for it, you can reply to this

[GitHub] cordova-docs pull request: CB-10017: Restored broken image in amaz...

2015-11-16 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/422 CB-10017: Restored broken image in amazon fireos docs This restores a broken image link that was deleted as part of f90b9d66056349aa33480675f013ae9269823d8d. Clearly, this is a big problem wit

[GitHub] cordova-lib pull request: CB-9987 Reinstall plugins for platform i...

2015-11-16 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/344#issuecomment-157203021 Note the JIRA number in the title is incorrect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: CB-10015: Fixed the browse online link ...

2015-11-16 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/421 CB-10015: Fixed the browse online link for the issues mailing list You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs br

[GitHub] cordova-docs pull request: CB-10013: Removed line wrapping of code...

2015-11-16 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/420 CB-10013: Removed line wrapping of code blocks in docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs source-code-wr

Re: [DISCUSS] cordova-wp8 patch release 3.8.2

2015-11-16 Thread Steven Gill
https://issues.apache.org/jira/browse/CB-10012 On Sun, Nov 15, 2015 at 9:14 AM, Mefire O. wrote: > +1 > > On Nov 14, 2015, at 3:56 PM, Brett Rudd wrote: > > > > +1 > > > >> On Nov 14, 2015, at 4:45 AM, Sergey Grebnov (Akvelon) < > v-seg...@microsoft.com> wrote: > >> > >> +1 > >> > >> -Orig

Re: File-transfer on cordova-vm & CB-51 API: FileTransfer - Support PUT Method

2015-11-16 Thread Steven Gill
Published and updated readme On Mon, Nov 16, 2015 at 11:30 AM, Shazron wrote: > Sorry I thought it was still on nodejitsu per the README. Steve is > publishing it on the actual > > On Mon, Nov 16, 2015 at 11:24 AM, Shazron wrote: > > Done > > > > On Mon, Nov 16, 2015 at 1:25 AM, Sergey Shakhnaz

Re: File-transfer on cordova-vm & CB-51 API: FileTransfer - Support PUT Method

2015-11-16 Thread Shazron
Sorry I thought it was still on nodejitsu per the README. Steve is publishing it on the actual On Mon, Nov 16, 2015 at 11:24 AM, Shazron wrote: > Done > > On Mon, Nov 16, 2015 at 1:25 AM, Sergey Shakhnazarov (Akvelon) > wrote: >> Hello guys, >> >> Can anybody with corresponding access please pub

Re: File-transfer on cordova-vm & CB-51 API: FileTransfer - Support PUT Method

2015-11-16 Thread Shazron
Done On Mon, Nov 16, 2015 at 1:25 AM, Sergey Shakhnazarov (Akvelon) wrote: > Hello guys, > > Can anybody with corresponding access please publish the file-transfer test > server with these updates? > https://github.com/apache/cordova-labs/pull/8 > > The change is adding an endpoint for PUT metho

[GitHub] cordova-labs pull request: CB-51 API: FileTransfer - Support PUT M...

2015-11-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-labs/pull/8#issuecomment-157142610 Nodejitsu updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-labs pull request: CB-51 API: FileTransfer - Support PUT M...

2015-11-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-labs/pull/8#issuecomment-157138297 I'm on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: Added Klipfolio to showcase apps

2015-11-16 Thread elijahe
GitHub user elijahe opened a pull request: https://github.com/apache/cordova-docs/pull/419 Added Klipfolio to showcase apps You can merge this pull request into a Git repository by running: $ git pull https://github.com/elijahe/cordova-docs showcase-klipfolio Alternatively yo

[GitHub] cordova-plugin-whitelist pull request: Update whitelist version to...

2015-11-16 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/14#issuecomment-157131444 Thanks, Shaz! This is not needed now. Closing it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cordova-plugin-whitelist pull request: Update whitelist version to...

2015-11-16 Thread nikhilkh
Github user nikhilkh closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-file pull request: CB-8497 Fix handling of file pat...

2015-11-16 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/149#issuecomment-157128272 LGTM tested on android 5.1.1 + 6.0.0 and iOS 8.4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-file pull request: CB-8497 Fix handling of file pat...

2015-11-16 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/149#discussion_r44957285 --- Diff: src/windows/FileProxy.js --- @@ -256,7 +256,7 @@ function pathFromURL(url) { } }); -return path

[GitHub] cordova-plugin-file pull request: CB-8497 Fix handling of file pat...

2015-11-16 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/149#discussion_r44956740 --- Diff: src/windows/FileProxy.js --- @@ -256,7 +256,7 @@ function pathFromURL(url) { } }); -return path.

[GitHub] cordova-mobile-spec pull request: CB-9774 File Transfer download c...

2015-11-16 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/134 CB-9774 File Transfer download cdvfile fails [Jira issue](https://issues.apache.org/jira/browse/CB-9774) `` is neede for Android only. Playing video via `cdvfile` in video t

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: CB-9569 - Support and

2015-11-16 Thread tombell
Github user tombell commented on the pull request: https://github.com/apache/cordova-lib/pull/312#issuecomment-157087950 I created https://issues.apache.org/jira/browse/CB-10011 We have an Android platform as well in our project, so we cannot remove the ``. I would ra

[GitHub] cordova-lib pull request: CB-9569 - Support and

2015-11-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/312#issuecomment-157084235 The default configuration is ``. The ideal way is to remove that tag, and it shouldn't alter any ATS entries, but right now it adds it if it is missing (as a defaul

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

2015-11-16 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-157082948 Merged this to master: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;a=commit;h=cdeec1c59fd8fcfa9159ad733081ac93ec

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

2015-11-16 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-157075831 @jeroenv, I could not reproduce this on 4.0.3 device with DropBox as well; the repro steps I tried were the following: * Using camera plugin ma

[GitHub] cordova-lib pull request: CB-9987 CB-9987 Reinstall plugins for pl...

2015-11-16 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/344 CB-9987 CB-9987 Reinstall plugins for platform if they were installed with cordova@<5.4.0 Fix for https://issues.apache.org/jira/browse/CB-9976 More details at JIRA You can m

[GitHub] cordova-lib pull request: CB-9569 - Support and

2015-11-16 Thread tombell
Github user tombell commented on the pull request: https://github.com/apache/cordova-lib/pull/312#issuecomment-157049887 Is there a way to completely disable this? I don't like the configuration it generates as it nullifies our prior configuration will bad defaults. --- If your proje

[GitHub] cordova-plugin-whitelist pull request: Update whitelist version to...

2015-11-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/14#issuecomment-157020871 PR Not needed anymore since cordova-ios-4.x will have need of this plugin. --- If your project is set up for it, you can reply to this email and have y

[GitHub] cordova-mobile-spec pull request: CB-9972 - Remove iOS whitelist

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-ios pull request: CB-9972 - Remove iOS whitelist

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

cannot find module umask

2015-11-16 Thread avinash.anu
http://stackoverflow.com/questions/33733698/error-after-updating-npm-cordova [http://cdn.sstatic.net/stackoverflow/img/apple-touch-i...@2.png?v=73d79a89bded&a]

[GitHub] cordova-plugin-whitelist pull request: CB-9972 - Remove iOS whitel...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

2015-11-16 Thread convey-mane
Github user convey-mane commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156988289 @riknoll: > in general we try to be extra careful when we add platform-specific options to plugins another reason, we did this pull reque

[GitHub] cordova-docs pull request: Ajout de popvox.png

2015-11-16 Thread juspriet
Github user juspriet commented on the pull request: https://github.com/apache/cordova-docs/pull/386#issuecomment-156987915 Hello ! Do I have to make the all procedure again or can you merge my two different commits ? Thank you for your answer --- If your project is set up for it, yo

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

2015-11-16 Thread convey-mane
Github user convey-mane commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156984521 OK, just started a [discussion thread](http://callback.markmail.org/thread/5bjkv4ukymo6ybot). --- If your project is set up for it, you can reply to

[GitHub] cordova-lib pull request: CB-9981 path.parse only available on nod...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/340 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9981 path.parse only available on nod...

2015-11-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/340#issuecomment-156981607 Merged. Thanks, @apla --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Camera Plugin – iOS: new resizable cropping rectangle

2015-11-16 Thread Manfred Wühr
Hi all! Herewith I would like to propose a new feature for the camera plugin: On iOS there's only that very insufficient inflexible cropping square – compared to Android or WinMobile – which moreover obviously doesn’t work properly (see CB-9930, CB-2648). As we need a flexible, sizable rectangl

File-transfer on cordova-vm & CB-51 API: FileTransfer - Support PUT Method

2015-11-16 Thread Sergey Shakhnazarov (Akvelon)
Hello guys, Can anybody with corresponding access please publish the file-transfer test server with these updates? https://github.com/apache/cordova-labs/pull/8 The change is adding an endpoint for PUT method and relates to this commit: https://github.com/apache/cordova-plugin-file-transfer/comm

[GitHub] cordova-labs pull request: CB-51 API: FileTransfer - Support PUT M...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-labs/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is