Re: Who's interested on Cordova translation process ownership?

2015-11-03 Thread Andrey Kurdumov
Will setting up environment for building website. Then double-check translations. 2015-11-04 13:20 GMT+06:00 Steven Gill : > Lets do one with the upcoming tools release. Can you make sure the > translations are in? > > On Tue, Nov 3, 2015 at 7:30 PM, Andrey Kurdumov > wrote: > > > Since I work o

Re: Who's interested on Cordova translation process ownership?

2015-11-03 Thread Steven Gill
Lets do one with the upcoming tools release. Can you make sure the translations are in? On Tue, Nov 3, 2015 at 7:30 PM, Andrey Kurdumov wrote: > Since I work on Windows, and never upload source files to CrowdIn, - I > follow limited workflow which just download Russian language, but I > understa

[GitHub] cordova-plugin-file-transfer pull request: Failing iOS 4.0 test

2015-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-docs pull request: CB-9912 Adding blog post about iOS 3.9....

2015-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/408 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-file-transfer pull request: Failing iOS 4.0 test

2015-11-03 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/110 Failing iOS 4.0 test filetransfer.spec.6 was failing in 4.x branch of iOS because -1 was returned as length in a progress event. Modified the test to look for <1 instea

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-03 Thread Tommy-Carlos Williams
+1 to letting the OS handle it. > On 4 Nov 2015, at 12:44, Jesse wrote: > > I completely support the proposal! > > > @purplecabbage > risingj.com > >> On Tue, Nov 3, 2015 at 5:35 PM, Shazron wrote: >> >> BUMP. This is important, and is causing a lot of pain for our users. >> For example: >

Re: Who's interested on Cordova translation process ownership?

2015-11-03 Thread Andrey Kurdumov
Since I work on Windows, and never upload source files to CrowdIn, - I follow limited workflow which just download Russian language, but I understand that script very well, to mimic it on Windows. I notice that we long time don't do any release of the docs. 2015-11-03 23:28 GMT+06:00 Victor Sosa

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-03 Thread Jesse
I completely support the proposal! @purplecabbage risingj.com On Tue, Nov 3, 2015 at 5:35 PM, Shazron wrote: > BUMP. This is important, and is causing a lot of pain for our users. > For example: > https://github.com/jessemonroy650/top-phonegap-mistakes/blob/master/the-whitelist-system.md > > >

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-03 Thread Shazron
BUMP. This is important, and is causing a lot of pain for our users. For example: https://github.com/jessemonroy650/top-phonegap-mistakes/blob/master/the-whitelist-system.md On Mon, Nov 2, 2015 at 5:38 PM, Shazron wrote: > To view contents of the PR easily: > https://github.com/shazron/cordova-

[GitHub] cordova-windows pull request: Fixed a typo.

2015-11-03 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-windows/pull/131#issuecomment-153542673 Thanks for the PR @jerem! You actually helped reveal another bug that I just fixed: a36a2c6cb3f5fb7e7553f2531bf4cd1ba6a859bf. --- If your project is set up fo

[GitHub] cordova-windows pull request: Fixed a typo.

2015-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-plugin-file pull request: Fix default persistent file loca...

2015-11-03 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/146#issuecomment-153538034 @infil00p please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cordova-plugin-file pull request: Fix default persistent file loca...

2015-11-03 Thread jasongin
GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/146 Fix default persistent file location The default Android persistent file location should be "internal", as documented in the file plugin's README.md. The value was unintentionally cha

[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...

2015-11-03 Thread ghenry22
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153536161 @purplecabbage yep I have signed an ICLA and have already had a PR merged into the file plugin. I'll send you a direct message on slack with full

Re: [DISCUSS] Removal of unused iOS bridges

2015-11-03 Thread Shazron
Sent a PR https://github.com/apache/cordova-ios/pull/178 please review/comment etc On Thu, Oct 29, 2015 at 7:27 AM, julio cesar sanchez wrote: > +1, I first saw the bridges when looking into one issue but didn't know if > the user configures them or if it was something internal that changed on >

[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

2015-11-03 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/178 CB-9883 - Remove unused iOS bridges Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-9883 Alternativel

[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

2015-11-03 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-153517264 LGTM. Tested on an Android 6.0 device and on an Android 5.1.1 emulator and ran mobilespec. I'll merge this in at the end of the day. --- If your project i

[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...

2015-11-03 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153511867 Hi @ghenry22 ! This looks good, as do your other prs. Have you signed an iCLA? [1] It is hard to tell because you do not have your name on yo

[GitHub] cordova-plugin-file pull request: CB-7253: requestFileSystem fails...

2015-11-03 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/145#issuecomment-153502297 LGTM. I don't really know how to test this thoroughly because of the external storage stuff, but the code looks solid and mobilespec passes (on a marshmall

RE: Partnership with Google on App Indexing

2015-11-03 Thread Parashuram N
+1 to making this a plugin. I think folks in the community may be interested in helping creating the plugin. Is that what you are looking for ? -Original Message- From: Raymond Camden [mailto:raymondcam...@gmail.com] Sent: Friday, October 30, 2015 2:06 PM To: dev@cordova.apache.org Subj

Re: [Vote] 5.0.0 Android Release (attempt 2)

2015-11-03 Thread Joe Bowser
OK, was able to add the repo this way. Vote +1: * Tested with mobile-spec * Tested standalone * Tested with CLI * Ran coho verify-archive on the archive On Tue, Nov 3, 2015 at 1:16 PM Steven Gill wrote: > The wrappy error still exists on github due to the tag not being updated. > Blame apache

[GitHub] cordova-lib pull request:

2015-11-03 Thread rainergp
Github user rainergp commented on the pull request: https://github.com/apache/cordova-lib/commit/1b55e26bc5b234aa5c988291eee010607dba7c00#commitcomment-14167203 My environment: - OS X El Capitan - npm 3.3.6 - node 5.0.0 - cordova 5.3.3 And I'm still having the same

Re: [Vote] 5.0.0 Android Release (attempt 2)

2015-11-03 Thread Steven Gill
The wrappy error still exists on github due to the tag not being updated. Blame apache infra and the shitty solution to mirror instead of using github proper. You can see the difference. Git-wip: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=shortlog;h=refs/tags/5.0.0 Github: htt

Re: [Vote] 5.0.0 Android Release (attempt 2)

2015-11-03 Thread Joe Bowser
I vote -1 Android itself appears fine, but that stupid wrappy error is still present in cordova-common. Can we somehow remove cordova-common for this release, since it seems that PlatformAPI isn't working out right now. On Tue, Nov 3, 2015 at 9:04 AM Sergey Grebnov (Akvelon) < v-seg...@microso

Re: Adding Telemetry information to Cordova

2015-11-03 Thread Terence M. Bandoian
Could be useful. What exactly would be collected? Would it be optional? Any user identifiable information? -Terence Bandoian On 11/3/2015 2:31 AM, julio cesar sanchez wrote: I think it's a good idea to add it and it will help understand how people use cordova and find common problems that

RE: [VOTE] Tools Release (attempt 2)

2015-11-03 Thread Sergey Grebnov (Akvelon)
+1 * Verified ability to install/uninstall Cordova on Windows * Verified blank app could be created * Verified iOS, Android, Windows platforms could be added and built (iOS prepare only ) * Reviewed release notes * Verified cordova run --list -Sergey Grebnov -Original Message- From: Ste

[GitHub] cordova-ios pull request: CB-9836 Add .gitattributes to prevent CR...

2015-11-03 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/177#issuecomment-153459658 looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera pull request: CB-9910 android: Add permissio...

2015-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Who's interested on Cordova translation process ownership?

2015-11-03 Thread Victor Sosa
Well... That's pretty much it. For step 2 just make sure you're using the script (or something similar, maybe manual for the time being because the script is for Mac/Linux) in the doc translation document https://github.com/apache/cordova-coho/blob/master/docs/doc-translation-process.md Thank you

Re: Who's interested on Cordova translation process ownership?

2015-11-03 Thread Andrey Kurdumov
I think I have everything which I need for translation, I miss some parts of the process probably, but not sure which. So I list what I know and familiar with 1. CrowdIn translation (obivious :)) 2. Move changes from CrowdIn to github. 3. Overall process of docs generation 4. A bit of docs publishi

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-11-03 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-153422772 I have update the pull request to add support for taking the class name from the plugin.xml file. For plugins using one of the 2 existing naming conve

Re: [GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

2015-11-03 Thread Jesse
Post a picture that fails so we can verify. > On Nov 3, 2015, at 3:30 AM, jeroenv wrote: > > Github user jeroenv commented on the pull request: > > > https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153325389 > >@daserge I forgot to mention that this bug on

Re: [DISCUSS] Cordova-Windows Release

2015-11-03 Thread Jesse
+1 Sounds good. I want to test some of the recent line-ending gitattribute changes with AppStore submission, so a release would be the perfect test. > On Nov 2, 2015, at 11:18 PM, Sergey Grebnov (Akvelon) > wrote: > > If we agree to do a release: > > Most of the changes in master are bugfi

RE: [Vote] 5.0.0 Android Release (attempt 2)

2015-11-03 Thread Sergey Grebnov (Akvelon)
I vote +1 * Manually verified platform could be added, built and run using blank app * Ran Autotests (mobilespec) Thx! Sergey Grebnov -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, November 3, 2015 4:19 AM To: dev@cordova.apache.org Subject: [Vote] 5

[GitHub] cordova-plugin-splashscreen pull request: Fixed plugin name in the...

2015-11-03 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/39#issuecomment-153402469 You can also: 'cordova plugin add https://github.com/apache/cordova-plugin-splashscreen ' This will work with older tools, but other

[GitHub] cordova-plugin-splashscreen pull request: Fixed plugin name in the...

2015-11-03 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/39#issuecomment-153401796 Cordova -v To find out your version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-contacts pull request: [CB-9940] Adding namespace d...

2015-11-03 Thread piyushhari
GitHub user piyushhari opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/82 [CB-9940] Adding namespace declarations for m3 and uap to plugin.xml Adding namespace declarations for m3 and uap prefixes to plugin.xml so that its a valid XML. You can merge th

[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...

2015-11-03 Thread wilsonpinto360
Github user wilsonpinto360 commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-153372688 @arenddeboer :+1: same happened to me before :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-splashscreen pull request: Fixed plugin name in the...

2015-11-03 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/39#issuecomment-153362067 You are probably using an old version of cordova CLI that doesn't support NPM --- If your project is set up for it, you can reply to this emai

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-11-03 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-153361722 sounds good. thanks @stevengill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cordova-plugin-splashscreen pull request: Fixed plugin name in the...

2015-11-03 Thread adamsc64
Github user adamsc64 commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/39#issuecomment-153342811 Thanks for this @purplecabbage. Weird, I'm getting the following error when using the command provided. Any tips? Full disclosure: I don't

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

2015-11-03 Thread jeroenv
Github user jeroenv commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153325389 @daserge I forgot to mention that this bug only seems to happen with certain pictures you try to upload from Gallery/Dropbox/Google Drive. If you

[GitHub] cordova-ios pull request: CB-9836 Add .gitattributes to prevent CR...

2015-11-03 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/177 CB-9836 Add .gitattributes to prevent CRLF line endings in repos Updates gitattributes to common web project template to help git recognize binary files [Jira issue](https://issues.apa

[GitHub] cordova-plugin-camera pull request: CB-9942 Normalize line endings...

2015-11-03 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/133 CB-9942 Normalize line endings in Camera plugin docs Adds .gitattributes to ensure LF line endings in the repo [Jira issue](https://issues.apache.org/jira/browse/CB-9942) You

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

2015-11-03 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153290832 It does not reproduce on Android 4.0.3 device for me. --- If your project is set up for it, you can reply to this email and have your reply appear

Re: Adding Telemetry information to Cordova

2015-11-03 Thread julio cesar sanchez
I think it's a good idea to add it and it will help understand how people use cordova and find common problems that they might have 2015-11-02 23:13 GMT+01:00 Parashuram N : > Hey folks, > > One of the action items from the face to face meeting was about adding the > ability to the Cordova CLI to

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

2015-11-03 Thread mikaelkindborg
GitHub user mikaelkindborg opened a pull request: https://github.com/apache/cordova-docs/pull/410 Added Evothings Studio to Cordova Tools listing Request to add info about Evothings Studio to the Cordova Tools section of the Cordova home page. You can merge this pull request into a

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

2015-11-03 Thread jeroenv
Github user jeroenv commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153284532 @daserge You can reproduce the error on an Android device (4.1.2 or smaller) and use CrossWalk webview together with the file transfer plugin. --