RE: [DISCUSS] Cordova-Windows Release

If we agree to do a release: Most of the changes in master are bugfixes, but there is new Visual Studio 14 template (version update), Cumulative build and hosted environments support so I propose to do minor release (4.2.0) instead of patch (4.1.1). Thoughts? Thx! Sergey -Original Message-

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153275170 @jeroenv, I've tested `upload` with CrossWalk webview and have not found any issues. Is there any additional details on how this issue could be

[DISCUSS] Cordova-Windows Release

Hi guys, last Windows release was in August and there are important changes landed to repo master from that time including: * Better Windows 10 in hosted environment support * Create/prepare fixes for non-Windows env (Linux/OSX) * Cumulative build support (windows10 and windows 8.1) * Fixe

[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...

Github user arangas commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153221198 I see, I wasn't aware of that! I've tested this and looks good, cheers. It would be great to get this merged. --- If your project is set up for it, you ca

[VOTE] Tools Release (attempt 2)

Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9903 Tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9903/ The packages were publishe

[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...

Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153219744 added applicationStorageDirectory to defined paths and updated readme with relevant comments for this path. --- If your project is set up for it, you can

[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...

Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153219294 my understanding is that applicationStorageDirectory is a bit redundant. It is the same as the applicationDirectory but has a note that you can change to

[GitHub] cordova-lib pull request: CB-9935: Cordova CLI silently fails on n...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-153214572 Lets merge this in after the 5.4.0 release --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

To view contents of the PR easily: https://github.com/shazron/cordova-discuss/blob/da7af6606848a1b7d96f4d5ee5402360bf5fd53c/proposals/ios-whitelist-removal.md On Mon, Nov 2, 2015 at 5:36 PM, Shazron wrote: > PR sent: https://github.com/cordova/cordova-discuss/pull/27 > > On Mon, Nov 2, 2015 at 5:

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

PR sent: https://github.com/cordova/cordova-discuss/pull/27 On Mon, Nov 2, 2015 at 5:21 PM, Shazron wrote: > Sorry everyone -- I'm structuring it as a PR and will revert my > commits. Will be easier to comment that way > > On Mon, Nov 2, 2015 at 5:05 PM, Shazron wrote: >> https://github.com/cord

Re: [VOTE] Tools Release

I'm redoing the vote thread for tools and including the node 5.0.0 fix. https://github.com/apache/cordova-lib/pull/338 Vote has failed. Still not sure if this will go to the vote thread or discuss as they are all merged for me in gmail. On Fri, Oct 30, 2015 at 5:34 PM, Steven Gill wrote: > Ple

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

Sorry everyone -- I'm structuring it as a PR and will revert my commits. Will be easier to comment that way On Mon, Nov 2, 2015 at 5:05 PM, Shazron wrote: > https://github.com/cordova/cordova-discuss/blob/master/proposals/ios-whitelist-removal.md > > Comment here or there, etc. I've included flow

[Vote] 5.0.0 Android Release (attempt 2)

Please review and vote on this 5.0.0 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9922 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9922 The package w

Re: [Vote] 5.0.0 Android Release

I'm going to restart this vote due to a node_module (wrappy) not being included which makes adding platform fail via git. Vote has failed On Mon, Nov 2, 2015 at 11:33 AM, Joe Bowser wrote: > I vote +1 > * Ran coho verify-archive on the archive file > * Ran coho audit-license-headers over the re

[GitHub] cordova-lib pull request: CB-9935: Cordova CLI silently fails on n...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/338#issuecomment-153210032 I forgot to mention: I searched the codebase for other calls to Q.all(), and those 2 were the only places I found with this mistake; others are correctly passing a

[GitHub] cordova-lib pull request: CB-9935: Cordova CLI silently fails on n...

Github user axemclion commented on the pull request: https://github.com/apache/cordova-lib/pull/338#issuecomment-153209313 LGTM. I believe that we should do a quick release of the CLI with this, before we do an Android release --- If your project is set up for it, you can reply to th

[DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

https://github.com/cordova/cordova-discuss/blob/master/proposals/ios-whitelist-removal.md Comment here or there, etc. I've included flowcharts... tldr; remove the whitelist in cordova-ios-4.x. we are not good at security, let the OS handle it.

[GitHub] cordova-lib pull request: CB-9935: Cordova CLI silently fails on n...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/338#issuecomment-153208737 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...

Github user sencenan commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-153207385 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cordova-lib pull request: CB-9935: Cordova CLI silently fails on n...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/338#issuecomment-153207374 @stevengill or @vladimir-kotikov can you review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-9935: Cordova CLI silently fails on n...

GitHub user jasongin opened a pull request: https://github.com/apache/cordova-lib/pull/338 CB-9935: Cordova CLI silently fails on node.js v5 Cordova in a couple places was mis-using the Q.all() function from the Q promises library. That function expects an array (of values or

[GitHub] cordova-plugin-camera pull request: CB-9910 android: Add permissio...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/132#issuecomment-153200989 Yeah, I can add something to the quirks section of the README so that developers know what's going on, but that doesn't really help the end user. --- If

[GitHub] cordova-plugin-camera pull request: CB-9910 android: Add permissio...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/132#issuecomment-153199173 That permission request looks fine. I really wish we could communicate why we need the damn permission. --- If your project is set up for it, you can

[GitHub] cordova-plugin-camera pull request: CB-9910 android: Add permissio...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/132#issuecomment-153197998 @infil00p does this new permission request seem alright to you? We can remove it, but we will lose the EXIF data and filenames of images taken from the g

[GitHub] cordova-plugin-camera pull request: CB-9910 android: Add permissio...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/132 CB-9910 android: Add permission request for some gallery requests Fixes an issue where there were some permission requests missing when getting images from the PHOTOLIBRARY source. An

Re: [BUG] Windows and Android breaking on CI

Yeah I heard on slack from @tripod. Looks like node_modules is in .gitignore, therefore not all the modules were checked in but I didn't see any status for them. I am checking them in now and will most likely have to restart the android vote. On Mon, Nov 2, 2015 at 2:20 PM, Dmitry Blotsky wrote:

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-ios/pull/176 CB-9827 Implement and expose PlatformApi for iOS https://issues.apache.org/jira/browse/CB-9827 * Prepare and plugin management functionality has been moved from Lib to platform-ios

[DISCUSS] Improving Cordova Documentation

Hey folks, For the last few weeks, we have taken measures to get in touch with and understand the experiences of a Cordova user. We put up a survey which received > 900 responses and tried to understand the pain points of working with Cordova. As it was brought up in F2F as well, majority of th

[BUG] Windows and Android breaking on CI

Hey folks, Android on Windows is failing on CI because a module called ‘wrappy’ can’t be found. JIRA: https://issues.apache.org/jira/browse/CB-9938. Windows is failing on CI because test results are failing to download. JIRA: https://issues.apache.org/jira/browse/CB-9939. Kindly, Dmitry

Adding Telemetry information to Cordova

Hey folks, One of the action items from the face to face meeting was about adding the ability to the Cordova CLI to collect telemetry data. Folks said that they were not sure if Apache had any policies against it. I checked with legal-disc...@apache.org (and inc

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

GitHub user infil00p opened a pull request: https://github.com/apache/cordova-docs/pull/409 Update to plugin.md regarding Cordova-Android 5.0.x changes Also changed out-of-date debugging information. Also, the Android Permissions information was completely missing from the plugin d

[GitHub] cordova-docs pull request: Correct example of AppendUserAgent

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/406#issuecomment-153168651 Merged. Thank you for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: Correct example of AppendUserAgent

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/406 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [Vote] 5.0.0 Android Release

I vote +1 * Ran coho verify-archive on the archive file * Ran coho audit-license-headers over the relevant repos * Ran mobilespec on the repository On Mon, Nov 2, 2015 at 1:06 AM, Steven Gill wrote: > Please review and vote on this 5.0.0 Android Release > by replying to this email (and keep dis

Re: Who's interested on Cordova translation process ownership?

Thanks, Andrey, for stepping up. I think you know really well the translation process and you have access to CrowdIn, is there anything you want me to share with you? On Mon, Nov 2, 2015 at 9:05 AM Andrey Kurdumov wrote: > I could take care of that. Does not feel 100% prepared, but will want to

Re: [REVIEW] Cordova-ios 3.9.2 blog post

2 minor grammar issues, but besides that looks good to me. On Mon, Nov 2, 2015 at 4:15 AM, Vladimir Kotikov (Akvelon) wrote: > Please review and comment it here: > https://github.com/apache/cordova-docs/pull/408 > > - > Best regards, Vladimir > --

RE: [DISCUSS] Tools Release

Leo, I'll make sure to highlight it in the blog post On Nov 2, 2015 8:57 AM, "Treggiari, Leo" wrote: > Hi Steven, > > CB-9589: > > - CB-9589 added more warnings and added conversion step to fetch.js > - CB-9589 auto convert old plugin ids to new npm ids > > seems like an important change for user

RE: [DISCUSS] Tools Release

Hi Steven, CB-9589: - CB-9589 added more warnings and added conversion step to fetch.js - CB-9589 auto convert old plugin ids to new npm ids seems like an important change for users to understand. I.e. what exactly will happen when a user adds a plugin using an 'old', reverse domain name plugi

[GitHub] cordova-android pull request: CB-9831 CB-9835 Added e2e tests

Github user alsorokin closed the pull request at: https://github.com/apache/cordova-android/pull/232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

Re: Who's interested on Cordova translation process ownership?

I could take care of that. Does not feel 100% prepared, but will want to try. Miss first email. 2015-11-02 20:43 GMT+06:00 Victor Sosa : > Hello community. > > A friendly reminder. To those who want to take care of the Cordova > translation, please let me know. > > Thanks > > -- Forwarde

Fwd: Who's interested on Cordova translation process ownership?

Hello community. A friendly reminder. To those who want to take care of the Cordova translation, please let me know. Thanks -- Forwarded message - From: Victor Sosa Date: Thu, Oct 29, 2015 at 11:45 AM Subject: Who's interested on Cordova translation process ownership? To: dev@co

[REVIEW] Cordova-ios 3.9.2 blog post

Please review and comment it here: https://github.com/apache/cordova-docs/pull/408 - Best regards, Vladimir

RE: [VOTE] iOS 3.9.2 release

The vote has now closed. The results are: Positive Binding Votes: 3 Vladimir Kotikov Shazron Abdullah Sergey Grebnov The vote has passed. - Best regards, Vladimir. -Original Message- From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] Sent: Monday, November 2, 2015 9:28 AM

[GitHub] cordova-docs pull request: CB-9912 Adding blog post about iOS 3.9....

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/408 CB-9912 Adding blog post about iOS 3.9.2 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-9912

[GitHub] cordova-coho pull request: CB-9220 remove check that enforces comm...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-coho/pull/100#issuecomment-152973787 We don't. This check is not actual anymore after publishing cordova-common. Thanks, Steve, sorry for late response. --- If your project is set up for it,

[GitHub] cordova-coho pull request: Update tools-release-process.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request: Update tools-release-process.md

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/102 Update tools-release-process.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-40 Alternatively you can

[Vote] 5.0.0 Android Release

Please review and vote on this 5.0.0 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9922 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9922 The package w

[GitHub] cordova-coho pull request: Updated platform release process

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request: CB-9220 remove check that enforces comm...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request: Updated platform release process

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/101 Updated platform release process You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-39 Alternatively you ca

[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request: Added support for PATCH...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/86#issuecomment-152946317 [The docs](https://github.com/apache/cordova-plugin-file-transfer#filetransfer) should be updated as well. --- If your project is set up for it,