Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/143#discussion_r22919310
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-69861487
I cleaned up the merge conflict, and I believe it's now working again. I
had a bunch of issues upgrading my plugin (CDVCamera.m seemed to drop off the
list
Looking at our core plugins, several of them would break if we renamed this
file. For that reason, I think keep it as-is for now.
Here's my grep:
http://pastebin.com/dqvyiMLS
On Tue, Jan 13, 2015 at 7:30 PM, Josh Soref wrote:
> I'm not an Android developer, but I recently saw how the
> getPlu
Welcome Nikhil!
On Tue, Jan 13, 2015 at 4:59 PM, Steven Gill wrote:
> Welcome Nikhil!
>
> On Tue, Jan 13, 2015 at 1:56 PM, Nikhil Khandelwal >
> wrote:
>
> > Hi,
> > I am an engineering manager at Microsoft leading a team working on
> > Cordova. I have been following some of the discussions on
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22911133
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
This is done automagically by node on windows
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/57
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/143#discussion_r22909913
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
I'm not an Android developer, but I recently saw how the getPluginManager() ->
pluginManager change can be handled. I also know that it's possible to build
wrappers for interface changes.
I wouldn't be opposed to this change.
I'd probably ask for sample transition code so that people who wan
So, this was something that was brought up numerous times, but I think we
should probably discuss this at least one more time before we move to
finish off 4.0.x.
Given that we're breaking the API for CordovaWebView already, would it make
sense for us to call it a CordovaWebInterface instead? The c
This PR adds support for git-urls to 'cordova platform add' :
https://github.com/apache/cordova-lib/pull/148
Please, review.
Thanks,
Mefire
-Original Message-
From: Treggiari, Leo [mailto:leo.treggi...@intel.com]
Sent: Tuesday, January 13, 2015 8:18 AM
To: dev@cordova.apache.org
Subject
Github user whitecolor commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-69843977
Any comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22905510
--- Diff: bin/lib/update.js ---
@@ -0,0 +1,59 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or mor
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22905187
--- Diff: bin/lib/update.js ---
@@ -0,0 +1,59 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more con
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22905021
--- Diff: bin/lib/create.js ---
@@ -26,14 +26,11 @@ var fs = require('fs'),
ROOT= path.join(__dirname, '..', '..'),
check_reqs =
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r22904360
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -354,22 +359,94 @@ describe('add function', function () {
});
});
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r22900366
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -76,97 +77,94 @@ function add(hooksRunner, projectRoot, targets, opts) {
}
ret
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r22900311
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -354,22 +359,94 @@ describe('add function', function () {
});
});
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-69831696
please ensure there's a PR to update:
https://github.com/apache/cordova-cli/blob/38dd67242841dd2ec254f7f9f402f495f7a28f5b/doc/platform.txt#L20
---
If your projec
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22899820
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
this change looks like you replaced a *nix syml
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22899501
--- Diff: bin/lib/create.js ---
@@ -26,14 +26,11 @@ var fs = require('fs'),
ROOT= path.join(__dirname, '..', '..'),
check_reqs = re
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/148
CB-8239 Add support for git urls to 'cordova platform add'
CB-8239 Add support for git urls to 'cordova platform add'
These changes allow the following scenarios:
*users can is
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22899370
--- Diff: bin/lib/update.js ---
@@ -0,0 +1,59 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contr
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Welcome Nikhil!
On Tue, Jan 13, 2015 at 1:56 PM, Nikhil Khandelwal
wrote:
> Hi,
> I am an engineering manager at Microsoft leading a team working on
> Cordova. I have been following some of the discussions on the dev mailing
> list and love the energy of this project.
>
> I have already signed a
Hi,
I am an engineering manager at Microsoft leading a team working on Cordova. I
have been following some of the discussions on the dev mailing list and love
the energy of this project.
I have already signed and submitted the Apache ICLA. I have my first pull
request for the browser platform -
GitHub user jpchase opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/115
CB-8295 Enable CSP for mobile spec
- Uses a javascript include file to document.write a CSP tag on page
- Minor changes to test pages where need to comply with CSP (e.g. remove
inl
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-browser/pull/6
CB-8206: Browser platform: Add support for update
This change add supports for updating the browser platform. I ended up
deleting a couple of log messages from create as there is no way to r
Github user purplecabbage closed the pull request at:
https://github.com/apache/cordova-js/pull/90
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Firefox works on 2.3, and Chrome does not. It also depends on the device
On Tue, Jan 13, 2015, 12:20 PM Josh Soref wrote:
> Michal Mocny wrote:
> >... we aren't telling those individuals that they cannot use
> >their phones, we are telling developers that want to create new
> >applications for t
Michal Mocny wrote:
>... we aren't telling those individuals that they cannot use
>their phones, we are telling developers that want to create new
>applications for that target to either build mobile web, packaged native,
>or just stick to existing versions of cordova if really needed.
>
>I do not
Victor, I don't disagree with your observation that those phones serve a
purpose. But we aren't telling those individuals that they cannot use
their phones, we are telling developers that want to create new
applications for that target to either build mobile web, packaged native,
or just stick to
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/31#issuecomment-69810429
thank you @purplecabbage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/143#discussion_r22890354
--- Diff: framework/src/org/apache/cordova/HttpAuthRequestHandler.java ---
@@ -0,0 +1,30 @@
+/*
+ Licensed to the Apache Software Found
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/143#discussion_r22890349
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-globalization/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Left some comments
On Tue, Jan 13, 2015 at 12:49 PM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> +1 Could someone also take a look on the following pending PR and merge it
> before starting release if possible
>
> CB-8201 Add support for auth dialogs into Cordova Android
> https:/
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/143#discussion_r22887338
--- Diff: framework/src/org/apache/cordova/HttpAuthRequestHandler.java ---
@@ -0,0 +1,30 @@
+/*
+ Licensed to the Apache Software Founda
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/143#discussion_r22887184
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/143#discussion_r22887157
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -147,6 +147,17 @@ public void setAuthenticationToken(AuthenticationToken
authe
When I was implementing this I initially did add it as a '--local / -l'
option to the cli. My concern was that it requires the developer to have a
global installation of Cordova even if all they want is the local command.
And assuming the user's global and local installs have different version
numb
Those are the exact people the Android One program is meant to target. I
rounded up when I stated the price of these devices.
On Tue Jan 13 2015 at 10:42:38 AM Victor Sosa
wrote:
> Well... Not trying to create a polemic here, but you can ask that to
> persons who earn $10USD a day, and yes, man
On Tue Jan 13 2015 at 10:42:38 AM Victor Sosa
wrote:
> Well... Not trying to create a polemic here, but you can ask that to
> persons who earn $10USD a day, and yes, many of these persons have a
> very-old-yet-cheap smartphone
>
> 2015-01-13 12:33 GMT-06:00 Joe Bowser :
>
> > Agreed. That would
Well... Not trying to create a polemic here, but you can ask that to
persons who earn $10USD a day, and yes, many of these persons have a
very-old-yet-cheap smartphone
2015-01-13 12:33 GMT-06:00 Joe Bowser :
> Agreed. That would mean that 3.7.x would be the last release where we
> support Androi
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/145#discussion_r22883426
--- Diff: cordova-lib/src/cordova/targets.js ---
@@ -0,0 +1,65 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or
Agreed. That would mean that 3.7.x would be the last release where we
support Android 2.3.x. I don't think that MozillaView is in a good enough
state for us to recommend that path to users. At this point, I can say
that the owners of these 78 million phones should buy a new phone. It's
not like
I agree, we're not really supporting these devices, and it is disingenuous
of the project to advertise that we do. Any apps concerning themselves with
privacy/security won't be targeting or testing on those devices either.
I think a clean break w/ the message 4.x === 4.x, coupled with many
webview
Does it really matter? I think Joe summarized it best, we can only claim
to support what is actually being supported (aka actively tested, actively
maintained). Market share doesn't impact that.
Not that we should not actively break 2.3 support, but with 3.7 on the
horizon, and big changes comin
+1 Could someone also take a look on the following pending PR and merge it
before starting release if possible
CB-8201 Add support for auth dialogs into Cordova Android
https://github.com/apache/cordova-android/pull/143
Thx!
Sergey
-Original Message-
From: agri...@google.com [mailto:agri
So, where are these numbers coming from? Can we get a breakdown by region?
On Tue Jan 13 2015 at 3:30:23 AM Marcel Kinard wrote:
> Another stat: Forbes estimates that the existing number of Android phones
> is 1.56 billion. Five percent of that is 78 million.
>
> > On Jan 13, 2015, at 1:14 AM,
GitHub user fabiomontefuscolo opened a pull request:
https://github.com/apache/cordova-lib/pull/147
Generate apk name
After update the phonegap for my app, the build always generate an APK file
named CordovaApp.apk. Is this a good way to solve this?
You can merge this pull request
Github user eymorale commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/57#issuecomment-69776455
The crash in spec "filetransfer.spec.25 should handle unknown host" was
caused in removeTargetFile. For spec25, the path at that point was an empty
GitHub user eymorale opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/57
CB-8296 add check at removeTargetFile to see if file exists
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eymorale/cordo
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/145#issuecomment-69772400
LGTM save the one comment!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/145#discussion_r22873213
--- Diff: cordova-lib/src/cordova/targets.js ---
@@ -0,0 +1,65 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or
I agree with always saving and automatically re-fetching sources and platforms
when needed. With regards to the other conversation going on re: automatic add
of a platform, I think the CLI should automatically do things when it is
reasonably unambiguous what the user wants - e.g. if they explic
+1
On Mon, Jan 12, 2015 at 6:04 PM, Shazron wrote:
> +1
>
> On Mon, Jan 12, 2015 at 12:15 PM, Steven Gill
> wrote:
> > Do it! +1
> >
> > On Mon, Jan 12, 2015 at 10:44 AM, Joe Bowser wrote:
> >
> >> Hey
> >>
> >> How do people feel about releasing 3.7.0 this week. I'm trying to give
> as
> >>
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Saving all the time certainly would make this simpler. If we save all of
the time, we can also make uninstall a part of prepare. E.g. If users edits
their config.xml and removes a , then prepare can detect that and
plugman uninstall it before building. If we don't always save, then editing
your con
Github user andjo commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/60#issuecomment-69746517
Any particular reason this isn't merged already? Updated documentation
perhaps?
It was the second thing after removing the location bar that I
Another stat: Forbes estimates that the existing number of Android phones is
1.56 billion. Five percent of that is 78 million.
> On Jan 13, 2015, at 1:14 AM, Ally Ogilvie wrote:
>
> moar stats:
> https://mixpanel.com/trends/#report/android_os_adoption/from_date:-365,to_date:0
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Hi,
Could someone review following changes before release?
https://github.com/apache/cordova-plugin-media-capture/pull/30
https://github.com/apache/cordova-plugin-camera/pull/62
-Maxim
On Tue, Jan 13, 2015 at 6:12 AM, Andrew Grieve wrote:
> Only concern is: https://issues.apache.org/jira/bro
GitHub user Zaspire opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/30
ubuntu: use content hub on device
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zaspire/cordova-plugin-media-capture mast
GitHub user Zaspire opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/62
ubuntu: use content hub on device
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zaspire/cordova-plugin-camera master
Alternativ
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-cli/pull/206
CB-8301 Added CI configuration files
JIRA Issue: https://issues.apache.org/jira/browse/CB-8301
You can merge this pull request into a Git repository by running:
$ git pull https://github
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-js/pull/100
CB-8300 Added CI configuration files
Jira issue: https://issues.apache.org/jira/browse/CB-8300
You can merge this pull request into a Git repository by running:
$ git pull https://github.
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-lib/pull/146
CB-8208 Made CI systems to get cordova-js dependency from gihub
JIRA issue: https://issues.apache.org/jira/browse/CB-8208
You can merge this pull request into a Git repository by running:
69 matches
Mail list logo
