[GitHub] cordova-app-hello-world pull request: update index.html and index....

2014-07-11 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-48788987 I'll wait for any possible "-1" and if none, I'm pushing it to master on Monday --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-inappbrowser pull request: CB-5109 - Windows 8 and ...

2014-07-11 Thread SomaticIT
GitHub user SomaticIT opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/52 CB-5109 - Windows 8 and 8.1 - InAppBrowser implementation In Windows 8.1, there is a new WebView control. It can be used to create an InAppBrowser implementation. h

[GitHub] cordova-plugin-inappbrowser pull request: CB-7123 - app needs to b...

2014-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: Pointing docs to edge

2014-07-11 Thread Andrew Grieve
Good point Ray. Another option would be to create a branch-per-component e.g. tools, android, ios, etc. that changes go into, and then merge into master from the branch that corresponds to the release that is happening On Fri, Jul 11, 2014 at 2:02 PM, Michal Mocny wrote: > Ray, but I thought w

Re: Verified Plugins Marketplace

2014-07-11 Thread Gorkem Ercan
On Fri, Jul 11, 2014 at 08:12:08AM -0700, Brian LeRoux wrote: > this would be a good time to talk about the federation capabilities in > Plugman and the Cordova/CLI then =) > > time for: > > `cordova registry add telerik http://plugins.telerik.com/ && cordova set > registry telerik` > > (or some

Re: Pointing docs to edge

2014-07-11 Thread Michal Mocny
Ray, but I thought we always wanted more cowbell? Sorry, had to. I agree with Ray here, but I would also want to see latest fixes to docs that apply to released version. Suggestion: rely on discipline to markup documentation changes which only apply to development versions? e.g. Now with more

RE: Pointing docs to edge

2014-07-11 Thread Ray Camden
Ok, so let me rephrase then. Imagine the next version of the CLI adds cowbell support: cordova cowbell --epic but this is NOT in the release version. If I go to docs.cordova.io, click on The Command Line Interface, will I see cowbell documented? If so, I think that is a mistake. _

[GitHub] cordova-plugin-globalization pull request: CB-7102 - Initial imple...

2014-07-11 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/17#issuecomment-48761078 @rodms10 I've been checking the plugin with this code: ``` navigator.globalization.getLocaleName( function(lang) {

[GitHub] cordova-plugin-inappbrowser pull request: CB-7123 - app needs to b...

2014-07-11 Thread rodms10
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/51#issuecomment-48760923 Looks good. r+ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-plugin-inappbrowser pull request: CB-7123 - app needs to b...

2014-07-11 Thread zalun
GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/51 CB-7123 - app needs to be privileged You can merge this pull request into a Git repository by running: $ git pull https://github.com/zalun/cordova-plugin-inappbrowser privil

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-11 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48759335 @agrieve Applying that patch to the 3.5.0 release fixes the issue completely. :) Y'all are amazing! --- If your project is set up for it, you can reply to

Re: Android Plugin API

2014-07-11 Thread Joe Bowser
We won't be breaking plugins. I don't want to move to this for the reasons stated before. This code also is way less maintainable, and looks like it could break easily. I really think that clarity should win out here over an abuse of java reflection. On 10 Jul,2014, at 17:15 , Anis KADRI wrote:

Re: Android: add support of min/max/target SDK to config.xml

2014-07-11 Thread Frederico Galvão
I'll elaborate on this topic on the next couple of days then and come back with a full feedback on this and folder structure + incremental builds next week. That'll give all of us time to think and get into flow again. 2014-07-10 23:46 GMT-03:00 Joe Bowser : > On 11 Jul 2014 00:22, "Frederico Ga

Re: Playing sound on Android does not respect system settings

2014-07-11 Thread Joe Bowser
Please file an issue in JIRA, otherwise we can't track it, and it'll be forgotten. On Jul 11, 2014 9:37 AM, "Andrew Grieve" wrote: > Makes sense to me! :) > > > On Fri, Jul 11, 2014 at 11:35 AM, Andrey Kurdumov > > wrote: > > > Hi guys, > > > > I have latest version of Media plugin on Android an

Re: Verified Plugins Marketplace

2014-07-11 Thread Marc Weiner
Very awesome Rob! Looking forward to using it! Marc On Fri, Jul 11, 2014 at 12:46 PM, Andrew Grieve wrote: > Looks really nice! Thanks Rob! > > Reason for forking is that they've cleaned them up a bit. E.g.: > https://github.com/Telerik-Verified-Plugins/BarcodeScanner/commits/master > > has ad

Re: Verified Plugins Marketplace

2014-07-11 Thread Andrew Grieve
Looks really nice! Thanks Rob! Reason for forking is that they've cleaned them up a bit. E.g.: https://github.com/Telerik-Verified-Plugins/BarcodeScanner/commits/master has added wp support, bug fix, better description On Fri, Jul 11, 2014 at 11:34 AM, Michal Mocny wrote: > ..you can install

Re: Pointing docs to edge

2014-07-11 Thread Max Woghiren
Yes, "Plugin APIs" links to a list of github docs. On Fri, Jul 11, 2014 at 12:39 PM, Andrew Grieve wrote: > Yeah, plugin docs are already gone from docs.cordova.io. This change is > strictly for guides & platform docs. The main motivation here is that it > doesn't make sense to have versioned d

Re: Pointing docs to edge

2014-07-11 Thread Max Woghiren
My understanding is that plugin docs live in plugin repos and will be versioned alongside the plugins themselves. They'll be removed from docs.cordova.io. On Fri, Jul 11, 2014 at 11:49 AM, Ray Camden wrote: > Is edge what people use when they get the latest version of cordova or a > plugin? If

Re: Pointing docs to edge

2014-07-11 Thread Andrew Grieve
Yeah, plugin docs are already gone from docs.cordova.io. This change is strictly for guides & platform docs. The main motivation here is that it doesn't make sense to have versioned docs if platform versions diverge anyways. It actually already makes little sense for the tools guides, since they ar

Re: Playing sound on Android does not respect system settings

2014-07-11 Thread Andrew Grieve
Makes sense to me! :) On Fri, Jul 11, 2014 at 11:35 AM, Andrey Kurdumov wrote: > Hi guys, > > I have latest version of Media plugin on Android and have following > behavior when playing sound. When playing sound it does not respect > settings which user set on their phone. For example when user

RE: Pointing docs to edge

2014-07-11 Thread Ray Camden
Is edge what people use when they get the latest version of cordova or a plugin? If not, I'd strongly argue against it. If I download the Camera plugin, I expect the default docs to match whats shipped in that version. From: m...@google.com on behalf of

Pointing docs to edge

2014-07-11 Thread Max Woghiren
Just wanted to bring back this conversation—how does everyone feel about switching docs.cordova.io to point to edge? There has been some discussion about cutting versioned docs after 3.5.0, and we're approaching a good time to do it. :)

Playing sound on Android does not respect system settings

2014-07-11 Thread Andrey Kurdumov
Hi guys, I have latest version of Media plugin on Android and have following behavior when playing sound. When playing sound it does not respect settings which user set on their phone. For example when user mute sound entirely, sounds still playing, when I lower volume of the sound, it is still pl

Re: Verified Plugins Marketplace

2014-07-11 Thread Michal Mocny
..you can install from specific branch/hash/subdir if you want to freeze without forking. -Michal On Fri, Jul 11, 2014 at 11:18 AM, tommy-carlos williams wrote: > Rob, > > Is there a reason the plugins are all forked to your org instead of being > listed from their original locations? > > Is i

Re: Verified Plugins Marketplace

2014-07-11 Thread tommy-carlos williams
Rob, Is there a reason the plugins are all forked to your org instead of being listed from their original locations? Is it to freeze the plugin in time to where it has been curated? On 12 July 2014 at 1:12:34, Brian LeRoux (b...@brian.io) wrote: this would be a good time to talk about the fe

Re: Verified Plugins Marketplace

2014-07-11 Thread Brian LeRoux
this would be a good time to talk about the federation capabilities in Plugman and the Cordova/CLI then =) time for: `cordova registry add telerik http://plugins.telerik.com/ && cordova set registry telerik` (or something like that) On Fri, Jul 11, 2014 at 7:51 AM, Rob Lauer wrote: > Hi Cor

Re: Verified Plugins Marketplace

2014-07-11 Thread Michal Mocny
Looks pretty snazzy. Thanks for the heads up. Appreciate that you provide Instructions for "Install plugin using Cordova CLI" very clearly. On Fri, Jul 11, 2014 at 10:51 AM, Rob Lauer wrote: > Hi Cordova Team, > > My name is Rob Lauer and I'm the Product Manager for AppBuilder here at > Teler

Verified Plugins Marketplace

2014-07-11 Thread Rob Lauer
Hi Cordova Team, My name is Rob Lauer and I'm the Product Manager for AppBuilder here at Telerik. I'm writing to let you know that we just released our brand new "Verified Plugins Marketplace" for custom Cordova plugins. It's available today, for free of course, at plugins.telerik.com

[GitHub] cordova-plugin-geolocation pull request: CB- 5114 Windows 8.1 - Us...

2014-07-11 Thread SomaticIT
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/18#issuecomment-48738910 Super, it looks great for me, Thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-11 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/55#discussion_r14822338 --- Diff: cordova-lib/src/hooks/ScriptsFinder.js --- @@ -0,0 +1,158 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-11 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/55#discussion_r14821829 --- Diff: cordova-lib/src/hooks/ScriptsFinder.js --- @@ -0,0 +1,158 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or mo

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-11 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/55#discussion_r14821551 --- Diff: cordova-lib/src/hooks/ScriptsFinder.js --- @@ -0,0 +1,158 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or

[GitHub] cordova-plugin-geolocation pull request: CB- 5114 Windows 8.1 - Us...

2014-07-11 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/18#issuecomment-48732503 Thx, Maxime. Updated commit as per your note. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-11 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/55#discussion_r14820487 --- Diff: cordova-lib/src/hooks/ScriptsFinder.js --- @@ -0,0 +1,158 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or mo

[GitHub] cordova-plugin-geolocation pull request: CB- 5114 Windows 8.1 - Us...

2014-07-11 Thread SomaticIT
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/18#issuecomment-48725418 Hi @sgrebnov, I added a note on the commit but it's only a little optimization. Apart from that, everything looks good for me !

[GitHub] cordova-plugin-geolocation pull request: CB- 5114 Windows 8.1 - Us...

2014-07-11 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/18 CB- 5114 Windows 8.1 - Use a new proxy as old geolocation methods is deprecated https://issues.apache.org/jira/browse/CB-5114 * Tested on Windows 8.0, Windows 8.1, Windo

RE: recent tools update, Splash screen support

2014-07-11 Thread Ray Camden
So basically the docs are *not* up to the date for any of this yet? From: Sergey Grebnov (Akvelon) Sent: Friday, July 11, 2014 1:15 AM To: dev@cordova.apache.org Subject: RE: recent tools update, Splash screen support I volunteer to test splash/icons s

RE: Proposal: hooks support for plugins

2014-07-11 Thread Sergey Grebnov (Akvelon)
Updated docs[1] as per review. Looking forward to community feedback regarding: 1 . Idea of defining hook scripts via config.xml and plugin.xml 2. New Script Interface for .js files (not used for /hooks scripts for backward compatibility) [1]https://github.com/apache/cordova-lib/pull/55 [2] http

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-11 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-48701880 Addressed docs review notes: deprecated .cordova/hooks directory --- If your project is set up for it, you can reply to this email and have your reply appear on Git