[GitHub] cordova-plugin-contacts pull request: example code onSucess functi...

2014-04-09 Thread huang-x-h
GitHub user huang-x-h opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/27 example code onSucess function error change navigator.contacts.length to contacts.length You can merge this pull request into a Git repository by running: $ git pull https://g

Re: [cordova-js] do we need , ?

2014-04-09 Thread Brian LeRoux
As they say: patches welcome. We didn't just pick Browserify without thinking this through: with code. From my perspective using an external tool focused on the problem that is battle hardened is better than maintaining our own and Browserify is the best of the bunch. I don't care if it has many d

Re: [cordova-js] do we need , ?

2014-04-09 Thread Anis KADRI
On Wed, Apr 9, 2014 at 4:55 PM, Jonathan Bond-Caron wrote: > On Tue Apr 8 03:50 PM, Andrew Grieve wrote: > > > > The question of whether we *need* them is not a good way to phrase it I > think. > > Rather: > > Pros? > > - Cordova doesn't pick a style of writing modules/plugins > - More control ov

[GitHub] cordova-coho pull request: added announcement blog post to tools r...

2014-04-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[ANNOUNCE] Released cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0, cordova-ios@3.4.1

2014-04-09 Thread Steven Gill
CLI, Plugman and cordova-ios have been released! You can view the release blog post at http://cordova.apache.org/news/2014/04/09/tools-ios-release.html. Tweet: https://twitter.com/apachecordova/status/454045980959047680

RE: [cordova-js] do we need , ?

2014-04-09 Thread Jonathan Bond-Caron
On Tue Apr 8 03:50 PM, Andrew Grieve wrote: > > The question of whether we *need* them is not a good way to phrase it I think. > Rather: > Pros? - Cordova doesn't pick a style of writing modules/plugins - More control over how plugin loading works Prefer this approach for now, might be a better

[GitHub] cordova-coho pull request: added announcement blog post to tools r...

2014-04-09 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/18 added announcement blog post to tools release instructions You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch

Re: [cordova-js] do we need , ?

2014-04-09 Thread Anis KADRI
On Wed, Apr 9, 2014 at 7:41 AM, Andrew Grieve wrote: > It's a change of semantics. We can't just dump them. I'll admit that the > syntax is confusing - we've already discussed making it a bit nicer and > there's an old bug for making it more obvious. > I think we should make them inexistant and

Re: CB-6415 [Blackberry] unable to add platform, using custom or local library

2014-04-09 Thread Josh Soref
I wrote: > BlackBerry has code in places which do a lot of `mixin` which would >Result in stuff like this working w/o requiring all the strange logic >that¹s currently scattered through multiple files. > I¹m going to probably try (unfortunately not until near the end of the > month) replace the me

Re: support on phonegap/cordova?

2014-04-09 Thread Andrew Grieve
StackOverflow works really well as well. If it's a possible but in the framework or an Apache plugin though, this is the list :) On Wed, Apr 9, 2014 at 6:21 AM, Ray Camden wrote: > I'd use the Google Group: https://groups.google.com/forum/#!forum/phonegap > _

Re: [VOTE] cordova-cli@3.4.1-0.1.0

2014-04-09 Thread Steven Gill
The vote has now closed! The results are: Positive binding votes: 3 Steven Gill Shazron Abdullah Andrew Grieve The vote has passed On Tue, Apr 8, 2014 at 6:45 PM, Andrew Grieve wrote: > +1 > verified checksum, sig, shrinkwrap.json > > > On Tue, Apr 8, 2014 at 12:50 PM, Shazron wrote: > > > +

Re: [VOTE] cordova-cli@3.4.1-0.1.0

2014-04-09 Thread Ian Clelland
+1 On Tue, Apr 8, 2014 at 8:45 PM, Andrew Grieve wrote: > +1 > verified checksum, sig, shrinkwrap.json > > > On Tue, Apr 8, 2014 at 12:50 PM, Shazron wrote: > > > +1 > > verified checksums, sig, tag hash > > > > > > On Tue, Apr 8, 2014 at 1:22 PM, Steven Gill > > wrote: > > > > > oops. The gi

Re: engines and plugins on config.xml

2014-04-09 Thread Gorkem Ercan
Agreed, I was thinking about making the version attribute optional which would basically signal CLI to create platforms with the latest&greatest platforms releases. -- Gorkem On Wed, Apr 9, 2014 at 12:45 PM, Michal Mocny wrote: > This would be a great contribution. > > We should consider using

[GitHub] cordova-plugin-camera pull request: Prevent NPE on processResiultF...

2014-04-09 Thread mgurreta
Github user mgurreta commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/22#issuecomment-40011123 Hi @agrieve, it would be great if you can review this PR. Thanks in advance. --- If your project is set up for it, you can reply to this email an

[GitHub] cordova-plugin-camera pull request: Prevent NPE on processResultFr...

2014-04-09 Thread mgurreta
Github user mgurreta commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/19#issuecomment-40010468 closing this, sending the PR to dev branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-camera pull request: Prevent NPE on processResultFr...

2014-04-09 Thread mgurreta
Github user mgurreta closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: Prevent NPE on processResiultF...

2014-04-09 Thread mgurreta
GitHub user mgurreta opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/22 Prevent NPE on processResiultFromGallery when intent comes null You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgurreta/cordova-

[GitHub] cordova-cli pull request: Move e2e tests into spec overwriting dup...

2014-04-09 Thread kamrik
GitHub user kamrik opened a pull request: https://github.com/apache/cordova-cli/pull/159 Move e2e tests into spec overwriting duplicate tests. Merging e2e tests into spec/ dir and removing the old duplicate tests as discussed in https://www.mail-archive.com/dev@cordova.apache.or

Re: Tools Release + cordova-ios 3.4.1 blog post proofread

2014-04-09 Thread Steven Gill
Just waiting on CLI vote to complete then I shall ship. On Apr 9, 2014 1:24 PM, "Shazron" wrote: > Looks good to me. Ship it? > > > On Wed, Apr 9, 2014 at 7:12 AM, Josh Soref wrote: > > > Steven Gill wrote: > > > Trying out piratepad for this. > > > > > > http://piratepad.net/UFpAfTg2HK > > > >

Re: Vibration API.

2014-04-09 Thread venkata kiran surapaneni
I can start with implementing those for Android. Is there any starting point which can provide with the pointers on how I can set up these plugins on eclipse/xcode etc along with the dependencies and test the changes ? On Wed, Apr 9, 2014 at 10:02 PM, Andrew Grieve wrote: > I haven't heard an

Re: Tools Release + cordova-ios 3.4.1 blog post proofread

2014-04-09 Thread Shazron
Looks good to me. Ship it? On Wed, Apr 9, 2014 at 7:12 AM, Josh Soref wrote: > Steven Gill wrote: > > Trying out piratepad for this. > > > > http://piratepad.net/UFpAfTg2HK > > Sorry for messing it up. In general, I like the PiratePad. It¹s going to > take me some time to get used to it. Normal

Re: report for april / pls review

2014-04-09 Thread Shazron
Off topic, but Apache has its own pastebin as well: https://paste.apache.org/ On Wed, Apr 9, 2014 at 9:28 AM, Andrew Grieve wrote: > Didn't know about s.apache.org. neat! > > Probably there were some plugin releases in there as well. Not sure if it's > important to list them all. To make accumu

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-09 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugman/pull/72#issuecomment-40002842 @jbavari Unrelated to this thread, you should add your name to github so readers of this thread can resolve jbavari == Josh Bavari, I was initially conf

[GitHub] cordova-plugin-file pull request: Add error codes.

2014-04-09 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/37#issuecomment-40001813 +1 It may be good to provide a better example of error handling as well. I would expect having a function like this that you could just copy into you

Re: engines and plugins on config.xml

2014-04-09 Thread Michal Mocny
(we should also support --searchpath for cordova create) On Wed, Apr 9, 2014 at 2:45 PM, Michal Mocny wrote: > This would be a great contribution. > > We should consider using the tag for plugins, which I think > maps well to existing specifications for urls and versions. > > For platforms, I'

Re: engines and plugins on config.xml

2014-04-09 Thread Michal Mocny
This would be a great contribution. We should consider using the tag for plugins, which I think maps well to existing specifications for urls and versions. For platforms, I'm fine with , though I don't like tieing to specific versions by default. I think we should support it, but my usual reaso

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-09 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-plugman/pull/72#issuecomment-4544 The best thing would be to avoid the double naming altogether when the munge is generated, so that it's always config.xml or res/xml/config.xml. If that's possible

Re: [windows8 - CLI] Failed to install 'org.cordova.mobile-spec-dependencies'

2014-04-09 Thread Martin Gonzalez Glez
Yeah, that's what I've found, I've checked the main repository at apache.org, and I've found that it's outdated. https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;a=blob_plain;f=windows8/VERSION;hb=master Should I create a jira Issue and update it? or you can handle easier and quicker?

RE: [windows8 - CLI] Failed to install 'org.cordova.mobile-spec-dependencies'

2014-04-09 Thread Sergey Grebnov (Akvelon)
I think the action item here is to update version file in cordova-windows /master/. It is outdated. Encountered w/ the same issue testing windows8 master branch with Medic Sent from my Windows Phone From: Josh Soref Sent: ‎4/‎9/‎2014

Re: CB-6415 [Blackberry] unable to add platform, using custom or local library

2014-04-09 Thread Josh Soref
I wrote: > BlackBerry has code in places which do a lot of `mixin` which would >result > in stuff like this working w/o requiring all the strange logic that¹s > currently scattered through multiple files. > > I¹m going to probably try (unfortunately not until near the end of the > month) replace th

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-09 Thread jbavari
Github user jbavari closed the pull request at: https://github.com/apache/cordova-plugman/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-09 Thread jbavari
Github user jbavari commented on the pull request: https://github.com/apache/cordova-plugman/pull/72#issuecomment-39987478 I will close it @agrieve I have started looking into how the config_keeper is being used. I will try to figure it out still, however, I might not be as fast a

Re: engines and plugins on config.xml

2014-04-09 Thread Andrew Grieve
Gorkem - if you implement this you'll be my hero! vs is a bit weird, because is already a thing that exists right now that is meant to mean tags within it apply only to the platform is lists. E..g On one hand, you could throw a version in there, but given that you can have multiple tags

Re: Vibration API.

2014-04-09 Thread Andrew Grieve
I haven't heard anyone express interest in tackling those. If you want to take this on, I think that's great! On Tue, Apr 8, 2014 at 10:52 PM, Venkata Kiran wrote: > Hi, > > > > I believe there are several jira requests to make the > Vibration API compatible with the w3c spec. A

Re: report for april / pls review

2014-04-09 Thread Andrew Grieve
Didn't know about s.apache.org. neat! Probably there were some plugin releases in there as well. Not sure if it's important to list them all. To make accumulating this list easier, we could add a step to release process to append to a releases.txt file, or something along those lines? wdyt? Might

Re: [windows8 - CLI] Failed to install 'org.cordova.mobile-spec-dependencies'

2014-04-09 Thread Josh Soref
Martin wrote: > It seems that currentVersion ---> 3.3.0-dev > doesn't satisfied: > required version: 3.3.0 > > Is this an expected behavior? Yes, -dev is a prerelease and is less than non -blah

[windows8 - CLI] Failed to install 'org.cordova.mobile-spec-dependencies'

2014-04-09 Thread Martin Gonzalez Glez
Trying to install the latest plugins for Windows 8, the process stops because it doesn't fulfill the requirements. This is the output in the console: Failed to install 'org.cordova.mobile-spec-dependencies':Error: Plugin doesn't s upport this project's cordova version. cordova: 3.3.0-dev, failed v

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-09 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugman/pull/72#issuecomment-39983493 I did merge this in, but forgot to close it (@Josh, can you close it?). Mark - sounds like that's a better approach. Could you make the change? --- If yo

Re: engines and plugins on config.xml

2014-04-09 Thread Gorkem Ercan
I guess it could be platform as well. I put engine because that is what plugin.xml uses for its dependencies. -- Gorkem On Wed, Apr 9, 2014 at 10:01 AM, Sebastien Blanc wrote: > I had the same idea and I really love it > but why not "platform" instead of "engine" ? > > > > On Wed, Apr 9, 2014 at

Re: engines and plugins on config.xml

2014-04-09 Thread Sebastien Blanc
I had the same idea and I really love it but why not "platform" instead of "engine" ? On Wed, Apr 9, 2014 at 5:58 PM, Gorkem Ercan wrote: > Hi, > I would like to propose a couple of enhancements to the top level > config.xml that would enable us to recreate a project easily. > > (Note: the exa

Re: Update to docs.cordova.io Redirect Server

2014-04-09 Thread Michael Brooks
Added both Shazron and Andrew as collaborators! I've never been a collaborator on a Heroku instance, but I assume you'll have full deploy access and can run commands such as `$ heroku logs`. Let me know if you notice any shortcomings. Michael On Tue, Apr 8, 2014 at 1:09 PM, Marcel Kinard wrote

engines and plugins on config.xml

2014-04-09 Thread Gorkem Ercan
Hi, I would like to propose a couple of enhancements to the top level config.xml that would enable us to recreate a project easily. (Note: the examples below assumes a cdv namespace on config.xml) 1. engines tag : CLI could use this tag the reconstruct the platforms hence the platforms folder

[GitHub] cordova-plugin-inappbrowser pull request: CB-6360: Fix for crash o...

2014-04-09 Thread robinnorth
GitHub user robinnorth opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/37 CB-6360: Fix for crash on iOS < 6.0 CB-6360: Fix for crash on iOS < 6.0, as described at https://issues.apache.org/jira/browse/CB-6360 You can merge this pull request into a

Re: CB-6415 [Blackberry] unable to add platform, using custom or local library

2014-04-09 Thread Martin Gonzalez Glez
Agree, your config.json file it provides more properties. But in blackberry10_parser, as well as in config.js or at lazy_load those properties are completely ignored. According to those files, the most important data to retrieve is the URL, and get the platform name to use it with the platforms.js,

[GitHub] cordova-plugin-file pull request: Add error codes.

2014-04-09 Thread mattgrande
Github user mattgrande commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/37#issuecomment-39973865 +1. I couldn't find this documented anywhere! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

Re: Suggestions for a problem

2014-04-09 Thread Andrew Grieve
One nice thing about putting them in config.xml, is that we can separate them from plugins. e.g. Again though - with npm's JS api, we don't need a package.json to have npm do the fetching / caching / version checking for us. On Wed, Apr 9, 2014 at 6:51 AM, Andrew Grieve wrote: > The thi

Re: Suggestions for a problem

2014-04-09 Thread Andrew Grieve
The thing I don't want is platforms in *cli*'s package.json Introducing a new package.json for each app is something we could consider. I was just assuming we'd dump it into config.xml instead of creating a new file. *Either way*, we'd be using npm to do the work. On Tue, Apr 8, 2014 at 2:41 PM,

Re: Cordova g11n implementation - Changes proposal

2014-04-09 Thread Andrew Grieve
Proposal sounds good to me! On Tue, Apr 8, 2014 at 12:54 PM, Pascale Dardailler wrote: > Hello, > > The globalization implementation of getLocaleName and getPreferredLanguage > should return more consistent results across the different platforms, as > it is very difficult to implement globalized

Re: [cordova-js] pluginloader/modulemapper, cordova_plugins.js and script injection.

2014-04-09 Thread Andrew Grieve
Sorry - think I'm mixing up the threads. Totally agree that getting rid of runtime module loading is the goal here. cordova_plugins.js now includes a list of installed plugin IDs and their versions, so we'd want to keep that around and just concat it into cordova.js with everything else. modulema

Re: [cordova-js] do we need , ?

2014-04-09 Thread Andrew Grieve
It's a change of semantics. We can't just dump them. I'll admit that the syntax is confusing - we've already discussed making it a bit nicer and there's an old bug for making it more obvious. *But* - less code - no, now there's more code in every plugin. Less complexity? This is subjective. Is thi

RE: support on phonegap/cordova?

2014-04-09 Thread Ray Camden
I'd use the Google Group: https://groups.google.com/forum/#!forum/phonegap From: smo Sent: Wednesday, April 09, 2014 2:35 AM To: dev@cordova.apache.org Subject: support on phonegap/cordova? hi where must i post to get support on phonegap/cordova ios ? th

Re: Tools Release + cordova-ios 3.4.1 blog post proofread

2014-04-09 Thread Josh Soref
Steven Gill wrote: > Trying out piratepad for this. > > http://piratepad.net/UFpAfTg2HK Sorry for messing it up. In general, I like the PiratePad. It¹s going to take me some time to get used to it. Normally I edit in Mou.app. I naturally copy paste my entire file instead of trying to just copy the

Re: Fix for CB-4602

2014-04-09 Thread Ian Clelland
Hi Kiran! Thanks for the pull request -- I'll try to take a close look at it today. If you haven't committed to an Apache project before, then you will need to sign the Apache ICLA. (It's pretty simple, and I think you can even do it all online now) There are instructions online here: http://www.

[GitHub] cordova-plugin-file pull request: Add error codes.

2014-04-09 Thread cfjedimaster
GitHub user cfjedimaster opened a pull request: https://github.com/apache/cordova-plugin-file/pull/37 Add error codes. I find myself constantly checking the source code to see what each error code represents. I think this should be in the core doc. I'd like to actually add a bit mo

Re: [RESULT][VOTE] cordova-plugman@0.21.0

2014-04-09 Thread sebb
On 9 April 2014 02:21, sebb wrote: > On 9 April 2014 01:38, Andrew Grieve wrote: >> I suppose this will make it more obvious when voting has concluded, but it >> puts the result out of the actual vote thread. > > That's a pain - I'd not noticed that before. > > I'm a bit surprised that changing t

support on phonegap/cordova?

2014-04-09 Thread smo
hi where must i post to get support on phonegap/cordova ios ? thanks