GitHub user krichter722 opened a pull request:
https://github.com/apache/commons-fileupload/pull/13
FileItem.java: remove throwing of Exception
Indicating that an interface method throws Exception is overly broad and
hides design issues after inheritance changes.
You can merge
GitHub user krichter722 opened a pull request:
https://github.com/apache/commons-fileupload/pull/14
Add missing @Override annotations
@Override annotations help to detect architectural errors and respond
quicker to method changes. Unclear why the checkstyle configuration
Github user krichter722 commented on the issue:
https://github.com/apache/commons-fileupload/pull/14
> Thank you for your report. I used Eclipse'd clean up feature to implement
this change instead of applying this patch. Please verify and close.
NetBeans seems to f
Github user krichter722 commented on the issue:
https://github.com/apache/commons-fileupload/pull/13
In any previous situation users needed to catch `Exception`. Since both
exception extend `Exception` there's no case where they need to change any
Github user krichter722 commented on the issue:
https://github.com/apache/commons-fileupload/pull/14
I made a mistake during rebase, the results are identical.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user krichter722 closed the pull request at:
https://github.com/apache/commons-fileupload/pull/14
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user krichter722 commented on the issue:
https://github.com/apache/commons-fileupload/pull/13
> True, but what if I have a subclass of DiskFileItem that throws an
Exception? What happens at runtime?
Correct, I didn't think about that. I'm already glad, y
GitHub user krichter722 opened a pull request:
https://github.com/apache/commons-fileupload/pull/15
pom.xml: Remove tab characters
pom.xml contains a mixture of spaces and tab characters in order
to indent markup which is confusing. Spaces should be used instead where
Github user krichter722 closed the pull request at:
https://github.com/apache/commons-fileupload/pull/15
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user krichter722 commented on the issue:
https://github.com/apache/commons-fileupload/pull/13
> I run my FooDiskFileItem that throws an Exception (not an IOException).
How? If `DiskItem.write` doesn't throw `Exception` `FooDiskItem.write`
can't.
GitHub user krichter722 opened a pull request:
https://github.com/apache/commons-fileupload/pull/16
Use Apache Commons I/O in tests
Replace File.delete and File.mkdir with Apache Commons I/O's FileUtils
equivalent which throw IOException instead of returning false
GitHub user krichter722 opened a pull request:
https://github.com/apache/commons-fileupload/pull/17
Move static analysis plugins from reporting to build
Moving the static code analysis plugins maven-checkstyle-plugin and
maven-pmd-plugin from the reporting to the build section
GitHub user krichter722 opened a pull request:
https://github.com/apache/commons-exec/pull/1
making CommandLine.addArgument and CommandLine.addArguments fail on null
and empty arguments
Making CommandLine.addArgument and CommandLine.addArguments fail on null
and empty (for
Github user krichter722 commented on the issue:
https://github.com/apache/commons-collections/pull/21
A `.gitignore` should be agnostic to the editor or IDE devs use for the
project. Those files belong into `.git/info/excludes
14 matches
Mail list logo
