Re: [FileUpload] Major version 2

2023-08-14 Thread James Reeves
] thread > > > > > > (https://lists.apache.org/thread/ngyrssxndklltzkoqfqx4n780h4b5vwk) > > > > > > > > > > > > Gary > > > > > > > > > > > > > > - > > > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > [image: Backbase] <https://backbase.com/>*Eugene Grybinnyk* > Backend Developer · R&D Business Banking · Amsterdam > +31 (0) 62 992 3609 > -- James Reeves

[FileUpload] Concrete FileUpload class

2023-08-14 Thread James Reeves
r this deserves its own post, but I found that fileSizeMax may have an off-by-one error. In my tests for FileUpload 1.5, if I have a fileSizeMax of 9, and send a multipart item that is 9 bytes, it passes without an exception. However, in 2.0.0, I needed to increase the fileSizeMax to 10 in order

Re: [FileUpload] Concrete FileUpload class

2023-08-15 Thread James Reeves
Will do! On Mon, 14 Aug 2023, at 6:09 PM, Gary Gregory wrote: > Hi James, > > Thank you for your email. I think this should be two PRs against git > master, with unit tests of course ;-) > > HTH, > Gary > > On Mon, Aug 14, 2023, 12:50 PM James Reeves wrote: >

[IO] Unintuitive behavior in BoundedInputStream.onMaxLength

2023-08-15 Thread James Reeves
documentation could be modified to something like: > A caller has caused a request that would cross the {@code maxLength} > boundary. This includes reads that return end of stream. Therefore streams > whose length is exactly equal to maxLength will also trigger this method. -- James Reeves