[CSV] Thoughs on CSV-293 - Add support for multiple null String values

Hi All, There is a JIRA feature request ( https://issues.apache.org/jira/browse/CSV-293) for supporting multiple null strings, not just one. To be honest, I did not really know much about the mentioned CSVW definitions, but based on the comment in the ticket "Feel free to provide a PR on GitHub"

Re: [beanutils] BeanUtilsBean2 vs BeanUtilsBean, ConvertUtilsBean2 vs ConvertUtilsBean

Hi, While I'm still getting familiar with things here, I'd like to share my thoughts on this issue. In my view, version 2.0 typically signifies a break in backward compatibility, which makes the second solution—changing the supertype's behavior—acceptable. Given the existence of BeanUtilsBean2 and

Re: (commons-text) 01/04: Removed the final modifier from the static methods

Hi, It is true, that static methods can't be overridden in a subclass, however they can be hidden. So final keyword prevents method hiding. It also helps make the code explicit. Finally, the final keyword can slightly improve performance because the JVM should not check if the method is hidden or

Re: [VOTE] Release Apache Commons CSV 1.12.0 based on RC1

+1 I have tested this (on my laptop) with 'mvn' using: openjdk version "1.8.0_382" OpenJDK Runtime Environment (Temurin)(build 1.8.0_382-b05) OpenJDK 64-Bit Server VM (Temurin)(build 25.382-b05, mixed mode) Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) Maven home: C:\Program File

Re: [LANG] Normalizing StringUtils output

Hi, In my opinion it would be nice if all the methods do the same for the same null or empty string input and would be consistent, but... I won't change the existing API in the current 3.x version. So I think we should fix them only in 4.0. However, we should fix it in the Strings class, before it

Re: [validator] broken test on my build but ok on GH

I added my thoughts to the test refactoring in https://github.com/apache/commons-validator/pull/301 pull request. Regards, David Gary Gregory ezt írta (időpont: 2024. dec. 26., Cs, 16:36): > Thanks for the tip Sam! > > In git master, I just pushed using JUnit Pioneer instead of direct global >

Re: [VOTE] Release Apache Commons Text 1.13.0 based on RC1

+1 I have tested this (on my laptop) with 'mvn' using: Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: C:\Program Files\JetBrains\IntelliJ IDEA 2023.1\plugins\maven\lib\maven3 Java version: 1.8.0_322, vendor: Amazon.com Inc., runtime: C:\Users\sigee\.jdks\corretto-1.8.0_

Re: [ALL] CRLF line endings causing problems

Hi, If the LF is forced by anything (git config, gitattribute, checkstyle, etc), what will happen to the file based tests where there is a purposefully CRLF line ending, because the test covers a fixed issue that was specifically related to windows files. E.g. in CSV. I mean files here for example

Re: [validator] broken test on my build but ok on GH

ce I > can't build or consider creating a release candidate until this is > addressed. > > Gary > > On Wed, Dec 25, 2024, 4:31 PM Dávid Szigecsán wrote: > > > Hi, > > > > I checked it on Java 23 and seemed fine. > > > > [INFO] Running > org.a

Re: [validator] broken test on my build but ok on GH

Hi, I checked it on Java 23 and seemed fine. [INFO] Running org.apache.commons.validator.routines.CalendarValidatorTest [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.104 s -- in org.apache.commons.validator.routines.CalendarValidatorTest Apache Maven 3.9.9 (8e8579a9e7