Emanuel,
-1 you are duplicating code (again) as a one-off while adding the clutter
of a ternary expression (and unnecessary parentheses). It is much cleaner
to use canonical-like code from our low level Commons IO library we already
use elsewhere. There is no benefit to expanding this API call. Th
Hello Yuzhan,
I replied in one of the tickets where has been a discussion going on for a
while.
The use of an encoder or decoder should be optional as this would have a
possible negative effect on performance.
I am not sure we should consider flipping the processing and base it on an
input strea
There has been no revert from the committer since the -1 on October 24, so I
will revert. This affects 11 Java files. This will revert the copy and pasting
of code patterns over and over.
Gary
On 2024/10/24 21:17:41 Emmanuel Bourg wrote:
> Le 24/10/2024 à 21:05, Gary Gregory a écrit :
>
> > Uh
On Fri, 1 Nov 2024 at 14:22, Emmanuel Bourg wrote:
>
> Hi Gary,
>
> Le 01/11/2024 à 14:22, Gary D. Gregory a écrit :
> > There has been no revert from the committer since the -1 on October 24, so
> > I will revert. This affects 11 Java files. This will revert the copy and
> > pasting of code pat
From the sideline: I am also concerned about adding dependendcies in low level
libraries for replacing only a few lines of code.
From ASF policy perspective, the veto (-1) requires a technical explanation,
cf. https://www.apache.org/foundation/voting.html#Veto
"To prevent vetoes from being use
Hi Gary,
Le 01/11/2024 à 14:22, Gary D. Gregory a écrit :
There has been no revert from the committer since the -1 on October 24, so I
will revert. This affects 11 Java files. This will revert the copy and pasting
of code patterns over and over.
I don't understand your "copy pasting" argumen
Maybe it's time to start a separate discussion thread about the addition of the
three libraries to compress after 1.25?
Otherwise, I fear, that we will continue to see -1 and code reverts over and
over again because there seems to be no consensus here.
So maybe let's frame it as a discussiom th
Le 01/11/2024 à 20:04, Gary Gregory a écrit :
Emanuel,
-1 you are duplicating code (again) as a one-off while adding the clutter
of a ternary expression (and unnecessary parentheses). It is much cleaner
to use canonical-like code from our low level Commons IO library we already
use elsewhere. Th
Emanuel and all,
I see dependencies here and in other libraries a natural aspect of Java
development in that it helps reuse proven solutions, where bug fixes and
implementations are improved, while externalizing that cost to the library
which is otherwise born by the host code base.
Reusing a lib
On Fri, 1 Nov 2024 at 22:27, Gary Gregory wrote:
>
> Emanuel and all,
>
> I see dependencies here and in other libraries a natural aspect of Java
> development in that it helps reuse proven solutions, where bug fixes and
> implementations are improved, while externalizing that cost to the library
Le 01/11/2024 à 21:12, Richard Zowalla a écrit :
IMHO (from a consumer pov) the addition of >1mb of dependencies is unfortunate.
commons-codec 1.17.1354KB
commons-lang 3.17.0658KB
commons-io2.17.0504KB
Total: 1.5MB :(
Emmanuel Bourg
11 matches
Mail list logo
