Re: [IMAGING] Logging vs Throwing exceptions

2023-05-31 Thread Peter Hull
That whole class looks like it needs a bit of TLC (or Javadoc at least!) On Wed, 31 May 2023 at 06:49, Miguel Muñoz wrote: > > > In addition to logging and swallowing the exception, this method also then > returns null. This is also a bad practice. > > > > The caller has to check for null. One o

Re: [IMAGING] Logging vs Throwing exceptions

2023-05-31 Thread Gary Gregory
Miguel, Don't cut off the thread in the body of the email please. Gary On Wed, May 31, 2023, 01:49 Miguel Muñoz wrote: > > In addition to logging and swallowing the exception, this method also then > returns null. This is also a bad practice. > > ​ > > ​The caller has to check for null. One of

Re: Re: Release Commons Fileupload 1.4.1?

2023-05-31 Thread Maxim Solodovnik
Hello Gary, are there any news on release? :) On Mon, 24 Apr 2023 at 19:18, Maxim Solodovnik wrote: > > Thanks for the update! > > from mobile (sorry for typos ;) > > > On Mon, Apr 24, 2023, 17:33 Gary Gregory wrote: >> >> I am in the process of releasing commons-parent, then commons-io, then >

Re: [ALL] Eventually, soon, Java 11

2023-05-31 Thread Matt Sicker
How about using multi-release jars? That way we can include module-info files and version-specific additions while still supporting Java 8 for a while. It could require a newer Java compiler while still targeting the Java 8 bytecode version. — Matt Sicker > On Apr 23, 2023, at 08:46, Gary Grego

Re: Re: Release Commons Fileupload 1.4.1?

2023-05-31 Thread Gary Gregory
I want release commons-io again and then I should be able to get to fileupload 2, in the meantime, please test git master. Gary On Wed, May 31, 2023, 11:15 Maxim Solodovnik wrote: > Hello Gary, > > are there any news on release? :) > > On Mon, 24 Apr 2023 at 19:18, Maxim Solodovnik > wrote: >

Re: [ALL] Eventually, soon, Java 11

2023-05-31 Thread Gary Gregory
I prefer to lead a simpler life Matt ;-) MR jars are an abomination IMO. Gary On Wed, May 31, 2023, 11:51 Matt Sicker wrote: > How about using multi-release jars? That way we can include module-info > files and version-specific additions while still supporting Java 8 for a > while. It could re

Re: [ALL] Eventually, soon, Java 11

2023-05-31 Thread Glavo
Java 8 jars can include module-info.class even if they are not multi-release. Java 8 does not load module-info.class, so there is no need to use MR for isolation. I hope to make our components compatible with Java 8 for 2-4 years. During this period, we can compile module-info.java separately and

Re: [ALL] Eventually, soon, Java 11

2023-05-31 Thread Gary Gregory
All active components already are compatible with Java 8 (except one maybe). Gary On Wed, May 31, 2023, 15:29 Glavo wrote: > Java 8 jars can include module-info.class even if they are not > multi-release. > Java 8 does not load module-info.class, so there is no need to use MR for > isolation. >