Re: [COLLECTIONS] Trie subclassing

2023-05-03 Thread Claude Warren
I have a work around but not having to convert from binary representation to string would be handy. But it is not critical. I am also not sure that the API is documented all that well. Perhaps I should open a low level ticket that we can work on after 4.5 is released. On Sun, Apr 23, 2023 at 9:

Re: Volunteering

2023-05-03 Thread Miguel Muñoz
How are you coming with rewriting the unit tests? On Thu, Apr 13, 2023 at 1:05 PM Elric V wrote: > On 10/04/2023 22:31, Miguel Muñoz wrote: > > Elric, > >Did you take up Gary's "thankless" task of updating the tests for > Commons > > VFS? Because I'm looking for a volunteer task, and an oppo

Re: [CANCEL][VOTE] Release Apache Commons IO 2.12.0 based on RC1

2023-05-03 Thread Rob Tompkins
I was reading this release over yesterday. I’m still looking at the code changes generally. Cheers, -Rob > On May 2, 2023, at 7:31 PM, Gary Gregory wrote: > > Great review Alex, TY, I am canceling this vote and will reply to this > email with details. > > Gary > > On Tue, May 2, 2023, 12:14

Re: [CANCEL][VOTE] Release Apache Commons IO 2.12.0 based on RC1

2023-05-03 Thread Gary Gregory
Thanks Rob! Make sure you track git master as I am going through Alex's comments and pushing updates, I should be done tonight. Gary On Wed, May 3, 2023, 08:22 Rob Tompkins wrote: > I was reading this release over yesterday. I’m still looking at the code > changes generally. > > Cheers, > -Rob

Re: [CANCEL][VOTE] Release Apache Commons IO 2.12.0 based on RC1

2023-05-03 Thread Rob Tompkins
Cool sounds good. -Rob > On May 3, 2023, at 9:55 AM, Gary Gregory wrote: > > Thanks Rob! Make sure you track git master as I am going through Alex's > comments and pushing updates, I should be done tonight. > > Gary > > On Wed, May 3, 2023, 08:22 Rob Tompkins wrote: > >> I was reading this

Re: [VOTE] Release Apache Commons IO 2.12.0 based on RC1

2023-05-03 Thread Gary D. Gregory
Thank you for your detailed review, Alex. Please find my comments embedded below. On 2023/05/02 16:13:31 Alex Herbert wrote: > Validated signatures and checksums. > > Build from source tar.gz file using 'mvn verify site' with: > > Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584) >