You have to change the comment to match, as it is now wrong.
Gary
-- Forwarded message -
From: GitBox
Date: Fri, Oct 21, 2022, 21:35
Subject: [GitHub] [commons-text] kinow merged pull request #378: Bump
actions/upload-artifact from 3.1.0 to 3.1.1
To:
kinow merged PR #378:
UR
Thank you for your excellent investigation, Alex, and for finding and fixing
the missing Test annotations. Overall, we have 98% coverage.
Taking stock, I think that this is where we are, we have main 3 issues:
1) Compatibility of duplicate header behavior from version to version
2) Validation bu
This VOTE is canceled. I will roll an RC2 if we agree that git master is OK.
Gary
On 2022/10/22 12:56:40 "Gary D. Gregory" wrote:
> Thank you for your excellent investigation, Alex, and for finding and fixing
> the missing Test annotations. Overall, we have 98% coverage.
>
> Taking stock, I thi
On Sat, 22 Oct 2022 at 13:56, Gary D. Gregory wrote:
>
> Thank you for your excellent investigation, Alex, and for finding and fixing
> the missing Test annotations. Overall, we have 98% coverage.
:)
> Taking stock, I think that this is where we are, we have main 3 issues:
>
> 1) Compatibility
Thank you for the new tests Alex!
Here is one area that is easy to overlook: As Commons CSV has evolved, _not all
settings in CSVFormat_ apply to both writing and parsing. To wit, the existing
Javadoc for CSVFormat.getAllowMissingColumnNames(): "Gets whether missing
column names are allowed whe
On Sat, 22 Oct 2022 at 20:05, Gary D. Gregory wrote:
>
> Thank you for the new tests Alex!
>
> Here is one area that is easy to overlook: As Commons CSV has evolved, _not
> all settings in CSVFormat_ apply to both writing and parsing. To wit, the
> existing Javadoc for CSVFormat.getAllowMissingC
