Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

2022-09-20 Thread Alex Herbert
Hi Gary, I tried VFS. On my mac it did not pass the unit tests: [*ERROR*] *Errors: * [*ERROR*] * AbstractSftpProviderTestCase$SftpProviderTestSuite>AbstractTestSuite.run:239->AbstractTestSuite.lambda$run$0:234->setUp:235->AbstractTestSuite.setUp:268 ยป FileSystem Could not connect to SFTP server

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

2022-09-20 Thread Alex Herbert
Hi Gary, I have found part of the issue. I copied the default configuration for cyclone DX maven plugin [1] into the statistics project. This worked. The only difference between this config and the config in parent is: Default: bom CP: ${project.artifactId}-${project.version}-bom Unfortunate

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

2022-09-20 Thread Gary Gregory
Hi Alex, Thank you for the additional testing and reporting. As a baseline, the VFS git master build is green on macOS, Windows, and Linux using Java 8, 11, and 17: https://github.com/apache/commons-vfs/actions where the current latest CI build for git master is https://github.com/apache/commons-

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

2022-09-20 Thread Gary Gregory
Alex, I just saw you posted this last message. This will need more tweaking over time it seems. It's not clear to me if we can have a commons-parent that works generically for both single and multi-module projects for CycloneDX and/or SPDX. Gary On Tue, Sep 20, 2022 at 7:56 AM Alex Herbert wrote

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

2022-09-20 Thread Alex Herbert
Hi Gary, On Tue, 20 Sept 2022 at 12:59, Gary Gregory wrote: > > Maybe you had a random failure or were not running from the command > line. Some VFS tests won't run properly from IDEs because they depend > on the old VFS testing framework still in place that relies on some > JUnit 3 patterns. >

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

2022-09-20 Thread Gilles Sadowski
Hello. > [...] The installed bom has dependency > information collated from other modules which are not actually > dependencies. So the aggregation is bringing in dependencies incorrectly. > This makes the BOM incorrect. > [...] If that's the case, I suggest that this feature is disabled by defau

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

2022-09-20 Thread Alex Herbert
Hi, I have put together a simple project with a parent and two modules, each with their own dependencies. This has the same result in that the installed bom for each module includes the dependencies of the entire project reactor. When I change the goal from 'makeAggregateBom' to 'makeBom' then I