Re: [MATH][GENETICS][PR-199] Decision on use and customization of RNG functionality for randomization

2021-11-30 Thread Gilles Sadowski
Hi. Le mar. 30 nov. 2021 à 06:40, Avijit Basak a écrit : > > Hi All > > Please see my comments: > > >The provider returned from ThreadLocalRandomSource.current(...) should > >only be used within a single method. > -- I missed the context of the thread in my previous mail. Sorry for the >

[STATISTICS] Remove isSupportConnected from distribution interface

2021-11-30 Thread Gilles Sadowski
Hello. Sorry for being late, but the change[1] in commit d7c53ab3e05b09f2522f7b7ee78e96ad97defe95 impacts Commons Math: Method "isSupportConnected" is called in class "AbtractRealDistribution".[2] That class was ported to [STATISTICS] as "AbstractContinuousDistribution". So now there are code

Re: [STATISTICS] Remove isSupportConnected from distribution interface

2021-11-30 Thread Alex Herbert
On Tue, 30 Nov 2021 at 16:50, Gilles Sadowski wrote: > > Hello. > > Sorry for being late, but the change[1] in commit > d7c53ab3e05b09f2522f7b7ee78e96ad97defe95 > impacts Commons Math: Method "isSupportConnected" is called in class > "AbtractRealDistribution".[2] > That class was ported to [ST

Re: [STATISTICS] Remove isSupportConnected from distribution interface

2021-11-30 Thread Gilles Sadowski
Le mar. 30 nov. 2021 à 19:41, Alex Herbert a écrit : > > On Tue, 30 Nov 2021 at 16:50, Gilles Sadowski wrote: > > > > Hello. > > > > Sorry for being late, but the change[1] in commit > > d7c53ab3e05b09f2522f7b7ee78e96ad97defe95 > > impacts Commons Math: Method "isSupportConnected" is called i

Re: [STATISTICS] Remove isSupportConnected from distribution interface

2021-11-30 Thread Alex Herbert
On Tue, 30 Nov 2021 at 23:15, Gilles Sadowski wrote: > > > Side-note: Why wasn't the issue caught by Jenkins? > > > Commons Math is not listed as being dependent on it.[3] > > > > So should we update Jenkins to have math build on changes to > > Statistics, Numbers and RNG? > > Sure. I thought th

Re: [STATISTICS] Remove isSupportConnected from distribution interface

2021-11-30 Thread Gilles Sadowski
>> [...] > > > > Note that isSupportConnected is not used by anything in Commons Math > > either. > > OK, I missed that. So it's just a question of updating the code there. FTR: https://issues.apache.org/jira/browse/MATH-1636 Gilles >> [...]

Re: [ALL] Jenkins CI failures accessing gitbox.apache.org ...

2021-11-30 Thread Gilles Sadowski
Le jeu. 25 nov. 2021 à 01:35, sebb a écrit : > > In case this affects your builds: https://ci-builds.apache.org/job/Commons/job/commons-math/160/console > > Infra say to use github.com instead > Is there more info about why this happens now? Thanks, Gilles