[NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread sebb
As the subject says: FTPSClientTest fails with javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is disabled or cipher suites are inappropriate) when run with AdoptOpenJDK 8 & 11 However it works fine with the Oracle version of Java 8 & 11 @Gary Gregory : I think you wrote t

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread Gary Gregory
Hm, there might be some system property to set that says "use this old and now deprecated algorithm" or we might have to recreate any certificates used in tests with a current JDK 8. Gary On Mon, Jul 26, 2021, 08:42 sebb wrote: > As the subject says: FTPSClientTest fails with > > javax.net.ssl

Re: Create flow to only reflect selected fields on ReflectionToStringBuilder

2021-07-26 Thread Daniel Augusto Veronezi Salvador
Hello, is there any update about this? Best regards, Daniel Salvador On 08/07/2021 09:43, Daniel Augusto Veronezi Salvador wrote: Thanks for the reply Mark, I showed you parts of the snippet to avoid a long reply, but I think it turn it confusing. Here is the the full snippet (the comments

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread Bernd Eckenfels
You can enable the protocols (see link below) in the Java.security policy file, but in the long run it’s best to mainly test supported algorithms, maybe by conditionally checking it only if available, then a manual modified test environment can use the compatibility tests, (Btw I don’t think th

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread sebb
On Mon, 26 Jul 2021 at 15:18, Bernd Eckenfels wrote: > > You can enable the protocols (see link below) in the Java.security policy > file, but in the long run it’s best to mainly test supported algorithms, > maybe by conditionally checking it only if available, then a manual modified > test env

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread Bernd
Hello, > The test code appears to select TLSV1.2. https://github.com/apache/commons-net/blob/fd06a81fd4ea3ace33d397935c76a4e014088fa2/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java#L103 the test code seems to limit the client to TLS1 only. Not sure why it does that, if we remove

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread sebb
On Mon, 26 Jul 2021 at 17:43, Bernd wrote: > > Hello, > > > > The test code appears to select TLSV1.2. > > > https://github.com/apache/commons-net/blob/fd06a81fd4ea3ace33d397935c76a4e014088fa2/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java#L103 > > > the test code seems to limit the

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread Gary Gregory
The test still fails on Java 16. See my latest commit which does not fix it but at least creates current keystores for Java 8 and 16 using the current keystore format instead of the old deprecated JKS format . Gary On Mon, Jul 26, 2021, 19:18 sebb wrote: > On Mon, 26 Jul 2021 at 17:43, Bernd w

Re: [commons-net] 03/04: Some resources created with Java 8 cannot be used in Java 16. Provide scripts to create keystores for Java 8 up to Java 15, and for Java 16 and up. The FTPSClientTest class st

2021-07-26 Thread sebb
On Tue, 27 Jul 2021 at 00:35, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-net.git > > commit bdfbd0cc7294d9d7d494f4148722f5c5dce43eaa > Author: Gary Gregory

Re: [commons-net] 03/04: Some resources created with Java 8 cannot be used in Java 16. Provide scripts to create keystores for Java 8 up to Java 15, and for Java 16 and up. The FTPSClientTest class st

2021-07-26 Thread sebb
On Tue, 27 Jul 2021 at 01:17, sebb wrote: > > On Tue, 27 Jul 2021 at 00:35, wrote: > > > > This is an automated email from the ASF dual-hosted git repository. > > > > ggregory pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/commons-net.git > > > > commit bdf