Re: [apache/commons-codec] (doc) Remove duplicate "from"s in javadoc comments (#66)

Please update changes.xml when you merge a PR. Gary On Thu, Nov 26, 2020 at 9:08 AM Alex Herbert wrote: > Merged #66 into master. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it o

Re: [commons-codec] branch master updated: Track changes

May you please show the PR number in the description? See the first action in the list. This will give us better provenance for changes. TY! Gary On Thu, Nov 26, 2020 at 9:13 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > aherbert pushed a commit to branch m

Re: [commons-codec] branch master updated: Track changes

Hello. Le jeu. 26 nov. 2020 à 15:22, Gary Gregory a écrit : > > May you please show the PR number in the description? See the first action > in the list. This will give us better provenance for changes. At first thought, I don't see that this info belongs in the "changes" file. [Rationale: Displ

Re: [apache/commons-codec] (doc) Remove duplicate "from"s in javadoc comments (#66)

Hello Gary. Le jeu. 26 nov. 2020 à 15:09, Gary Gregory a écrit : > > Please update changes.xml when you merge a PR. Since when do we require that for Javadoc clean-up? Regards, Gilles - To unsubscribe, e-mail: dev-unsubscr...@

Re: [commons-codec] branch master updated: Track changes

Then do it because that's the "style" we've been using, just like we use the changes.xml "issue" attribute to refer to the associated Jira issue, but in this case it's not a Jira #, it's a PR#. Note that the Maven changes plugin does not know about PRs in that field, so we use the PR# in the descr

Re: [apache/commons-codec] (doc) Remove duplicate "from"s in javadoc comments (#66)

On Thu, Nov 26, 2020 at 9:43 AM Gilles Sadowski wrote: > Hello Gary. > > Le jeu. 26 nov. 2020 à 15:09, Gary Gregory a > écrit : > > > > Please update changes.xml when you merge a PR. > > Since when do we require that for Javadoc clean-up? > It's more about providing *transparency* and *document

Re: [apache/commons-codec] (doc) Remove duplicate "from"s in javadoc comments (#66)

Gary, Le jeu. 26 nov. 2020 à 15:47, Gary Gregory a écrit : > > On Thu, Nov 26, 2020 at 9:43 AM Gilles Sadowski > wrote: > > > Hello Gary. > > > > Le jeu. 26 nov. 2020 à 15:09, Gary Gregory a > > écrit : > > > > > > Please update changes.xml when you merge a PR. > > > > Since when do we require

Re: [apache/commons-codec] (doc) Remove duplicate "from"s in javadoc comments (#66)

On Thu, Nov 26, 2020 at 10:00 AM Gilles Sadowski wrote: > Gary, > > Le jeu. 26 nov. 2020 à 15:47, Gary Gregory a > écrit : > > > > On Thu, Nov 26, 2020 at 9:43 AM Gilles Sadowski > > wrote: > > > > > Hello Gary. > > > > > > Le jeu. 26 nov. 2020 à 15:09, Gary Gregory a > > > écrit : > > > > > >

Re: [apache/commons-codec] (doc) Remove duplicate "from"s in javadoc comments (#66)

Le jeu. 26 nov. 2020 à 16:04, Gary Gregory a écrit : > > On Thu, Nov 26, 2020 at 10:00 AM Gilles Sadowski > wrote: > > > Gary, > > > > Le jeu. 26 nov. 2020 à 15:47, Gary Gregory a > > écrit : > > > > > > On Thu, Nov 26, 2020 at 9:43 AM Gilles Sadowski > > > wrote: > > > > > > > Hello Gary. > >

Re: [apache/commons-codec] (doc) Remove duplicate "from"s in javadoc comments (#66)

On Thu, Nov 26, 2020 at 10:46 AM Gilles Sadowski wrote: > Le jeu. 26 nov. 2020 à 16:04, Gary Gregory a > écrit : > > > > On Thu, Nov 26, 2020 at 10:00 AM Gilles Sadowski > > wrote: > > > > > Gary, > > > > > > Le jeu. 26 nov. 2020 à 15:47, Gary Gregory a > > > écrit : > > > > > > > > On Thu, No

Re: [apache/commons-codec] (doc) Remove duplicate "from"s in javadoc comments (#66)

> > > > > [...] > > > > > This is an open-source project and to me that means being open *and* > > > > > transparent. > > > > > > > > I agree, but that's beside my point: You require undue work from a > > > > committer. People who want/need to engage in history tracking will > > > > need to turn t

Re: [commons-jcs] branch master updated: Use for-each. Use final. Remove redundant modifiers.

On Mon, Nov 23, 2020 at 3:37 AM Thomas Vandahl wrote: > Hi Gary, > > On 21.11.20 19:22, ggreg...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > ggregory pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/common