Thank you for the thorough review, Xeno! I'm pulling those changes in now.
-Matt
From: Xeno Amess
Sent: Friday, July 3, 2020 11:17 PM
To: Commons Developers List ; Matt Juntunen
Subject: Re: [VOTE] Release Apache Commons Geometry (full distribution)
1.0-beta1 ba
This vote on rc1 is cancelled. I am going to start on rc2 but it may be a
couple of days before I have time to complete it.
-Matt
From: Matt Juntunen
Sent: Saturday, July 4, 2020 7:57 AM
To: Commons Developers List
Subject: Re: [VOTE] Release Apache Commons Geom
Xeno raised the use of Double.compare to be used to test for equality of
floating point values instead of ==.
This should only be done if -0.0 and 0.0 are considered different. If this is
the case then the accompanying hashCode value should not use Double.hashCode
since when two objects are equ
> This is not the case for:
>
> EpsilonDoublePrecisionContext
> Vector1D
> Vector2D
> Vector3D
> SphericalCoordinates
> PolarCoordinates
Indeed.
I tried to analyze it but get to know you need to treat -0.0 equals 0.0
here, thus I don't think I can simply change it to Double.compare.
And yes, hashC
I just added GEOMETRY-99 and a PR [1] for this. I decided to standardize on
using Double.compare() in equals() and Double.hashCode() in hashCode(). I
completely removed usage of Precision.equals(). Let me know if there are still
issues here.
-Matt
[1] https://github.com/apache/commons-geometry
We have been working hard to prepare Apache Commons Geometry for an initial
release, so I would like to release Apache Commons Geometry (full distribution)
1.0-beta1.
Apache Commons Geometry (full distribution) 1.0-beta1 RC2 is available for
review here:
https://dist.apache.org/repos/dist/d
